You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@training.apache.org by GitBox <gi...@apache.org> on 2019/04/27 08:05:47 UTC
[GitHub] [incubator-training] dspavlov commented on issue #4: Add MIT
license to LICENSE.
dspavlov commented on issue #4: Add MIT license to LICENSE.
URL: https://github.com/apache/incubator-training/pull/4#issuecomment-487265740
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [incubator-training] dspavlov commented on issue #4: Add
MIT license to LICENSE.
Posted by Dmitriy Pavlov <dp...@apache.org>.
Thank you for replies. I remember we had a case when 1 review needed and a
case for 2 LGTMs, I didn't remember which one I should apply here.
But anyway since we're starting to contribute, let's apply 1 LGTM.
вс, 28 апр. 2019 г. в 13:05, Sönke Liebau
<so...@opencore.com.invalid>:
> Hey all,
>
> I think we already decided that in the vote thread on contribution
> guidelines [1].
>
> Reading it again I've phrased it less than totally clear, but it is
> implicitly stated that one review is enough in most cases.
>
> I'll make sure to phrase that clearer in the actual guidelines.
>
> Best regards,
> Sönke
>
> [1]
>
> https://lists.apache.org/thread.html/467cd2008f8045e1d1db87ed541e060ba1989d9c52024f2d011fb91a@%3Cdev.training.apache.org%3E
>
> On Sun, Apr 28, 2019 at 12:00 PM Lars Francke <la...@gmail.com>
> wrote:
>
> > That's for us to define.
> >
> > I like the model of requiring a single +1 from someone other than the
> > contributor itself. That's what most Apache projects I'm involved with
> use.
> >
> > Using that model what you did looks fine to me. Either way we're still
> > getting started and I'm fine with having no strict rules for the first
> few
> > weeks to get all the boilerplate/infrastructure set up.
> >
> > I believe Sönke wanted to write a contributors guide. He's opened a new
> > Jira for it. That would be a good place to discuss this.
> >
> > On Sat, Apr 27, 2019, 10:18 Justin Mclean <ju...@me.com> wrote:
> >
> > > Hi,
> > >
> > > Most other apache communities Im involved with are CTR rather than RTC
> so
> > > no idea what the norm is.
> > >
> > > Thanks,
> > > Justin
> >
>
>
> --
> Sönke Liebau
> Partner
> Tel. +49 179 7940878
> OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
>
Re: [GitHub] [incubator-training] dspavlov commented on issue #4: Add
MIT license to LICENSE.
Posted by Sönke Liebau <so...@opencore.com.INVALID>.
Hey all,
I think we already decided that in the vote thread on contribution
guidelines [1].
Reading it again I've phrased it less than totally clear, but it is
implicitly stated that one review is enough in most cases.
I'll make sure to phrase that clearer in the actual guidelines.
Best regards,
Sönke
[1]
https://lists.apache.org/thread.html/467cd2008f8045e1d1db87ed541e060ba1989d9c52024f2d011fb91a@%3Cdev.training.apache.org%3E
On Sun, Apr 28, 2019 at 12:00 PM Lars Francke <la...@gmail.com>
wrote:
> That's for us to define.
>
> I like the model of requiring a single +1 from someone other than the
> contributor itself. That's what most Apache projects I'm involved with use.
>
> Using that model what you did looks fine to me. Either way we're still
> getting started and I'm fine with having no strict rules for the first few
> weeks to get all the boilerplate/infrastructure set up.
>
> I believe Sönke wanted to write a contributors guide. He's opened a new
> Jira for it. That would be a good place to discuss this.
>
> On Sat, Apr 27, 2019, 10:18 Justin Mclean <ju...@me.com> wrote:
>
> > Hi,
> >
> > Most other apache communities Im involved with are CTR rather than RTC so
> > no idea what the norm is.
> >
> > Thanks,
> > Justin
>
--
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
Re: [GitHub] [incubator-training] dspavlov commented on issue #4: Add
MIT license to LICENSE.
Posted by Lars Francke <la...@gmail.com>.
That's for us to define.
I like the model of requiring a single +1 from someone other than the
contributor itself. That's what most Apache projects I'm involved with use.
Using that model what you did looks fine to me. Either way we're still
getting started and I'm fine with having no strict rules for the first few
weeks to get all the boilerplate/infrastructure set up.
I believe Sönke wanted to write a contributors guide. He's opened a new
Jira for it. That would be a good place to discuss this.
On Sat, Apr 27, 2019, 10:18 Justin Mclean <ju...@me.com> wrote:
> Hi,
>
> Most other apache communities Im involved with are CTR rather than RTC so
> no idea what the norm is.
>
> Thanks,
> Justin
Re: [GitHub] [incubator-training] dspavlov commented on issue #4: Add
MIT license to LICENSE.
Posted by Justin Mclean <ju...@me.com>.
Hi,
Most other apache communities Im involved with are CTR rather than RTC so no idea what the norm is.
Thanks,
Justin
Re: [GitHub] [incubator-training] dspavlov commented on issue #4: Add
MIT license to LICENSE.
Posted by Dmitriy Pavlov <dp...@apache.org>.
Dear Training developers,
I've merged these change, but now in doubt. Is it required to collect 2
LGTMs or 1 is enough?
Sincerely,
Dmitriy Pavlov
сб, 27 апр. 2019 г. в 11:05, GitBox <gi...@apache.org>:
> dspavlov commented on issue #4: Add MIT license to LICENSE.
> URL:
> https://github.com/apache/incubator-training/pull/4#issuecomment-487265740
>
>
> LGTM!
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>