You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/09/30 04:14:27 UTC
[GitHub] zeppelin pull request #1475: [ZEPPELIN-1509] Bug of testcase path in .travis...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1475
[ZEPPELIN-1509] Bug of testcase path in .travis.yml
### What is this PR for?
This PR fixes path of spark testcase.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1509
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1475
----
commit bc74738750366833366f6aa9cc8b3f814a996c6f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-30T04:12:45Z
fix testcase path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1475: [ZEPPELIN-1509] Bug of testcase path in .travis...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1475
[ZEPPELIN-1509] Bug of testcase path in .travis.yml
### What is this PR for?
This PR fixes path of spark testcase.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1509
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1475
----
commit bc74738750366833366f6aa9cc8b3f814a996c6f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-30T04:12:45Z
fix testcase path
commit dead6812c9934beba83b9dda5eacaab07461ec94
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-07T02:14:24Z
Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1509
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1475
@minahlee Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1475
Thank you @minahlee Please help me to solve PR problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1475
@astroshim #1483 is just merged, can you rebase master and see if CI failure on spark 1.1 and 1.2 is gone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1475
CI failures looks irrelevant, merging it into master.
profile 2
```
[32m- should able to create AngularObject[0m
[32mAngularModel[0m
[32m- should able to update AngularObject[0m
[32mAngularModel[0m
[32m- should able to remove AngularObject[0m
[32mAngularModelTest:[0m
[32mAngularModel[0m
[32m- should able to create AngularObject[0m
[32mAngularModel[0m
[32m- should able to update AngularObject[0m
[32mAngularModel[0m
[32m- should able to remove AngularObject[0m
[32mAngularElemTest:[0m
[32mAngularElem[0m
[31m- should provide onclick method *** FAILED ***[0m
[31m The code passed to eventually never returned normally. Attempted 1 times over 530.370455 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:72)[0m
[32mAngularElem[0m
[32m- should print angular display directive only once in a paragraph[0m
[32mAngularElem[0m
[32m- should bind angularObject to ng-model directive[0m
[32mAngularElem[0m
[32m- should able to disassociate AngularObjects[0m
[32mAngularElem[0m
[32m- should allow access to InterpreterContext inside of callback function[0m
[32mAngularElem[0m
[32m- should able to be created from implicit conversion[0m
[32mAngularElemTest:[0m
[32mAngularElem[0m
[32m- should provide onclick method[0m
[32mAngularElem[0m
[32m- should print angular display directive only once in a paragraph[0m
[32mAngularElem[0m
[32m- should bind angularObject to ng-model directive[0m
[32mAngularElem[0m
[32m- should able to disassociate AngularObjects[0m
[32mAngularElem[0m
[32m- should allow access to InterpreterContext inside of callback function[0m
[32mAngularElem[0m
[32m- should able to be created from implicit conversion[0m
[36mRun completed in 2 seconds, 415 milliseconds.[0m
[36mTotal number of tests run: 18[0m
[36mSuites: completed 5, aborted 0[0m
[36mTests: succeeded 17, failed 1, canceled 0, ignored 0, pending 0[0m
[31m*** 1 TEST FAILED ***[0m
```
Profile 10
```
Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 108.789 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT
testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 19.995 sec <<< FAILURE!
java.lang.AssertionError: New Width is : 4
Expected: <true>
but: was <false>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)
testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 19.995 sec <<< FAILURE!
java.lang.AssertionError: New Width is : 8
Expected: <true>
but: was <false>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1475
@minahlee I just rebased. Thank you for your great efforts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1475
Nice catch! I think it is better to fix CI failures in this PR since it will break CI if we merge this. I am willing to help you if you need any :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1475: [ZEPPELIN-1509] Bug of testcase path in .travis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1475
CI is green now, merge if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1475: [ZEPPELIN-1509] Bug of testcase path in .travis...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1475
LGTM, would be great to see Spark profiles passing in CI...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---