[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #416: [IOTDB-188] Delete storage group

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #416: [IOTDB-188] Delete storage group
URL: https://github.com/apache/incubator-iotdb/pull/416#discussion_r327899632
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -1152,7 +1152,21 @@ public TSStatus setStorageGroup(String storageGroup) throws TException {
   }
 
   @Override
-  public TSStatus createTimeseries(TSCreateTimeseriesReq req) {
+  public TSStatus deleteStorageGroup(TSDeleteDataReq req) {
+    if (!checkLogin()) {
+      logger.info(INFO_NOT_LOGIN, IoTDBConstant.GLOBAL_DB_NAME);
+      return new TSStatus(getStatus(TSStatusCode.NOT_LOGIN_ERROR));
+    }
+    MetadataPlan plan = new MetadataPlan(MetadataOperator.NamespaceType.DELETE_STORAGE_GROUP,new Path(req.getPaths().get(0)));
 
 Review comment:
   You can always go beyond the issue as long as it is helpful, but it is fine to leave it as future work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services