You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by da...@apache.org on 2014/01/17 23:07:10 UTC
[36/50] git commit: Remove entries from the callers list properly
Remove entries from the callers list properly
A standard SSA bug using the wrong version of a variable was preventing
the removal of {Worker, Ref} entries in the callers list. This corrects
the issue by using the right variable version.
BugzId: 17731
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-replicator/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-replicator/commit/d17aced7
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-couch-replicator/tree/d17aced7
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-couch-replicator/diff/d17aced7
Branch: refs/heads/import
Commit: d17aced77fc0bcde3c45bd4c89132b143308bbee
Parents: a18f8e9
Author: Paul J. Davis <pa...@gmail.com>
Authored: Fri Mar 1 15:00:29 2013 -0600
Committer: Paul J. Davis <pa...@gmail.com>
Committed: Wed Mar 20 06:02:41 2013 -0500
----------------------------------------------------------------------
src/couch_replicator_httpc_pool.erl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/couchdb-couch-replicator/blob/d17aced7/src/couch_replicator_httpc_pool.erl
----------------------------------------------------------------------
diff --git a/src/couch_replicator_httpc_pool.erl b/src/couch_replicator_httpc_pool.erl
index cb72d42..0a42284 100644
--- a/src/couch_replicator_httpc_pool.erl
+++ b/src/couch_replicator_httpc_pool.erl
@@ -105,7 +105,7 @@ handle_cast({release_worker, Worker}, State) ->
Busy2 = State#state.busy -- [Worker],
Free2 = [Worker | State#state.free];
{{value, From}, Waiting2} ->
- NewCallers1 = monitor_client(Callers, Worker, From),
+ NewCallers1 = monitor_client(NewCallers0, Worker, From),
gen_server:reply(From, {ok, Worker}),
Busy2 = State#state.busy,
Free2 = State#state.free
@@ -141,7 +141,7 @@ handle_info({'EXIT', Pid, _Reason}, State) ->
{noreply, State#state{busy = Busy2, callers = NewCallers0}};
{{value, From}, Waiting2} ->
{ok, Worker} = ibrowse:spawn_link_worker_process(Url),
- NewCallers1 = monitor_client(Callers, Worker, From),
+ NewCallers1 = monitor_client(NewCallers0, Worker, From),
gen_server:reply(From, {ok, Worker}),
NewState = State#state{
busy = [Worker | Busy2],