You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bhuvaneswaran Arumugam <bh...@collab.net> on 2007/04/07 17:23:48 UTC
[PATCH] libsvn_fs_fs: Remove unused function
Hello,
The function in libsvn_fs_fs/err.c svn_fs_fs__err_txn_not_mutable()
intended to be used when trying to change the unchangeable named
transaction in the file system is never used. Please find attached a
patch to remove this function.
[[
Remove one of unused function which was intended to be used when trying
to change the unchangeable named transaction in the filesystem.
* subversion/libsvn_fs_fs/err.c
svn_fs_fs__err_txn_not_mutable(): Remove.
* subversion/libsvn_fs_fs/err.h
svn_fs_fs__err_txn_not_mutable(): Remove.
]]
--
Regards,
Bhuvaneswaran
Re: [PATCH] libsvn_fs_fs: Remove unused function
Posted by Bhuvaneswaran Arumugam <bh...@collab.net>.
On Wed, 2007-04-11 at 04:55 -0400, John Szakmeister wrote:
> John Szakmeister wrote:
> > Bhuvaneswaran Arumugam wrote:
> >> Any review comment for this?
> >
> > Committed in r24527. I tweaked the log message very slightly.
> >
> > Thanks Bhuvaneswaran!
>
> Sorry Bhuvaneswaran, I somehow missed the fact that you had partial
> commit access. I'll remember that for next time!
Thank you John. That's fine anyway.
I also tweaked the log message to retain the standard.
--
Regards,
Bhuvaneswaran
Re: [PATCH] libsvn_fs_fs: Remove unused function
Posted by John Szakmeister <jo...@szakmeister.net>.
John Szakmeister wrote:
> Bhuvaneswaran Arumugam wrote:
>> Any review comment for this?
>
> Committed in r24527. I tweaked the log message very slightly.
>
> Thanks Bhuvaneswaran!
Sorry Bhuvaneswaran, I somehow missed the fact that you had partial
commit access. I'll remember that for next time!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] libsvn_fs_fs: Remove unused function
Posted by John Szakmeister <jo...@szakmeister.net>.
Bhuvaneswaran Arumugam wrote:
> Any review comment for this?
Committed in r24527. I tweaked the log message very slightly.
Thanks Bhuvaneswaran!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] libsvn_fs_fs: Remove unused function
Posted by Bhuvaneswaran Arumugam <bh...@collab.net>.
Any review comment for this?
On Sat, 2007-04-07 at 22:53 +0530, Bhuvaneswaran Arumugam wrote:
> Hello,
>
> The function in libsvn_fs_fs/err.c svn_fs_fs__err_txn_not_mutable()
> intended to be used when trying to change the unchangeable named
> transaction in the file system is never used. Please find attached a
> patch to remove this function.
>
> [[
> Remove one of unused function which was intended to be used when trying
> to change the unchangeable named transaction in the filesystem.
>
> * subversion/libsvn_fs_fs/err.c
> svn_fs_fs__err_txn_not_mutable(): Remove.
> * subversion/libsvn_fs_fs/err.h
> svn_fs_fs__err_txn_not_mutable(): Remove.
> ]]
--
Regards,
Bhuvaneswaran