You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ashishvijaywargiya (via GitHub)" <gi...@apache.org> on 2026/07/31 04:50:58 UTC
[PR] JUnit3 to JUnit5(Jupiter) Runner Migration for OFBiz Test Cases/ Integration Tests - Migration of plugins test cases [ofbiz-plugins]
ashishvijaywargiya opened a new pull request, #344:
URL: https://github.com/apache/ofbiz-plugins/pull/344
JUnit3 to JUnit5(Jupiter) Runner Migration for OFBiz Test Cases/ Integration Tests - Migration of plugins test cases
1) Migrated the last 12 real (non-example) JUnit3 test files to Jupiter - assetmaint's FixedAssetMaintTests, ecommerce's OrderNotificationTests, lucene's LuceneTests, and all 10 scrum test files - dropping each file's (String name) constructor, implementing JupiterTestHelper instead of extending OFBizTestCase, annotating methods @Test, and moving sources from src/main to src/test to match the convention already used by other components' test files.
2) Swapped each migrated file's testdef entry from <junit-test-suite> to <jupiter-test-suite> (assetmainttests.xml, EcommerceTest.xml, lucenetests.xml, scrumTests.xml), and reordered LuceneTests.java's assertion calls from JUnit3/4's (message, expected, actual) argument order to JUnit 5's (expected, actual, message).
3) Added @Order to every @Test method in scrum's multi-method files, proven necessary because JUnit 5's own default ordering ran testAddSprintMember before testRemoveSprintMember and tripped a real, pre-existing de-dup check in assignPartyToWorkEffort on a stale, non-expiring WorkEffortPartyAssignment; files verified order-independent by inspection (assetmaint's FixedAssetMaintTests, ecommerce's OrderNotificationTests, lucene's single-method LuceneTests) were left without @Order.
4) plugins/example gained a new ExampleJupiterTests.groovy (parameterized-test and @Disabled demo) wired through a new example-tests-jupiter test-case, kept side-by-side with the untouched JUnit 3 ExampleTests.groovy as the old/new reference pair; both branches were verified together with a full cleanAll/loadAll plus testIntegration run, with every suite passing, including all four migrated plugin suites - assetmainttests, ecommercetests, lucenetests, and scrumtests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JUnit3 to JUnit5(Jupiter) Runner Migration for OFBiz Test Cases/ Integration Tests - Migration of plugins test cases [ofbiz-plugins]
Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya merged PR #344:
URL: https://github.com/apache/ofbiz-plugins/pull/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JUnit3 to JUnit5(Jupiter) Runner Migration for OFBiz Test Cases/ Integration Tests - Migration of plugins test cases [ofbiz-plugins]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #344:
URL: https://github.com/apache/ofbiz-plugins/pull/344#issuecomment-5139395239
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=344) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=344&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=344&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=344&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=344&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=344&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=344)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org