[GitHub] [spark] MaxGekk commented on a change in pull request #34537: [SPARK-37261][SQL] Allow adding partitions with ANSI intervals in DSv2

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #34537:
URL: https://github.com/apache/spark/pull/34537#discussion_r746283491



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
##########
@@ -98,8 +98,8 @@ object TypeUtils {
     case _ => false
   }
 
-  def failWithIntervalType(dataType: DataType): Unit = {
-    invokeOnceForInterval(dataType, forbidAnsiIntervals = true) {
+  def failWithIntervalType(dataType: DataType, forbidAnsiIntervals: Boolean = true): Unit = {

Review comment:
       We disallow in ALTER TABLE .. ADD COLUMNS and REPLACE COLUMNS. I plan to add unified tests (also need to check v1) and enable ANSI intervals in the commands.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org