You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "georgew5656 (via GitHub)" <gi...@apache.org> on 2024/01/16 15:45:38 UTC
[PR] Implement task payload management with azure storage (druid)
georgew5656 opened a new pull request, #15695:
URL: https://github.com/apache/druid/pull/15695
### Description
Implement pushTaskPayload/streamTaskPayload for azure blob storage so mmless ingestion can run with larger ingestion payloads when using azure as the deep storage location.
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
Currently, if you try running mmless ingestion with azure blob storage as the deep storage provider and use a task payload that is too large, the task logs will throw a NotImplementedException because the relevant functions are not implemented.
#### Release note
Support ingestion payloads larger than ~1MB for mmless ingestion on azure.
##### Key changed/added classes in this PR
* `AzureTaskLogs`
* `AzureTaskLogsTest`
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Implement task payload management with azure storage (druid)
Posted by "YongGang (via GitHub)" <gi...@apache.org>.
YongGang commented on code in PR #15695:
URL: https://github.com/apache/druid/pull/15695#discussion_r1456280436
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java:
##########
@@ -99,6 +99,20 @@ private void pushTaskFile(final File logFile, String taskKey)
}
}
+ @Override
+ public void pushTaskPayload(String taskid, File taskPayloadFile)
+ {
+ final String taskKey = getTaskPayloadKey(taskid);
+ log.info("Pushing task payload [%s] to location [%s]", taskPayloadFile, taskKey);
+ pushTaskFile(taskPayloadFile, taskKey);
+ }
+
+ @Override
+ public Optional<InputStream> streamTaskPayload(String taskid) throws IOException
+ {
+ return streamTaskFile(taskid, 0, getTaskPayloadKey(taskid));
Review Comment:
Seems the `taskid` is not used in `streamTaskFile` method thus can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Implement task payload management with azure storage (druid)
Posted by "georgew5656 (via GitHub)" <gi...@apache.org>.
georgew5656 commented on code in PR #15695:
URL: https://github.com/apache/druid/pull/15695#discussion_r1457624148
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java:
##########
@@ -99,6 +99,20 @@ private void pushTaskFile(final File logFile, String taskKey)
}
}
+ @Override
+ public void pushTaskPayload(String taskid, File taskPayloadFile)
+ {
+ final String taskKey = getTaskPayloadKey(taskid);
+ log.info("Pushing task payload [%s] to location [%s]", taskPayloadFile, taskKey);
+ pushTaskFile(taskPayloadFile, taskKey);
+ }
+
+ @Override
+ public Optional<InputStream> streamTaskPayload(String taskid) throws IOException
+ {
+ return streamTaskFile(taskid, 0, getTaskPayloadKey(taskid));
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Implement task payload management with azure storage (druid)
Posted by "georgew5656 (via GitHub)" <gi...@apache.org>.
georgew5656 merged PR #15695:
URL: https://github.com/apache/druid/pull/15695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org