You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2023/04/06 03:26:25 UTC
[GitHub] [ozone] smengcl commented on a diff in pull request #4543: HDDS-8317. [Snapshot] DirectoryDeletingService should clean up Snapshot's deletedDirTable.
smengcl commented on code in PR #4543:
URL: https://github.com/apache/ozone/pull/4543#discussion_r1159246190
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -244,4 +422,35 @@ public ScmBlockLocationProtocol getScmClient() {
public AtomicLong getRunCount() {
return runCount;
}
Review Comment:
Can we just return `Long` instead of having every single caller call `get()` individually?
```suggestion
public Long getRunCount() {
return runCount.get();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org