You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2024/07/22 04:55:06 UTC
[PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
itholic opened a new pull request, #47436:
URL: https://github.com/apache/spark/pull/47436
### What changes were proposed in this pull request?
This PR proposes to make the parameter naming of `PySparkException` consistent with JVM
### Why are the changes needed?
The parameter names of `PySparkException` are different from `SparkException` so there is an inconsistency when searching those parameters from error logs.
SparkException:
https://github.com/apache/spark/blob/6508b1f5e18731359354af0a7bcc1382bc4f356b/common/utils/src/main/scala/org/apache/spark/SparkException.scala#L27-L33
PySparkException:
https://github.com/apache/spark/blob/6508b1f5e18731359354af0a7bcc1382bc4f356b/python/pyspark/errors/exceptions/base.py#L29-L40
### Does this PR introduce _any_ user-facing change?
The error parameter names are changed from:
- `error_class` -> `errorClass`
- `message_parameters` -> `messageParameters`
- `query_contexts` -> `context`
### How was this patch tested?
The existing CI should pass
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #47436:
URL: https://github.com/apache/spark/pull/47436#discussion_r1685967841
##########
python/docs/source/development/logger.rst:
##########
@@ -52,7 +52,7 @@ Example log entry:
"file": "/path/to/file.py",
"line_no": "17",
Review Comment:
What about line_no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #47436:
URL: https://github.com/apache/spark/pull/47436#issuecomment-2246941650
Merged into master. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #47436:
URL: https://github.com/apache/spark/pull/47436#discussion_r1685984713
##########
python/docs/source/development/logger.rst:
##########
@@ -52,7 +52,7 @@ Example log entry:
"file": "/path/to/file.py",
"line_no": "17",
Review Comment:
Created followup here: https://github.com/apache/spark/pull/47437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #47436:
URL: https://github.com/apache/spark/pull/47436#discussion_r1685979935
##########
python/docs/source/development/logger.rst:
##########
@@ -52,7 +52,7 @@ Example log entry:
"file": "/path/to/file.py",
"line_no": "17",
Review Comment:
yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #47436:
URL: https://github.com/apache/spark/pull/47436#issuecomment-2242087457
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #47436:
URL: https://github.com/apache/spark/pull/47436#discussion_r1685981444
##########
python/docs/source/development/logger.rst:
##########
@@ -52,7 +52,7 @@ Example log entry:
"file": "/path/to/file.py",
"line_no": "17",
Review Comment:
Sounds good! Let me submit a quick followup for https://github.com/apache/spark/pull/47145 as I think this is technically not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #47436:
URL: https://github.com/apache/spark/pull/47436#discussion_r1685975346
##########
python/docs/source/development/logger.rst:
##########
@@ -52,7 +52,7 @@ Example log entry:
"file": "/path/to/file.py",
"line_no": "17",
Review Comment:
This indicates the line number retrieved from stack frame by using `frame.lineno`.
On second thought maybe we should use `lineno` or `line_number` instead `line_no`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic closed pull request #47436: [SPARK-48961][PYTHON] Make the parameter naming of `PySparkException` consistent with JVM
URL: https://github.com/apache/spark/pull/47436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org