You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2016/06/22 16:32:24 UTC
[GitHub] zeppelin pull request #1067: ZEPPELIN-1048: Pandas support for python interp...
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1067
ZEPPELIN-1048: Pandas support for python interpreter
### What is this PR for?
### What type of PR is it?
Feature
### Todos
* [x] fix NPE in logs on empty paragraph execution
* [x] matplotlib: refactor `zeppelin_show(plt)` -> `z.show(plt)`
* [x] pandas: support `z.show(df)`
* [ ] update docs
### What is the Jira issue?
[ZEPPELIN-1048](https://issues.apache.org/jira/browse/ZEPPELIN-1048)
### How should this be tested?
"Zeppelin Tutorial: Python - matplotlib basic" should work, and
```python
import pandas as pd
rates = pd.read_csv("bank.csv", sep=";")
z.show(rates)
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin python/pandas-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1067.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1067
----
commit 15646a1cc4ad0e4967161f5f4507c2494c7b40b8
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-06-20T09:52:27Z
Python: refactoring to z.show()
commit a7248cdc94bd6f9619df5904225b7883b5aea193
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-06-22T03:05:33Z
Python: draft of pandas support
commit bc91b86f94c7529d279600d7408687fc874c0382
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-06-22T08:49:23Z
Python: skip interpreting empty paragraphs
commit 52e787d1a452a50cecc5b11e480ca0fbd923f47f
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-06-22T08:52:26Z
Python: pandas DataFrame using Table display system
commit 71be41890378a96202c9ce6e3b4e1a107fbed098
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-06-22T16:23:40Z
Python: limit 1000 for table display system on DataFrame
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1067
I saw https://issues.apache.org/jira/browse/ZEPPELIN-1048 marked 0.7.0 as a fix version.
Not a strong opinion, and i don't think it should be blocker for 0.6 release. But If we're going to change api from `zeppelin_show(plt)` to `z.show(plt)`, how about apply this api change to 0.6 branch?
While `zeppelin_show()` introduced recently, now API change cost is not high. But once 0.6.0 released and people starts use `zeppelin_show()`, API change cost will be increased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
Thank you guys for the prompt reviews!
@Leemoonsoo agree on API change and I'm glad to have it merged in 0.6, updated JIRA
@minahlee review addressed in 3b1ad36
If there is no more discussion, going to merge it to *master* and *branch-0.6*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
It is ready to be merged now.
TODOs will be addressed in different PR, after #1063 is merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
cherry-picking to branch-0.6 fails with merge conflicts as master and branch-0.6 diverged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1067
I left few notes on documentation and `help() ` function. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1067: ZEPPELIN-1048: Pandas support for python interp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
done in 97f25e2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---