You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/06 00:20:02 UTC
[GitHub] [spark] huaxingao opened a new pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
huaxingao opened a new pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818
### What changes were proposed in this pull request?
Auditing new ML Scala APIs introduced in 3.0. Fix found issues.
### Why are the changes needed?
### Does this PR introduce any user-facing change?
Yes. Some doc changes
### How was this patch tested?
Existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595555246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119428/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596617637
Thanks a lot! @srowen @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389185917
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMClassifier.scala
##########
@@ -186,7 +186,7 @@ class FMClassifier @Since("3.0.0") (
@Since("3.0.0")
def setSeed(value: Long): this.type = set(seed, value)
- override protected[spark] def train(
+ override protected def train(
Review comment:
The super class has ```protected def train(dataset: Dataset[_])```. When overriding this, I thought it's not supposed to widen the scope? The other classifiers have
```override protected def train```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169642
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596171568
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167752
**[Test build #119529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119529/testReport)** for PR 27818 at commit [`c6f1a3e`](https://github.com/apache/spark/commit/c6f1a3e0ec9206a9fec9757fcb7c33497126b53a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389185903
##########
File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala
##########
@@ -34,12 +34,13 @@ import org.apache.spark.sql.types._
*/
@Since("3.0.0")
@Experimental
-class MultilabelClassificationEvaluator (override val uid: String)
+class MultilabelClassificationEvaluator @Since("3.0.0") (@Since("3.0.0") override val uid: String)
Review comment:
Almost all of the ml classes do this way. I am doing this simply for consistency. I am OK to remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389336697
##########
File path: mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
##########
@@ -195,7 +195,8 @@ class AFTSurvivalRegression @Since("1.6.0") (@Since("1.6.0") override val uid: S
}
@Since("3.0.0")
Review comment:
If we can safely mark it protected, then do not need this since annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389193710
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMClassifier.scala
##########
@@ -186,7 +186,7 @@ class FMClassifier @Since("3.0.0") (
@Since("3.0.0")
def setSeed(value: Long): this.type = set(seed, value)
- override protected[spark] def train(
+ override protected def train(
Review comment:
OK that's fine; this hasn't even been released anyway. Consistency is good.
(There are use cases for widening access but nothing applicable here I think)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596171574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119529/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596547415
Merged to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596173257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119530/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169573
**[Test build #119530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119530/testReport)** for PR 27818 at commit [`46a9f21`](https://github.com/apache/spark/commit/46a9f2132ccaaca4de2bfd1152ffa3f1bdebff86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24260/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169642
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595560720
cc @srowen @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595513390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24165/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595554932
**[Test build #119428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119428/testReport)** for PR 27818 at commit [`c7292fa`](https://github.com/apache/spark/commit/c7292fa8567c322f7b31af2228087becd576b41e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MultilabelClassificationEvaluator @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
* `class RankingEvaluator @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
* `class RobustScaler @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596173257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119530/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595555244
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595512970
**[Test build #119428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119428/testReport)** for PR 27818 at commit [`c7292fa`](https://github.com/apache/spark/commit/c7292fa8567c322f7b31af2228087becd576b41e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r388978555
##########
File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala
##########
@@ -34,12 +34,13 @@ import org.apache.spark.sql.types._
*/
@Since("3.0.0")
@Experimental
-class MultilabelClassificationEvaluator (override val uid: String)
+class MultilabelClassificationEvaluator @Since("3.0.0") (@Since("3.0.0") override val uid: String)
Review comment:
It's OK if it's for consistency, but if the whole class is "since 3.0" then implicitly so is everything in it. Do we really do this in a lot of the code? it just seems especially noisy to mark the constructor and then all its args this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595513386
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596171574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119529/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595513390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24165/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595555246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119428/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169573
**[Test build #119530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119530/testReport)** for PR 27818 at commit [`46a9f21`](https://github.com/apache/spark/commit/46a9f2132ccaaca4de2bfd1152ffa3f1bdebff86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167752
**[Test build #119529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119529/testReport)** for PR 27818 at commit [`c6f1a3e`](https://github.com/apache/spark/commit/c6f1a3e0ec9206a9fec9757fcb7c33497126b53a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r388978699
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMClassifier.scala
##########
@@ -186,7 +186,7 @@ class FMClassifier @Since("3.0.0") (
@Since("3.0.0")
def setSeed(value: Long): this.type = set(seed, value)
- override protected[spark] def train(
+ override protected def train(
Review comment:
Oh why was this an issue? out of curiosity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595555244
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24260/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596171493
**[Test build #119529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119529/testReport)** for PR 27818 at commit [`c6f1a3e`](https://github.com/apache/spark/commit/c6f1a3e0ec9206a9fec9757fcb7c33497126b53a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MultilabelClassificationEvaluator @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
* `class RankingEvaluator @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
* `class RobustScaler @Since(\"3.0.0\") (@Since(\"3.0.0\") override val uid: String)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596171568
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167850
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596173255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389193572
##########
File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala
##########
@@ -34,12 +34,13 @@ import org.apache.spark.sql.types._
*/
@Since("3.0.0")
@Experimental
-class MultilabelClassificationEvaluator (override val uid: String)
+class MultilabelClassificationEvaluator @Since("3.0.0") (@Since("3.0.0") override val uid: String)
Review comment:
OK leave it in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595513386
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389336710
##########
File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala
##########
@@ -34,12 +34,13 @@ import org.apache.spark.sql.types._
*/
@Since("3.0.0")
@Experimental
-class MultilabelClassificationEvaluator (override val uid: String)
+class MultilabelClassificationEvaluator @Since("3.0.0") (@Since("3.0.0") override val uid: String)
Review comment:
I also do not feel strongly about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-595512970
**[Test build #119428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119428/testReport)** for PR 27818 at commit [`c7292fa`](https://github.com/apache/spark/commit/c7292fa8567c322f7b31af2228087becd576b41e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596173255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27818: [SPARK-30929][ML]
ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169643
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24261/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27818: [SPARK-30929][ML] ML,
GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596173191
**[Test build #119530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119530/testReport)** for PR 27818 at commit [`46a9f21`](https://github.com/apache/spark/commit/46a9f2132ccaaca4de2bfd1152ffa3f1bdebff86).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596167850
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#issuecomment-596169643
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24261/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org