You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Maarten Billemont (JIRA)" <ji...@codehaus.org> on 2009/04/10 14:31:55 UTC
[jira] Created: (MDEP-208) finalName of artifacts not in the
reactor is not taken into account.
finalName of artifacts not in the reactor is not taken into account.
--------------------------------------------------------------------
Key: MDEP-208
URL: http://jira.codehaus.org/browse/MDEP-208
Project: Maven 2.x Dependency Plugin
Issue Type: Bug
Components: copy-dependencies, unpack-dependencies
Affects Versions: 2.0
Reporter: Maarten Billemont
Assignee: Brian Fox
Setting:
A project where module B has a dependency on module A.
Module B uses copy-dependencies to copy that dependency into a certain directory.
What works:
When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
What doesn't work:
When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-208) finalName of artifacts not in the
reactor is not taken into account.
Posted by "Maarten Billemont (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172628#action_172628 ]
Maarten Billemont commented on MDEP-208:
----------------------------------------
Our scenario is as follows:
We have a maven artifact which yields a ZIP that contains a pre-configured JBoss installation. This contains each of our application's EAR files in the JBoss deploy directory.
These EAR files are dependencies of the distribution artifact, and copy-dependencies is used to copy all EAR dependencies of the distribution artifact into the JBoss deploy directory. Since JBoss uses the EAR filename to determine the JNDI binding of all EJBs, it is absolutely vital that the naming of these EAR files remains consistent, no matter how the artifact is built - provided, of course, the build is successful.
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: http://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MDEP-208) finalName of artifacts not
in the reactor is not taken into account.
Posted by "Maarten Billemont (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=259090#action_259090 ]
Maarten Billemont edited comment on MDEP-208 at 3/7/11 4:09 AM:
----------------------------------------------------------------
So, with this fix (as tested in 2.2), my artifacts are named [artifactId]-[version].[packaging] either way, regardless of what the finalName is and regardless of whether the artifacts are in the reactor or not. That kind of throws finalName out the window completely. Is this the intended effect?
This causes severe issues with us, since we actually RELY on our artifact's finalName to name them a certain way. That's because JBoss deploys .ear files in sort-order. We need our core application to be deployed before any applications that use its beans.
was (Author: lhunath):
So, with this fix (as tested in 2.2), my artifacts are named [artifactId]-[version].[packaging] either way, regardless of what the finalName is. That kind of throws finalName out the window completely. Is this the intended effect?
This causes severe issues with us, since we actually RELY on our artifact's finalName to name them a certain way. That's because JBoss deploys .ear files in sort-order. We need our core application to be deployed before any applications that use its beans.
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: http://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
> Fix For: 2.2
>
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-208) finalName of artifacts not in the
reactor is not taken into account.
Posted by "Maarten Billemont (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=259090#action_259090 ]
Maarten Billemont commented on MDEP-208:
----------------------------------------
So, with this fix (as tested in 2.2), my artifacts are named [artifactId]-[version].[packaging] either way, regardless of what the finalName is. That kind of throws finalName out the window completely. Is this the intended effect?
This causes severe issues with us, since we actually RELY on our artifact's finalName to name them a certain way. That's because JBoss deploys .ear files in sort-order. We need our core application to be deployed before any applications that use its beans.
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: http://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
> Fix For: 2.2
>
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MDEP-208) finalName of artifacts not in the reactor
is not taken into account.
Posted by "Stephen Connolly (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Connolly closed MDEP-208.
---------------------------------
Resolution: Fixed
with version 2.3 the dependency:copy and dependency:unpack goals resolve from the reactor and the artifactItems allows exact control over the copied or unpacked artifact names.
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: https://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
> Fix For: 2.2
>
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MDEP-208) finalName of artifacts not in the
reactor is not taken into account.
Posted by "Maarten Billemont (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Billemont reopened MDEP-208:
------------------------------------
Given the above comment, this issue needs to be re-evaluated.
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: http://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
> Fix For: 2.2
>
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MDEP-208) finalName of artifacts not in the reactor
is not taken into account.
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MDEP-208.
--------------------------
Resolution: Fixed
Fix Version/s: 2.2
fixed by MDEP-264
> finalName of artifacts not in the reactor is not taken into account.
> --------------------------------------------------------------------
>
> Key: MDEP-208
> URL: http://jira.codehaus.org/browse/MDEP-208
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies, unpack-dependencies
> Affects Versions: 2.0
> Reporter: Maarten Billemont
> Assignee: Brian Fox
> Fix For: 2.2
>
>
> Setting:
> A project where module B has a dependency on module A.
> Module B uses copy-dependencies to copy that dependency into a certain directory.
> What works:
> When both module A and B are in the maven reactor, module A's finalName is taken into account and the artifact that ends up copied into our directory uses the filename as given by finalName.
> What doesn't work:
> When only module B is in the maven reactor, module A is copied from the local repository where it has a different filename. Maven-dependency-plugin does not correct the filename during copy and as a result we have an artifact in our destination directory with a different name.
> This behavior is inconsistent and a solution should be established. I propose maven-dependency-plugin reads the dependency (A)'s POM and checks whether it has a finalName set. If so, it should modify the destination filename of the dependency copy operation accordingly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira