You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:32:46 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #21493: Add DistSQL `REFRESH DATABASE METADATA`
RaigorJiang opened a new pull request, #21493:
URL: https://github.com/apache/shardingsphere/pull/21493
Fixes #21483.
Changes proposed in this pull request:
- Add a new DistSQL `REFRESH DATABASE METADATA`
- Add parse test case.
- Update document of RAL
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed pull request #21493: Add DistSQL `REFRESH DATABASE METADATA`
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed pull request #21493: Add DistSQL `REFRESH DATABASE METADATA`
URL: https://github.com/apache/shardingsphere/pull/21493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #21493: Add DistSQL `REFRESH DATABASE METADATA`
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #21493:
URL: https://github.com/apache/shardingsphere/pull/21493#issuecomment-1275988146
In order to achieve the expected refresh functionality, the governance interface may need to be updated accordingly, so I changed the status to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #21493: Add DistSQL `REFRESH DATABASE METADATA`
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #21493:
URL: https://github.com/apache/shardingsphere/pull/21493#issuecomment-1290031842
Due to too many conflicts, I will close this PR and then resubmit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21493: Add DistSQL `REFRESH DATABASE METADATA`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21493:
URL: https://github.com/apache/shardingsphere/pull/21493#issuecomment-1274339088
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21493?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21493](https://codecov.io/gh/apache/shardingsphere/pull/21493?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b37a3e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c4b847a7a2c737a1885ead254a5c9ae229f64136?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b847a) will **decrease** coverage by `0.01%`.
> The diff coverage is `29.72%`.
```diff
@@ Coverage Diff @@
## master #21493 +/- ##
============================================
- Coverage 61.26% 61.24% -0.02%
- Complexity 2508 2511 +3
============================================
Files 4103 4106 +3
Lines 56988 57022 +34
Branches 7532 7538 +6
============================================
+ Hits 34911 34925 +14
- Misses 19152 19168 +16
- Partials 2925 2929 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../infra/context/cursor/CursorConnectionContext.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb250ZXh0L2N1cnNvci9DdXJzb3JDb25uZWN0aW9uQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...peline/scenario/migration/MigrationJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9taWdyYXRpb24vTWlncmF0aW9uSm9iQVBJSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../ral/updatable/RefreshDatabaseMetadataHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9SZWZyZXNoRGF0YWJhc2VNZXRhZGF0YUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...updatable/RefreshTableMetadataStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvdXBkYXRhYmxlL1JlZnJlc2hUYWJsZU1ldGFkYXRhU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `72.72% <ø> (ø)` | |
| [...datable/RefreshTableMetadataStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2pheGIvY2FzZXMvZG9tYWluL3N0YXRlbWVudC9kaXN0c3FsL3JhbC91cGRhdGFibGUvUmVmcmVzaFRhYmxlTWV0YWRhdGFTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...rding/merge/ddl/fetch/FetchStreamMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGRsL2ZldGNoL0ZldGNoU3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `77.64% <36.36%> (-6.14%)` | :arrow_down: |
| [...atable/RefreshDatabaseMetadataStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvdXBkYXRhYmxlL1JlZnJlc2hEYXRhYmFzZU1ldGFkYXRhU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `40.00% <40.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `76.19% <100.00%> (+0.58%)` | :arrow_up: |
| [.../distsql/ral/impl/UpdatableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvVXBkYXRhYmxlUkFMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/21493/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org