You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "kirktrue (via GitHub)" <gi...@apache.org> on 2024/04/16 01:33:17 UTC

[PR] KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions [kafka]

kirktrue opened a new pull request, #15724:
URL: https://github.com/apache/kafka/pull/15724

   Partitions that are marked as `pendingOnAssignedCallback` should not be reset in `resetInitializingPositions()`. Pending partitions are omitted from the set returned by `initializingPartitions()`. As a result, the Consumer does not include them in the set of partitions for which it attempts to load committed offsets. The code used by the Consumer to reset positions  (`resetInitializingPositions()`) should likewise skip partitions marked as pending.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions [kafka]

Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru merged PR #15724:
URL: https://github.com/apache/kafka/pull/15724


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions [kafka]

Posted by "kirktrue (via GitHub)" <gi...@apache.org>.
kirktrue commented on PR #15724:
URL: https://github.com/apache/kafka/pull/15724#issuecomment-2058081763

   @lucasbru—please kindly take a look at this issue that's occasionally causing consumers to ignore committed offsets. The result is the consumer resets the partition's position back to 0, causing reprocessing of messages.
   
   cc @lianetm @philipnee


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org