You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/07 12:16:56 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #9479: [query] Migrate api v1 query to new location

villebro commented on a change in pull request #9479: [query] Migrate api v1 query to new location
URL: https://github.com/apache/incubator-superset/pull/9479#discussion_r404760899
 
 

 ##########
 File path: tests/queries/api_tests.py
 ##########
 @@ -245,3 +261,25 @@ def test_get_queries_no_data_access(self):
         # rollback changes
         db.session.delete(query)
         db.session.commit()
+
+    def test_query_exec(self):
+        """
+            Query API: Test exec query
+        """
+        self.login(username="admin")
+        qc_dict = self._get_query_context_dict()
 
 Review comment:
   nti: I would prefer `query_context` as the variable name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org