You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/22 13:44:47 UTC
[GitHub] [camel] orpiske opened a new pull request #4033: CAMEL-15326: fix incorrect handling of API responses
orpiske opened a new pull request #4033:
URL: https://github.com/apache/camel/pull/4033
Includes:
- fix a NPE thrown when the slack conversation.list request fails
- report missing scopes when polling data from Slack
[x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4033: CAMEL-15326: fix incorrect handling of API responses
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4033:
URL: https://github.com/apache/camel/pull/4033#issuecomment-663359597
Maybe we could backport to 3.4.x too. Can you please open a PR to camel-3.4.x branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4033: CAMEL-15326: fix incorrect handling of API responses
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4033:
URL: https://github.com/apache/camel/pull/4033#issuecomment-662463594
With this patch, if there are errors ... For example, if the Slack permissions/scopes are missing, the error is raised and the details are logged.
Here's an example of trying to poll messages from Slack without the proper scopes:
```
2020-07-22 15:40:02,816 [/opensourcetest] WARN org.apache.camel.component.slack.SlackConsumer - Consumer Consumer[slack://opensourcetest?maxResults=1&token=removed] failed polling endpoint: slack://opensourcetest?maxResults=1&token=removed. Will try again at next poll. Caused by: [org.apache.camel.RuntimeCamelException - API request to Slack failed: missing_scope]
org.apache.camel.RuntimeCamelException: API request to Slack failed: missing_scope
at org.apache.camel.component.slack.SlackConsumer.checkSlackReply(SlackConsumer.java:171) ~[camel-slack-3.4.2-SNAPSHOT.jar:3.4.2-SNAPSHOT]
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4033: CAMEL-15326: fix incorrect handling of API responses
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4033:
URL: https://github.com/apache/camel/pull/4033#issuecomment-663374922
> Maybe we could backport to 3.4.x too. Can you please open a PR to [camel-3](https://issues.apache.org/jira/browse/CAMEL-3).4.x branch?
Absolutely. I will open a PR with this patch for the 3.4.x branch, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #4033: CAMEL-15326: fix incorrect handling of API responses
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #4033:
URL: https://github.com/apache/camel/pull/4033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4033: CAMEL-15326: fix incorrect handling of API responses
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4033:
URL: https://github.com/apache/camel/pull/4033#issuecomment-663358850
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org