You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/24 02:32:18 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating

dongjoon-hyun commented on a change in pull request #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
URL: https://github.com/apache/spark/pull/26227#discussion_r338357265
 
 

 ##########
 File path: python/pyspark/sql/readwriter.py
 ##########
 @@ -788,7 +788,7 @@ def saveAsTable(self, name, format=None, mode=None, partitionBy=None, **options)
 
     @since(1.4)
     def json(self, path, mode=None, compression=None, dateFormat=None, timestampFormat=None,
-             lineSep=None, encoding=None):
+             lineSep=None, encoding=None, ignoreNullFields=None):
 
 Review comment:
   This seems to be beyond `add doc`. Could you update the PR title, @stczwd ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org