[GitHub] [spark] LuciferYang commented on pull request #39789: [SPARK-42228][CONNECT][BUILD] Add shade and relocation rule of grpc to connect-client-jvm module

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #39789:
URL: https://github.com/apache/spark/pull/39789#issuecomment-1407603498

   cc @HyukjinKwon the test demo like https://github.com/apache/spark/pull/39788
   
   We can use the following command to do a comparison test (shaded grpc or not in `connect-client-jvm` module) with the demo change:
   
   ```
   mvn clean install -pl connector/connect/client/integration-tests -am -Dtest=none -DwildcardSuites=org.apache.spark.sql.ClientE2ETestSuite
   ```
   
   without shaded grpc with fail.
   
   `ClientE2ETestSuite ` will not cause test failure in the `connect-client-jvm` module because the test is not using the shaded `connect-client-jvm` jar , and the relocation not be execute in that scene.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org