You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 07:24:55 UTC

[GitHub] [superset] rusackas commented on pull request #12412: fix: uneven list header padding (#12029)

rusackas commented on pull request #12412:
URL: https://github.com/apache/superset/pull/12412#issuecomment-759259796


   Code looks good to me. Tempted to do the usual nag about `gridUnit`, but I don't like fractional `gridUnit`s, so I'll let the `2px` go :)
   
   I'd merge this, but would love to have @nytai's nod of approval first :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org