[GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...

[JPercivall <gi...@git.apache.org>]

Github user JPercivall commented on the pull request:

    https://github.com/apache/nifi/pull/337#issuecomment-217470408
  
    @pvillard31 According to the SO linked in the ticket, when the timeout being set is reached "the request is redispatch with a DispatcherType of ASYNC". In StandardHttpContextMap there already is a "Request Expiration" property. This will remove the request from the HttpContextMap's internal queue and respond with a "SERVICE UNAVAILABLE" once the Expiration ("timeout") hits[2]. 
    
    This leads to the question: does the user really want to respond in this Jetty specific way or should the timeout of jetty just be set higher than the ContextMap Expiration so that the request responds with "SERVICE UNAVAILABLE"?
    
    [1] https://github.com/apache/nifi/blob/aa99884782e54c54ee138f5609b3be84628e96f9/nifi-nar-bundles/nifi-standard-services/nifi-http-context-map-bundle/nifi-http-context-map/src/main/java/org/apache/nifi/http/StandardHttpContextMap.java#L59-L59
    [2] https://github.com/apache/nifi/blob/aa99884782e54c54ee138f5609b3be84628e96f9/nifi-nar-bundles/nifi-standard-services/nifi-http-context-map-bundle/nifi-http-context-map/src/main/java/org/apache/nifi/http/StandardHttpContextMap.java#L178-L178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---