You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/18 15:24:06 UTC
[GitHub] [nifi] markobean opened a new pull request, #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
markobean opened a new pull request, #6217:
URL: https://github.com/apache/nifi/pull/6217
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
Updates the FlowParser to use the "Instance Identifier" of the root process group versus "Identifier". When using flow.json.gz (versus flow.xml.gz), this nuance makes a difference in particular when establishing access policies on initial startup. Policies were being incorrectly defined when not using Instance Identifier.
For testing, NiFi was configured with the 'managed-authorizer' (nifi.properties) and a specific initial admin user (authorizers.xml). NiFi was started in order to generate an initial, empty flow.xml.gz/flow.json.gz. NiFi was shutdown and the authorizations.xml and users.xml files were removed. NiFi was started again.
Now, since both the flow and a root process group exist, component access policies for the group are created and the initial admin user is added to the policy. Prior to this fix, the component access policies would be populated incorrectly with the "Identifier" UUID. Now, they are populated correctly with the "Instance Identifier" UUID.
[NIFI-10228](https://issues.apache.org/jira/browse/NIFI-10228)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
markobean commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1296282966
@markap14 There is no issue with Input/Output ports. The flow.json.gz is accurate which is where the Input/Output ports become relevant. Rather it is the `FlowInfo` which contains incorrect information. This object contains ports by reference, but not their ID values directly; the references and their ID values are correct. However, `FlowInfo` does contain the UUID for the root process group. This is the value which is in error and needs to be corrected; this PR corrects this error. The only change required is the root group UUID referenced when creating the `FlowInfo` object.
The PR was rebased to current main, but otherwise remains the same. No additional changes are required.
As noted in the original JIRA ticket description, you can observe the error by starting NiFi with an existing flow.json.gz (and flow.xml.gz) but without authorizations.xml or users.xml. Also, the managed-authorizer should be used, not single-user-authorizer, and an Initial Admin User should be specified. You will see that the root group UUID found in the Component Access Policies in the resulting authorizations.xml is incorrect. It references the root group `identifier` rather than `instanceIdentifier`. Repeat the above process with this PR and you will note the `instanceIdentifier` is correctly used in the policies (authorizations.xml.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1303843264
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
markobean commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1303912935
Appreciate the review @mattyb149 ! I know this one took a bit of setup to reproduce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
markobean commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1293746255
@markap14 reports this same issue applies to the input/output ports as well. Will investigate/update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1303895953
+1 LGTM, reproduced and verified expected behavior. Thanks for the fix! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] michael81877 commented on pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
michael81877 commented on PR #6217:
URL: https://github.com/apache/nifi/pull/6217#issuecomment-1188755000
LGTM. Only comment is whether this is easily verified by a unit test. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6217: NIFI-10228: parse json flow using instanceIdentifier as the UUID
URL: https://github.com/apache/nifi/pull/6217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org