You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/09/11 01:40:37 UTC
[PR] [SPARK-59154][FOLLOWUP][ML] Clean up DecisionTreeRegressionModel transform [spark]
zhengruifeng opened a new pull request, #58725:
URL: https://github.com/apache/spark/pull/58725
### What changes were proposed in this pull request?
This is a follow-up to #58454.
This pull request aligns the local column and UDF names in
`DecisionTreeRegressionModel.transform` with the other tree regression models and removes the
unused `predictVariance` method. The variance prediction logic was moved directly into the
transform UDF by #58454.
### Why are the changes needed?
The old helper became unused after the transform closure optimization, and consistent local names
make the related tree regression transform implementations easier to compare and maintain.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The following checks passed:
```
build/sbt mllib/compile
git diff --check upstream/master...HEAD
```
Changed-file line-length and non-ASCII checks also passed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59154][FOLLOWUP][ML] Clean up DecisionTreeRegressionModel transform [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58725:
URL: https://github.com/apache/spark/pull/58725#issuecomment-5632298354
Thank you @zhengruifeng and @HyukjinKwon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59154][FOLLOWUP][ML] Clean up DecisionTreeRegressionModel transform [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58725:
URL: https://github.com/apache/spark/pull/58725#issuecomment-5635252888
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/9a8c7cdb200d5640635bc6aee809240b41ffef7a
- merged into branch-4.x https://github.com/apache/spark/commit/d89d626889dda05e864a6e5226b8f304eb8b6c58
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59154][FOLLOWUP][ML] Clean up DecisionTreeRegressionModel transform [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #58725: [SPARK-59154][FOLLOWUP][ML] Clean up DecisionTreeRegressionModel transform
URL: https://github.com/apache/spark/pull/58725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org