You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Niels Beekman (Created) (JIRA)" <ji...@apache.org> on 2012/03/13 10:43:38 UTC
[jira] [Created] (TIKA-875) Temporary file leak in ImageParser
Temporary file leak in ImageParser
----------------------------------
Key: TIKA-875
URL: https://issues.apache.org/jira/browse/TIKA-875
Project: Tika
Issue Type: Bug
Components: parser
Affects Versions: 1.0
Reporter: Niels Beekman
The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TIKA-875) Temporary file leak in ImageParser
Posted by "Michael McCandless (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned TIKA-875:
---------------------------------------
Assignee: Michael McCandless
> Temporary file leak in ImageParser
> ----------------------------------
>
> Key: TIKA-875
> URL: https://issues.apache.org/jira/browse/TIKA-875
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.0
> Reporter: Niels Beekman
> Assignee: Michael McCandless
> Attachments: patch.svn.diff
>
>
> The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-875) Temporary file leak in ImageParser
Posted by "Niels Beekman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niels Beekman updated TIKA-875:
-------------------------------
Attachment: patch.svn.diff
Attached is a patch that fixes this issue (diff against tags/1.0). Additionally, the reader is disposed in a try/finally construct.
> Temporary file leak in ImageParser
> ----------------------------------
>
> Key: TIKA-875
> URL: https://issues.apache.org/jira/browse/TIKA-875
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.0
> Reporter: Niels Beekman
> Attachments: patch.svn.diff
>
>
> The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TIKA-875) Temporary file leak in ImageParser
Posted by "Niels Beekman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228298#comment-13228298 ]
Niels Beekman commented on TIKA-875:
------------------------------------
Stacktrace showing the acquisition trace during parsing of a ZIP-archive containing lots of images:
java.io.RandomAccessFile.open(String, int)
java.io.RandomAccessFile.<init>(File, String)
javax.imageio.stream.FileCacheImageInputStream.<init>(InputStream, File)
com.sun.imageio.spi.InputStreamImageInputStreamSpi.createInputStreamInstance(Object, boolean, File)
javax.imageio.ImageIO.createImageInputStream(Object)
org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.CompositeParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.CompositeParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.AutoDetectParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.DelegatingParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.extractor.ParsingEmbeddedDocumentExtractor.parseEmbedded(InputStream, ContentHandler, Metadata, boolean)
org.apache.tika.parser.pkg.PackageExtractor.unpack(ArchiveInputStream, XHTMLContentHandler)
org.apache.tika.parser.pkg.PackageExtractor.parse(InputStream)
org.apache.tika.parser.pkg.PackageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.CompositeParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.CompositeParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.AutoDetectParser.parse(InputStream, ContentHandler, Metadata, ParseContext)
org.apache.tika.parser.ParsingReader$ParsingTask.run()
java.lang.Thread.run()
> Temporary file leak in ImageParser
> ----------------------------------
>
> Key: TIKA-875
> URL: https://issues.apache.org/jira/browse/TIKA-875
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.0
> Reporter: Niels Beekman
>
> The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TIKA-875) Temporary file leak in ImageParser
Posted by "Michael McCandless (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved TIKA-875.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.2
> Temporary file leak in ImageParser
> ----------------------------------
>
> Key: TIKA-875
> URL: https://issues.apache.org/jira/browse/TIKA-875
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.0
> Reporter: Niels Beekman
> Assignee: Michael McCandless
> Fix For: 1.2
>
> Attachments: patch.svn.diff
>
>
> The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TIKA-875) Temporary file leak in ImageParser
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228393#comment-13228393 ]
Michael McCandless commented on TIKA-875:
-----------------------------------------
Thanks Niels, patch looks good! I'll commit shortly...
> Temporary file leak in ImageParser
> ----------------------------------
>
> Key: TIKA-875
> URL: https://issues.apache.org/jira/browse/TIKA-875
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.0
> Reporter: Niels Beekman
> Assignee: Michael McCandless
> Attachments: patch.svn.diff
>
>
> The stream obtained through ImageIO.createImageInputStream is not closed (org.apache.tika.parser.image.ImageParser.parse(InputStream, ContentHandler, Metadata, ParseContext)). When performing a lot of parse operations, the process can easily run out of file descriptors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira