You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/25 06:28:47 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #12530:
Implement mkldnn convolution fusion and quantization.
eric-haibin-lin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220068345
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -408,12 +420,23 @@ def _load_params(params, logger=logging):
raise ValueError('Unsupported params provided. Must be either a path to the param file or'
' a pair of dictionaries representing arg_params and aux_params')
+def save_params(fname, arg_params, aux_params, logger=None):
Review comment:
This is considered as a public API under the contrib.quantization namespace. What is the necessity of adding such an API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services