You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/03/27 14:36:45 UTC
[GitHub] [inlong] featzhang opened a new pull request, #7710: [INLONG-7701][Manager] Support test connection for hudi in NodeManagement
featzhang opened a new pull request, #7710:
URL: https://github.com/apache/inlong/pull/7710
### Prepare a Pull Request
*[INLONG-7701][Manager] Support test connection for hudi in NodeManagement*
- Fixes #7701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7710: [INLONG-7701][Manager] Support test connection for hudi in NodeManagement
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7710:
URL: https://github.com/apache/inlong/pull/7710#discussion_r1150027034
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/hudi/HudiDataNodeOperator.java:
##########
@@ -81,4 +83,30 @@ protected void setTargetEntity(DataNodeRequest request, DataNodeEntity targetEnt
}
}
+ @Override
+ public Boolean testConnection(DataNodeRequest request) {
+ HudiDataNodeRequest hudiRequest = (HudiDataNodeRequest) request;
+ String metastoreUri = hudiRequest.getUrl();
+ String warehouse = hudiRequest.getWarehouse();
+ Preconditions.expectNotBlank(metastoreUri, ErrorCodeEnum.INVALID_PARAMETER, "connection url cannot be empty");
+ HudiCatalogClient client = null;
+ try {
Review Comment:
Please use try-resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7710: [INLONG-7701][Manager] Support test connection for hudi in NodeManagement
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7710:
URL: https://github.com/apache/inlong/pull/7710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org