You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/06/25 21:05:34 UTC

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

GitHub user knusbaum opened a pull request:

    https://github.com/apache/storm/pull/604

    STORM-912: Support SSL on Logviewer

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knusbaum/incubator-storm STORM-912

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #604
    
----
commit 0bc4565166e3d7ed3c219486dfbf51e0851cf105
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2015-06-24T20:11:46Z

    Adding SSL for Logviewer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/604#issuecomment-115384099
  
    +1 looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

Posted by knusbaum <gi...@git.apache.org>.

Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/604#issuecomment-116782822
  
    Fixed the boolean condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/604#discussion_r33358774
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -293,10 +293,17 @@
                   (bolt-comp-summs id))]
         (sort-by #(-> ^ExecutorSummary % .get_executor_info .get_task_start) ret)))
     
    -(defn worker-log-link [host port topology-id]
    +(defn worker-log-link [host port topology-id secure?]
       (let [fname (logs-filename topology-id port)]
    -    (url-format (str "http://%s:%s/log?file=%s")
    -          host (*STORM-CONF* LOGVIEWER-PORT) fname)))
    +    (if secure?
    --- End diff --
    
    Actually I just had a thought.  We probably want this to be 
    ```
    (if (and secure? (*STORM-CONF* LOGVIEWER-PORT))
    ...)
    ```
    
    That way someone is not required to secure their logviewers if they secure the main UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/604


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-912: Support SSL on Logviewer

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/604#issuecomment-117172325
  
    looks good to me I am +1 for merging this in, and CI actually passed this time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---