You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:15:39 UTC

[GitHub] [cordova-plugin-device] timbru31 commented on a change in pull request #115: #113 (browser) - Properly detect new Edge Chromium version as Edge instead of Chrome

timbru31 commented on a change in pull request #115: #113 (browser) - Properly detect new Edge Chromium version as Edge instead of Chrome
URL: https://github.com/apache/cordova-plugin-device/pull/115#discussion_r398604584
 
 

 ##########
 File path: src/browser/DeviceProxy.js
 ##########
 @@ -37,8 +37,16 @@ function getBrowserInfo (getModel) {
     var returnVal = '';
     var offset;
 
-    if ((offset = userAgent.indexOf('Edge')) !== -1) {
-        returnVal = (getModel) ? 'Edge' : userAgent.substring(offset + 5);
+    if ((offset = userAgent.indexOf('Edg')) !== -1) {
+        if (getModel) {
+            returnVal = 'Edge';
+        } else {
+            if ((offset = userAgent.indexOf('Edge')) !== -1) {
 
 Review comment:
   This won't work, as the offset might be set to `-1` again and line 47 would return `userAgent.substring(-1 + 4);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org