You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "mhenc (via GitHub)" <gi...@apache.org> on 2023/03/06 13:30:18 UTC

[GitHub] [airflow] mhenc commented on pull request #29776: Add Pydantic-powered ORM models serialization for internal API.

mhenc commented on PR #29776:
URL: https://github.com/apache/airflow/pull/29776#issuecomment-1456141063

   Thank you! This looks really cool.
   
   Just to confirm I understand it correctly:
   After this PR is merged, we need to change methods using TaskInstance parameter to use `TaskInstance|TaskInstancePydantic`,
   e.g. in run_raw_task
   https://github.com/apache/airflow/blob/f1b565f1175121451a5bdfaaa19831f0ed8b4d54/airflow/cli/commands/task_command.py#L277
   I think the `ti._run_raw_task` need also be updated (to static method?) to work with both  TaskInstance and TaskInstancePydantic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org