You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2017/05/03 06:59:58 UTC
Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view
pop-up does not come up.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58947/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-1555
https://issues.apache.org/jira/browse/RANGER-1555
Repository: ranger
Description
-------
In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's
1. Service delete operation (delete any service and check diff view log for the same).
2. Hive policy update operation for access policy.
Steps to reproduce:
a.Create hive policy by selecting resource as a table.
b.Then, update the policy by changing resource table to UDF.
c.Check diff view log in Audit Menu-> admin tab
And also fixed following cases:
- Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
- Diff view popup doesn’t show row level filter policy items: when policy is deleted(the same case happening for masking policy item).
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 01062de
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ede73bf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 64baf76
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91
security-admin/src/main/webapp/styles/xa.css 6cda421
security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 31cd974
security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134
security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 07758dd
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 0325c42
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html c2d6c2d
security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04
security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0
security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921
Diff: https://reviews.apache.org/r/58947/diff/1/
Testing
-------
Testing Done:
1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking, Row level filter), User/Group.
2. Verified diff view popup for existing policies (for eg. Customers existing policies) for CRUD operation logs.
Thanks,
Nitin Galave
Re: Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view
pop-up does not come up.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58947/#review177892
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On June 9, 2017, 2:59 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58947/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 2:59 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1555
> https://issues.apache.org/jira/browse/RANGER-1555
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's
> 1. Service delete operation (delete any service and check diff view log for the same).
> 2. Hive policy update operation for access policy.
> Steps to reproduce:
> a.Create hive policy by selecting resource as a table.
> b.Then, update the policy by changing resource table to UDF.
> c.Check diff view log in Audit Menu-> admin tab
> And also fixed following cases:
> - Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
> - Diff view popup doesn’t show row level filter policy items: when policy is deleted(the same case happening for masking policy item).
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 01062de
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ede73bf
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ff62bb2
> security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91
> security-admin/src/main/webapp/styles/xa.css c70c0bc
> security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 31cd974
> security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134
> security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 07758dd
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 0325c42
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html c2d6c2d
> security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04
> security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0
> security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921
>
>
> Diff: https://reviews.apache.org/r/58947/diff/3/
>
>
> Testing
> -------
>
> Testing Done:
>
> 1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking, Row level filter), User/Group.
> 2. Verified diff view popup for existing policies (for eg. Customers existing policies) for CRUD operation logs.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view
pop-up does not come up.
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58947/#review177887
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On June 9, 2017, 2:59 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58947/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 2:59 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1555
> https://issues.apache.org/jira/browse/RANGER-1555
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's
> 1. Service delete operation (delete any service and check diff view log for the same).
> 2. Hive policy update operation for access policy.
> Steps to reproduce:
> a.Create hive policy by selecting resource as a table.
> b.Then, update the policy by changing resource table to UDF.
> c.Check diff view log in Audit Menu-> admin tab
> And also fixed following cases:
> - Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
> - Diff view popup doesn’t show row level filter policy items: when policy is deleted(the same case happening for masking policy item).
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 01062de
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ede73bf
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ff62bb2
> security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91
> security-admin/src/main/webapp/styles/xa.css c70c0bc
> security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 31cd974
> security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134
> security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 07758dd
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 0325c42
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html c2d6c2d
> security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04
> security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0
> security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921
>
>
> Diff: https://reviews.apache.org/r/58947/diff/3/
>
>
> Testing
> -------
>
> Testing Done:
>
> 1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking, Row level filter), User/Group.
> 2. Verified diff view popup for existing policies (for eg. Customers existing policies) for CRUD operation logs.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view
pop-up does not come up.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58947/
-----------------------------------------------------------
(Updated June 9, 2017, 2:59 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Changes
-------
patch recreated.
Bugs: RANGER-1555
https://issues.apache.org/jira/browse/RANGER-1555
Repository: ranger
Description
-------
In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's
1. Service delete operation (delete any service and check diff view log for the same).
2. Hive policy update operation for access policy.
Steps to reproduce:
a.Create hive policy by selecting resource as a table.
b.Then, update the policy by changing resource table to UDF.
c.Check diff view log in Audit Menu-> admin tab
And also fixed following cases:
- Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
- Diff view popup doesn’t show row level filter policy items: when policy is deleted(the same case happening for masking policy item).
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 01062de
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ede73bf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ff62bb2
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91
security-admin/src/main/webapp/styles/xa.css c70c0bc
security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 31cd974
security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134
security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 07758dd
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 0325c42
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html c2d6c2d
security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04
security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0
security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921
Diff: https://reviews.apache.org/r/58947/diff/3/
Changes: https://reviews.apache.org/r/58947/diff/2-3/
Testing
-------
Testing Done:
1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking, Row level filter), User/Group.
2. Verified diff view popup for existing policies (for eg. Customers existing policies) for CRUD operation logs.
Thanks,
Nitin Galave
Re: Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view
pop-up does not come up.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58947/
-----------------------------------------------------------
(Updated May 3, 2017, 1:07 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Changes
-------
done clean up.
Bugs: RANGER-1555
https://issues.apache.org/jira/browse/RANGER-1555
Repository: ranger
Description
-------
In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's
1. Service delete operation (delete any service and check diff view log for the same).
2. Hive policy update operation for access policy.
Steps to reproduce:
a.Create hive policy by selecting resource as a table.
b.Then, update the policy by changing resource table to UDF.
c.Check diff view log in Audit Menu-> admin tab
And also fixed following cases:
- Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
- Diff view popup doesn’t show row level filter policy items: when policy is deleted(the same case happening for masking policy item).
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 01062de
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ede73bf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 64baf76
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91
security-admin/src/main/webapp/styles/xa.css 6cda421
security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 31cd974
security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134
security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 07758dd
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 0325c42
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html c2d6c2d
security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04
security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0
security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921
Diff: https://reviews.apache.org/r/58947/diff/2/
Changes: https://reviews.apache.org/r/58947/diff/1-2/
Testing
-------
Testing Done:
1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking, Row level filter), User/Group.
2. Verified diff view popup for existing policies (for eg. Customers existing policies) for CRUD operation logs.
Thanks,
Nitin Galave