[GitHub] QiuMM commented on a change in pull request #6473: QueryCountStatsMonitor: emit query/count

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6473: QueryCountStatsMonitor: emit query/count
URL: https://github.com/apache/incubator-druid/pull/6473#discussion_r225769639
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/metrics/QueryCountStatsMonitor.java
 ##########
 @@ -44,11 +44,16 @@ public QueryCountStatsMonitor(
   public boolean doMonitor(ServiceEmitter emitter)
   {
     final ServiceMetricEvent.Builder builder = new ServiceMetricEvent.Builder();
+    final long successfulQueryCount = statsProvider.getSuccessfulQueryCount();
+    final long failedQueryCount = statsProvider.getFailedQueryCount();
+    final long interruptedQueryCount = statsProvider.getInterruptedQueryCount();
     Map<String, Long> diff = keyedDiff.to(
         "queryCountStats",
-        ImmutableMap.of("query/success/count", statsProvider.getSuccessfulQueryCount(),
-                        "query/failed/count", statsProvider.getFailedQueryCount(),
-                        "query/interrupted/count", statsProvider.getInterruptedQueryCount()
+        ImmutableMap.of("query/count", successfulQueryCount + failedQueryCount + interruptedQueryCount,
 
 Review comment:
   Oops, changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org