You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 07:21:52 UTC

[GitHub] [flink] GJL opened a new pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

GJL opened a new pull request #12210:
URL: https://github.com/apache/flink/pull/12210


   ## What is the purpose of the change
   
   *This catches and logs exceptions thrown when invoking jstack. jstack can fail if the JVM process that we want to sample exits while or before we invoke jstack. Since this is not unexpected behavior, we should not propagate the exception and fail the test prematurely.*
   
   
   ## Brief change log
   
     - *See commit*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *flink-jepsen*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-629996745

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 079380181830d2fdfa7399c8014bb86e7776d004 (Mon May 18 07:26:21 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-629996745

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80 (Fri Oct 16 10:48:31 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-630018809


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1695",
       "triggerID" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1695) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GJL commented on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

GJL commented on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-630208779


   Merged manually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-630018809


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GJL closed pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

GJL closed pull request #12210:
URL: https://github.com/apache/flink/pull/12210


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12210: [FLINK-17792][tests] Catch and log exception if jstack fails

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12210:
URL: https://github.com/apache/flink/pull/12210#issuecomment-630018809


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1695",
       "triggerID" : "35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a0b961d4d1a1dbb7485ff847c7b5e2a5068c80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1695) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org