You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2013/04/03 23:53:16 UTC
[jira] [Commented] (MAPREDUCE-4330)
TaskAttemptCompletedEventTransition invalidates previously successful
attempt without checking if the newly completed attempt is successful
[ https://issues.apache.org/jira/browse/MAPREDUCE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621382#comment-13621382 ]
Siddharth Seth commented on MAPREDUCE-4330:
-------------------------------------------
I think it's best to keep track of a single completion event. Re-launch the task if this one happens to fail. That remains closer to the current logic where only a single completion event is remembered per task - and is likely less complicated.
> TaskAttemptCompletedEventTransition invalidates previously successful attempt without checking if the newly completed attempt is successful
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4330
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4330
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.1
> Reporter: Bikas Saha
> Assignee: Omkar Vinit Joshi
> Attachments: MAPREDUCE-4330-21032013.1.patch, MAPREDUCE-4330-21032013.patch
>
>
> The previously completed attempt is removed from successAttemptCompletionEventNoMap and marked OBSOLETE.
> After that, if the newly completed attempt is successful then it is added to the successAttemptCompletionEventNoMap.
> This seems wrong because the newly completed attempt could be failed and thus there is no need to invalidate the successful attempt.
> One error case would be when a speculative attempt completes with killed/failed after the successful version has completed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira