You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Tiago R. Espinha (JIRA)" <ji...@apache.org> on 2008/04/15 23:04:24 UTC
[jira] Created: (DERBY-3623) Convert deadlockMode.java to JUnit
Convert deadlockMode.java to JUnit
----------------------------------
Key: DERBY-3623
URL: https://issues.apache.org/jira/browse/DERBY-3623
Project: Derby
Issue Type: Task
Components: Test
Reporter: Tiago R. Espinha
Priority: Minor
Fix For: 10.5.0.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha reassigned DERBY-3623:
---------------------------------------
Assignee: Tiago R. Espinha
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592477#action_12592477 ]
Tiago R. Espinha commented on DERBY-3623:
-----------------------------------------
My bad, forgot to explain that.
encryptedBaseSuite applies an ecryptedDatabase Decorator to the suite before inserting it into a CleanDatabaseTestSetup, whereas baseSuite does the exact same thing just without the encryption.
The only difference is a call to Decorator.encryptedDatabase(suite) present on encryptedBaseSuite, while on the baseSuite the "suite" object is used directly, without being wrapped in the decorator.
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623-20080425.patch, derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-3623) Convert deadlockMode.java
to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591082#action_12591082 ]
kmarsden edited comment on DERBY-3623 at 4/21/08 3:57 PM:
----------------------------------------------------------------
Need to remove master/deadlockMode.out.
-Table setup should be in decorateSQL method instead of setup. Then cleanup of the table will be automatic. See BatchUpdateTest for an example.
-There is no need to check success of each insert. It will just throw an exception if there is a problem.
When I run the test it passes but I see these exceptions in the console: I think the code:
} catch (Exception e) {
checkThreadsDone();
assertNull(
"FAIL - Exception thrown",
e);
}
is not quite right. We normally want to throw the exception but since this is a multithreaded test I see that won't quite work. Anyway I am investigating.
testThreadsUpdatingTable Exception in thread "Thread-26" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
...
was (Author: kmarsden):
Need to remove master/deadlockMode.out.
-Table setup should be in decorateSQL method instead of setup. Then cleanup of the table will be automatic. See BatchUpdateTest for an example.
-There is no need to check success of each insert. It will just throw an exception if there is a problem.
When I run the test it passes but I see these exceptions in the console: I think the code:
} catch (Exception e) {
checkThreadsDone();
assertNull(
"FAIL - Exception thrown",
e);
}
is not quite right. We normally want to throw the exception but since this is a multithreaded test I see that won't quite work. Anyway I am investigating.
testThreadsUpdatingTable Exception in thread "Thread-26" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-37" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-44" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-33" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-31" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-43" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-40" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-29" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-32" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-38" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-30" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-28" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-34" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.fail(Assert.java:47)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-36" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-42" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-41" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
Exception in thread "Thread-35" at java.lang.Thread.run(Thread.java:803)
junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-25" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-39" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-27" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
used 110 ms
Time: 8
OK (2 tests)
+ set +x
[C:/test]
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592476#action_12592476 ]
Kathey Marsden commented on DERBY-3623:
---------------------------------------
What's the difference between baseSuite and encryptedBaseSuite? Why are both needed?
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623-20080425.patch, derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592467#action_12592467 ]
Tiago R. Espinha commented on DERBY-3623:
-----------------------------------------
Added a new patch file. This one already removes master/deadlockMode.out and fixes all the aforementioned issues.
The table creation and filling is now done on decorateSQL as suggested by Kathey, and since threads' asserts won't affect the main test flow, added a LinkedList that cumulates all the exceptions thrown by threads. This list is then checked by the main thread (upon all the other threads having finished) and if there are exceptions, the test fails().
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623-20080425.patch, derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590456#action_12590456 ]
Tiago R. Espinha commented on DERBY-3623:
-----------------------------------------
Added a replacement test using JUnit. The file should be added and deadlockMode.java deleted. Changed the name for coherence with the rest of the tests. It's my first conversion and I tried to a maximum to stick with the Java code conventions. Any tips are appreciated.
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: DeadlockModeTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha updated DERBY-3623:
------------------------------------
Attachment: DeadlockModeTest.java
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: DeadlockModeTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha updated DERBY-3623:
------------------------------------
Attachment: derby3623-20080425.patch
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623-20080425.patch, derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591082#action_12591082 ]
Kathey Marsden commented on DERBY-3623:
---------------------------------------
Need to remove master/deadlockMode.out.
-Table setup should be in decorateSQL method instead of setup. Then cleanup of the table will be automatic. See BatchUpdateTest for an example.
-There is no need to check success of each insert. It will just throw an exception if there is a problem.
When I run the test it passes but I see these exceptions in the console: I think the code:
} catch (Exception e) {
checkThreadsDone();
assertNull(
"FAIL - Exception thrown",
e);
}
is not quite right. We normally want to throw the exception but since this is a multithreaded test I see that won't quite work. Anyway I am investigating.
testThreadsUpdatingTable Exception in thread "Thread-26" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-37" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-44" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-33" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-31" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-43" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-40" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-29" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-32" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-38" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-30" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-28" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-34" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.fail(Assert.java:47)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-36" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-42" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-41" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
Exception in thread "Thread-35" at java.lang.Thread.run(Thread.java:803)
junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-25" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-39" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-27" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
used 110 ms
Time: 8
OK (2 tests)
+ set +x
[C:/test]
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591030#action_12591030 ]
Tiago R. Espinha commented on DERBY-3623:
-----------------------------------------
Added a patch for the following:
- Remove the old harness test and its files
- Add the new test
derbyall passed, suites.All passed with just one failure that I believe to not be related with my changes. It had something to do with collation and I believe someone else was just tampering with it.
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha updated DERBY-3623:
------------------------------------
Attachment: derby3623.patch
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3623:
----------------------------------
Attachment: ThreadTest.java
I made this quick test to see what happens with asserts in spawned threads and the result is that they do not cause the test to fail. I think we will need some mechanism to accumulate the exceptions to be reported in the event of failure.
Kathey
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591089#action_12591089 ]
Kathey Marsden commented on DERBY-3623:
---------------------------------------
The core exception seems to be:
java.sql.SQLSyntaxErrorException: Table/View 'T' does not exist.
at org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(SQLExceptionFactory40.java:91)
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Util.java:201)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(TransactionResourceImpl.java:391)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(TransactionResourceImpl.java:346)
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(EmbedConnection.java:2125)
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(ConnectionChild.java:81)
at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:614)
at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(EmbedStatement.java:175)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:184)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:619)
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha updated DERBY-3623:
------------------------------------
Attachment: (was: DeadlockModeTest.java)
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3623) Convert deadlockMode.java to JUnit
Posted by "Tiago R. Espinha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tiago R. Espinha closed DERBY-3623.
-----------------------------------
Resolution: Fixed
Derby Info: [Patch Available]
Fixed on revision 651703.
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623-20080425.patch, derby3623.patch, ThreadTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.