You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/02/03 11:53:50 UTC
[isis] branch master updated: ISIS-2518: fixing Javadoc validation
issues as indicated by the IDE (2)
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 6797ee5 ISIS-2518: fixing Javadoc validation issues as indicated by the IDE (2)
6797ee5 is described below
commit 6797ee5a10f8bbbdd8adca1940bd9932e9f7adce
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Feb 3 12:53:32 2021 +0100
ISIS-2518: fixing Javadoc validation issues as indicated by the IDE (2)
---
.../apache/isis/applib/annotation/Defaulted.java | 7 ++----
.../isis/applib/annotation/DomainObject.java | 9 +++-----
.../isis/applib/annotation/NatureOfService.java | 4 ++--
.../apache/isis/applib/annotation/Property.java | 4 ++--
.../apache/isis/applib/annotation/Publishing.java | 3 +--
.../applib/events/domain/ActionDomainEvent.java | 23 ++++++++++---------
.../events/domain/CollectionDomainEvent.java | 24 +++++++++++---------
.../isis/applib/services/bookmark/Bookmark.java | 2 +-
.../isis/applib/services/iactn/Interaction.java | 3 ++-
.../jaxb/CatalogingSchemaOutputResolver.java | 6 +++--
.../publishing/spi/ExecutionSubscriber.java | 13 ++++++-----
.../applib/services/scratchpad/Scratchpad.java | 7 +++---
.../applib/services/swagger/SwaggerService.java | 4 +++-
.../isis/applib/services/swagger/package-info.java | 26 ----------------------
.../isis/applib/services/user/UserService.java | 1 +
.../applib/services/wrapper/WrappingObject.java | 5 ++---
.../wrapper/listeners/InteractionListener.java | 2 +-
.../snapshot/SnapshottableWithInclusions.java | 3 ++-
.../org/apache/isis/applib/util/TitleBuffer.java | 26 ++++++++++++----------
.../org/apache/isis/applib/util/ZipWriter.java | 1 -
.../applib/util/schema/InteractionDtoUtils.java | 11 +++++----
.../isis/commons/binding/InvalidationListener.java | 2 +-
.../apache/isis/commons/internal/base/_Files.java | 2 +-
.../isis/commons/internal/base/_Objects.java | 6 ++---
.../isis/commons/internal/base/_Reduction.java | 11 +++++----
.../apache/isis/commons/internal/base/_Refs.java | 16 ++++++-------
.../apache/isis/commons/internal/base/_Text.java | 6 +++--
.../apache/isis/commons/internal/base/_Timing.java | 2 +-
.../commons/internal/codec/_DocumentFactories.java | 2 +-
.../isis/commons/internal/collections/_Arrays.java | 23 ++++++++++---------
.../commons/internal/collections/_Collections.java | 9 ++++----
.../isis/commons/internal/context/_Plugin.java | 7 ++++--
.../isis/commons/internal/ioc/_IocContainer.java | 2 +-
.../isis/commons/internal/resources/_Json.java | 8 +++----
.../apache/isis/core/config/IsisConfiguration.java | 12 +++++-----
.../isis/core/metamodel/adapter/oid/Oid.java | 7 +++---
.../metamodel/execution/InternalInteraction.java | 10 +++++----
.../execution/ExecutionPublishingFacet.java | 3 +--
.../BookmarkPolicyFacetAbstract.java | 8 +++----
.../choices/ChoicesFacetFromBoundedAbstract.java | 8 ++++---
.../object/immutable/EditingEnabledFacet.java | 3 +--
.../RecreatableObjectFacetAbstract.java | 6 +++--
.../facets/value/temporal/TemporalAdjust.java | 2 +-
.../isis/core/metamodel/layout/DeweyOrderSet.java | 2 +-
.../memberorderfacet/MemberOrderComparator.java | 4 ++--
.../OrderSetGroupNameComparator.java | 6 ++---
.../core/metamodel/spec/ObjectSpecification.java | 10 ++++-----
.../core/metamodel/spec/feature/ObjectAction.java | 16 ++++++-------
.../spec/feature/ObjectActionContainer.java | 3 ++-
.../core/metamodel/spec/feature/ObjectMember.java | 2 +-
.../events/TransactionAfterCompletionEvent.java | 2 +-
.../core/webapp/modules/WebModuleAbstract.java | 2 --
.../extensions/commandlog/impl/jdo/CommandJdo.java | 2 +-
.../jobcallables/ReplicateAndRunCommands.java | 2 +-
.../extensions/secman/api/tenancy/HasAtPath.java | 18 ++++++++-------
.../secman/shiro/PrincipalForApplicationUser.java | 3 ++-
.../incubator/viewer/javafx/model/util/_fx.java | 1 -
.../viewer/vaadin/ui/binding/BindingsVaa.java | 1 -
.../isis/legacy/applib/DomainObjectContainer.java | 2 +-
.../services/eventbus/ActionDomainEvent.java | 9 +++++---
.../services/eventbus/CollectionDomainEvent.java | 12 +++++-----
.../jdo/datanucleus/IsisModuleJdoDatanucleus.java | 4 ++--
.../facets/object/query/JdoNamedQuery.java | 2 +-
.../base/applib/valuetypes/AbstractInterval.java | 1 -
.../subdomains/excel/applib/dom/WorksheetSpec.java | 2 +-
.../subdomains/excel/testing/ExcelFixture.java | 5 +++--
.../subdomains/excel/testing/ExcelFixture2.java | 5 +++--
.../api/FixtureScriptWithExecutionStrategy.java | 3 ++-
.../fixturescripts/BuilderScriptWithoutResult.java | 2 --
.../wkt/components/AsciiDocForXmlComponentWkt.java | 3 ---
.../sse/applib/annotations/SseSource.java | 2 +-
.../valuetypes/sse/applib/service/SseChannel.java | 2 +-
.../valuetypes/sse/applib/service/SseService.java | 2 +-
.../sse/ui/wkt/services/SseServiceDefault.java | 2 +-
.../ui/wkt/webmodule/ServerSentEventsServlet.java | 2 +-
.../model/action/decorator/ActionUiDecorator.java | 4 +---
.../restfulobjects/applib/RestfulMediaType.java | 2 +-
.../webmodule/auth/AuthenticationStrategy.java | 2 +-
.../wicket/model/isis/WicketViewerSettings.java | 23 +++++++++----------
.../viewer/wicket/model/models/ActionModel.java | 2 +-
.../components/actions/ActionParametersPanel.java | 17 +++++---------
.../ui/components/scalars/ScalarPanelAbstract.java | 1 -
.../scalars/ScalarPanelTextFieldAbstract.java | 11 +++++----
.../components/scalars/primitive/BooleanPanel.java | 2 +-
.../formcomponent/FormComponentPanelAbstract.java | 2 --
.../ui/components/widgets/navbar/BrandLogo.java | 4 ++--
.../viewer/wicket/ui/panels/PanelAbstract.java | 2 --
.../isis/viewer/wicket/ui/util/SSESupport.java | 3 ++-
.../AuthenticatedWebSessionForIsis.java | 5 +++--
89 files changed, 270 insertions(+), 283 deletions(-)
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/Defaulted.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/Defaulted.java
index bc9ea97..43bd8c5 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/Defaulted.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/Defaulted.java
@@ -40,12 +40,9 @@ import org.apache.isis.applib.adapters.DefaultsProvider;
* of {@link DefaultsProvider} could adjust the default it provides according to
* circumstance, for example).
*
- * <p>
- * Note: This annotation is only incompletely recognized by the framework, and may be deprecated in the future.
- * </p>
+ * @apiNote This annotation is only incompletely recognized by the framework,
+ * and may be deprecated in the future.
*
- * @see <code>Encodable</code>
- * @see <code>Parseable</code>
* @see Value
* @since 1.x {@index}
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/DomainObject.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/DomainObject.java
index a78a54a..efc2ab8 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/DomainObject.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/DomainObject.java
@@ -39,7 +39,8 @@ import org.apache.isis.applib.events.lifecycle.ObjectUpdatedEvent;
import org.apache.isis.applib.events.lifecycle.ObjectUpdatingEvent;
/**
- * Domain semantics for domain objects (entities and view models; for services see {@link org.apache.isis.applib.annotation.DomainService}).
+ * Domain semantics for domain objects (entities and view models;
+ * for services see {@link org.apache.isis.applib.annotation.DomainService}).
*
* @apiNote Meta annotation {@link Component} allows for the Spring framework to pick up (discover) the
* annotated type.
@@ -120,11 +121,7 @@ public @interface DomainObject {
default Publishing.NOT_SPECIFIED;
/**
- * Equivalent to {@link Mixin#method()}.
- *
- * <p>
- * Applicable only if {@link #nature()} is {@link Nature#MIXIN}.
- * </p>
+ * Applicable only if {@link #nature()} is {@link Nature#MIXIN}.
*/
String mixinMethod()
default "$$";
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/NatureOfService.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/NatureOfService.java
index f4e0550..3c98b0d 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/NatureOfService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/NatureOfService.java
@@ -42,7 +42,7 @@ public enum NatureOfService {
/**
* Whether a service contributes its actions to viewers and to the REST API.
- * @see {@link NatureOfService#VIEW}
+ * @see NatureOfService#VIEW
*/
public boolean isView() {
return this == VIEW;
@@ -50,7 +50,7 @@ public enum NatureOfService {
/**
* Whether a service contributes its actions exclusively to the REST API.
- * @see {@link NatureOfService#REST}
+ * @see NatureOfService#REST
*/
public boolean isRestOnly() {
return this == REST;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/Property.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/Property.java
index 526a68d..fcc5dec 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/Property.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/Property.java
@@ -30,7 +30,6 @@ import org.apache.isis.applib.services.command.Command;
import org.apache.isis.applib.services.commanddto.conmap.ContentMappingServiceForCommandDto;
import org.apache.isis.applib.services.commanddto.conmap.ContentMappingServiceForCommandsDto;
import org.apache.isis.applib.services.commanddto.processor.CommandDtoProcessor;
-import org.apache.isis.applib.services.iactn.Interaction;
import org.apache.isis.applib.services.publishing.spi.CommandSubscriber;
import org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber;
import org.apache.isis.applib.spec.Specification;
@@ -110,7 +109,8 @@ public @interface Property {
default "";
/**
- * Whether {@link Interaction.Execution}s
+ * Whether
+ * {@link org.apache.isis.applib.services.iactn.Interaction.Execution}s
* (triggered property edits), should be dispatched to
* {@link ExecutionSubscriber}s.
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/Publishing.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/Publishing.java
index e329608..e2e5fb6 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/Publishing.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/Publishing.java
@@ -19,7 +19,6 @@
package org.apache.isis.applib.annotation;
import org.apache.isis.applib.services.command.Command;
-import org.apache.isis.applib.services.iactn.Interaction;
import org.apache.isis.applib.services.publishing.spi.CommandSubscriber;
import org.apache.isis.applib.services.publishing.spi.EntityChanges;
import org.apache.isis.applib.services.publishing.spi.EntityChangesSubscriber;
@@ -35,7 +34,7 @@ import org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber;
* <li><b>{@link EntityChanges} ... subscribed to via {@link EntityChangesSubscriber}</li>
* <li><b>{@link EntityPropertyChange} ... subscribed to via {@link EntityPropertyChangeSubscriber}</li>
* <li><b>{@link Command} ... subscribed to via {@link CommandSubscriber}</li>
- * <li><b>{@link Interaction.Execution} ... subscribed to via {@link ExecutionSubscriber}</li>
+ * <li><b>{@link org.apache.isis.applib.services.iactn.Interaction.Execution} ... subscribed to via {@link ExecutionSubscriber}</li>
* </ul>
* @since 1.x {@index}
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/events/domain/ActionDomainEvent.java b/api/applib/src/main/java/org/apache/isis/applib/events/domain/ActionDomainEvent.java
index c5cbd38..a327141 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/events/domain/ActionDomainEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/events/domain/ActionDomainEvent.java
@@ -35,14 +35,15 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
/**
* This class is the default for the
* {@link org.apache.isis.applib.annotation.Action#domainEvent()} annotation attribute. Whether this
- * raises an event or not depends upon the <tt>isis.core.meta-model.annotation.action.domain-event.post-for-default</tt>
+ * raises an event or not depends upon the
+ * <tt>isis.core.meta-model.annotation.action.domain-event.post-for-default</tt>
* configuration property.
*/
public static class Default extends ActionDomainEvent<Object> {}
/**
- * Convenience class to use indicating that an event should <i>not</i> be posted (irrespective of the configuration
- * property setting for the {@link Default} event.
+ * Convenience class to use indicating that an event should <i>not</i> be posted
+ * (irrespective of the configuration property setting for the {@link Default} event.
*/
public static class Noop extends ActionDomainEvent<Object> {}
@@ -78,12 +79,14 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
private Object mixedIn;
/**
- * The arguments being used to invoke the action; populated at {@link Phase#VALIDATE} and subsequent phases
- * (but null for {@link Phase#HIDE hidden} and {@link Phase#DISABLE disable} phases).
+ * The arguments being used to invoke the action;
+ * populated at {@link AbstractDomainEvent.Phase#VALIDATE} and subsequent phases
+ * (but null for {@link AbstractDomainEvent.Phase#HIDE hidden} and
+ * {@link AbstractDomainEvent.Phase#DISABLE disable} phases).
*
* <p>
- * The argument values can also be modified by event handlders
- * during the {@link Phase#EXECUTING} phase. The new value must be
+ * The argument values can also be modified by event handlers
+ * during the {@link AbstractDomainEvent.Phase#EXECUTING} phase. The new value must be
* the same type as the expected value; the framework performs
* no sanity checks.
* </p>
@@ -95,8 +98,8 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
* The value returned by the action.
*
* <p>
- * Only available for the {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#EXECUTED}
- * {@link #getEventPhase() phase}.
+ * Only available for the {@link AbstractDomainEvent.Phase#EXECUTED}
+ * {@link #getEventPhase() phase}.
* </p>
*/
@Getter
@@ -106,7 +109,7 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
* Set by the framework.
*
* Event subscribers can replace the value with some other value if they wish, though only in the
- * {@link Phase#EXECUTED} phase.
+ * {@link AbstractDomainEvent.Phase#EXECUTED} phase.
*/
public void setReturnValue(final Object returnValue) {
this.returnValue = returnValue;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/events/domain/CollectionDomainEvent.java b/api/applib/src/main/java/org/apache/isis/applib/events/domain/CollectionDomainEvent.java
index c5a75d8..8b843e6 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/events/domain/CollectionDomainEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/events/domain/CollectionDomainEvent.java
@@ -62,8 +62,11 @@ public abstract class CollectionDomainEvent<S,T> extends AbstractDomainEvent<S>
/**
- * The proposed reference to either add or remove (per {@link #getOf()}), populated at {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE}
- * and subsequent phases (is null for {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#HIDE hidden} and {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#DISABLE disable} phases).
+ * The proposed reference to either add or remove (per {@link #getOf()}), populated at
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE}
+ * and subsequent phases (is null for
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#HIDE hidden}
+ * and {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#DISABLE disable} phases).
*/
@Getter
private T value;
@@ -71,22 +74,22 @@ public abstract class CollectionDomainEvent<S,T> extends AbstractDomainEvent<S>
public static enum Of {
/**
* The collection is being accessed
- * ({@link Phase#HIDE hide} and
- * {@link Phase#DISABLE disable}) checks.
+ * ({@link AbstractDomainEvent.Phase#HIDE hide} and
+ * {@link AbstractDomainEvent.Phase#DISABLE disable}) checks.
*/
ACCESS,
/**
* The collection is being added to
- * ({@link Phase#VALIDATE validity} check and
- * {@link Phase#EXECUTED execution}).
+ * ({@link AbstractDomainEvent.Phase#VALIDATE validity} check and
+ * {@link AbstractDomainEvent.Phase#EXECUTED execution}).
*/
ADD_TO,
/**
* The collection is being removed from
- * ({@link Phase#VALIDATE validity} check and
- * {@link Phase#EXECUTED execution}).
+ * ({@link AbstractDomainEvent.Phase#VALIDATE validity} check and
+ * {@link AbstractDomainEvent.Phase#EXECUTED execution}).
*/
REMOVE_FROM
@@ -102,8 +105,9 @@ public abstract class CollectionDomainEvent<S,T> extends AbstractDomainEvent<S>
this.value = value;
}
/**
- * Not API; updates from {@link Of#ACCESS} to either {@link Of#ADD_TO} or {@link Of#REMOVE_FROM} when hits the
- * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE validation phase}.
+ * Not API; updates from {@link Of#ACCESS} to either {@link Of#ADD_TO}
+ * or {@link Of#REMOVE_FROM} when hits the
+ * {@link AbstractDomainEvent.Phase#VALIDATE validation phase}.
*/
public void setOf(Of of) {
this.of = of;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
index c4e93be..6c87837 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
@@ -50,7 +50,7 @@ public class Bookmark implements Serializable {
/**
* corresponds directly to the object's specification-id
- * @see <code>RootOid</code>
+ * @see RootOid
*/
@NonNull private final String objectType;
@NonNull private final String identifier;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/iactn/Interaction.java b/api/applib/src/main/java/org/apache/isis/applib/services/iactn/Interaction.java
index 973111e..5d00103 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/iactn/Interaction.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/iactn/Interaction.java
@@ -318,7 +318,8 @@ public interface Interaction extends HasUniqueId {
private T dto;
/**
- * <b>NOT API</b>: Set by framework (implementation of {@link MemberExecutor})
+ * <b>NOT API</b>: Set by framework (implementation of
+ * {@link org.apache.isis.core.metamodel.execution.InternalInteraction.MemberExecutor})
*/
public void setDto(final T executionDto) {
this.dto = executionDto;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java b/api/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java
index 8df647b..b2dc005 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java
@@ -45,7 +45,8 @@ import org.apache.isis.commons.internal.collections._Maps;
/**
* An implementation of {@link SchemaOutputResolver} that keeps track of all the schemas for which it has
- * {@link #createOutput(String, String) created} an output {@link StreamResult} containing the content of the schema.
+ * {@link #createOutput(String, String) created} an output {@link StreamResult} containing the content
+ * of the schema.
*/
class CatalogingSchemaOutputResolver extends SchemaOutputResolver {
@@ -124,7 +125,8 @@ class CatalogingSchemaOutputResolver extends SchemaOutputResolver {
@Override
public Result createOutput(
- final String namespaceUri, final String suggestedFileName) throws IOException {
+ final String namespaceUri,
+ final String suggestedFileName) throws IOException {
final StreamResultWithWriter result = new StreamResultWithWriter();
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/publishing/spi/ExecutionSubscriber.java b/api/applib/src/main/java/org/apache/isis/applib/services/publishing/spi/ExecutionSubscriber.java
index ed0cae9..1b63ece 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/publishing/spi/ExecutionSubscriber.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/publishing/spi/ExecutionSubscriber.java
@@ -24,7 +24,7 @@ import org.apache.isis.commons.having.HasEnabling;
/**
* SPI that allows individual interactions (action invocations or property edits) to be
- * {@link #publish(Interaction.Execution) published}.
+ * {@link #onExecution(Interaction.Execution) published}.
* Note that re-publishing is not part of this SPI.
*
* @since 2.0 {@index}
@@ -32,11 +32,14 @@ import org.apache.isis.commons.having.HasEnabling;
public interface ExecutionSubscriber extends HasEnabling {
/**
- * Publish each {@link Interaction.Execution} immediately after it completes.
+ * Publish each {@link org.apache.isis.applib.services.iactn.Interaction.Execution}
+ * immediately after it completes.
* <p>
- * Most implementations are expected to use {@link Interaction.Execution#getDto()} to create a serializable
- * XML representation of the execution. The easiest way to do this is using {@link InteractionDtoUtils#newInteractionDto(Interaction.Execution)}. There is
- * some flexibility here, though.
+ * Most implementations are expected to use
+ * {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getDto()} to create a serializable
+ * XML representation of the execution. The easiest way to do this is using
+ * {@link InteractionDtoUtils#newInteractionDto(Interaction.Execution)}.
+ * There is some flexibility here, though.
*/
void onExecution(Interaction.Execution<?, ?> execution);
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/scratchpad/Scratchpad.java b/api/applib/src/main/java/org/apache/isis/applib/services/scratchpad/Scratchpad.java
index 66e2db8..064b55a 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/scratchpad/Scratchpad.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/scratchpad/Scratchpad.java
@@ -21,10 +21,9 @@ package org.apache.isis.applib.services.scratchpad;
import org.springframework.beans.factory.DisposableBean;
/**
- * This service (API and implementation) provides a mechanism to interchange information between multiple objects invoked in the same
- * interaction. Most commonly this will be as the result of invoking a {@link org.apache.isis.applib.annotation.Bulk}
- * action.
- *
+ * This service (API and implementation) provides a mechanism to interchange information
+ * between multiple objects invoked in the same interaction.
+ * Most commonly this will be as the result of invoking a bulk action.
* <p>
* This implementation has only one implementation (this class) in applib, so it is annotated with
* {@link org.apache.isis.applib.annotation.DomainService}. This means that it is automatically registered and
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/swagger/SwaggerService.java b/api/applib/src/main/java/org/apache/isis/applib/services/swagger/SwaggerService.java
index 37cfa84..6b3c9b1 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/swagger/SwaggerService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/swagger/SwaggerService.java
@@ -25,6 +25,8 @@ import org.apache.isis.applib.annotation.NatureOfService;
import org.apache.isis.applib.annotation.RestrictTo;
/**
+ * The {@link SwaggerService} generates Swagger schema definition files to describe the public and/or private
+ * RESTful APIs exposed by the RestfulObjects viewer.
*
* @since 1.x {@index}
*/
@@ -41,7 +43,7 @@ public interface SwaggerService {
* <p>
* Restricted only to view models ({@link DomainObject} or equivalent)
* and {@link DomainService} with a nature
- * of {@link NatureOfService#VIEW_REST_ONLY}.
+ * of {@link NatureOfService#REST}.
* </p>
*/
PUBLIC,
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/swagger/package-info.java b/api/applib/src/main/java/org/apache/isis/applib/services/swagger/package-info.java
deleted file mode 100644
index 4a80b28..0000000
--- a/api/applib/src/main/java/org/apache/isis/applib/services/swagger/package-info.java
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * The {@link SwaggerService} generates Swagger schema definition files to describe the public and/or private
- * RESTful APIs exposed by the RestfulObjects viewer.
- *
- *
- */
-package org.apache.isis.applib.services.swagger;
\ No newline at end of file
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/user/UserService.java b/api/applib/src/main/java/org/apache/isis/applib/services/user/UserService.java
index ccf90a4..5aff2d3 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/user/UserService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/user/UserService.java
@@ -23,6 +23,7 @@ import java.util.Optional;
import javax.annotation.Nullable;
import org.apache.isis.applib.services.iactn.ExecutionContext;
+import org.apache.isis.applib.services.sudo.SudoService;
import org.apache.isis.commons.internal.exceptions._Exceptions;
/**
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrappingObject.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrappingObject.java
index 1b91b98..1a545aa 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrappingObject.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrappingObject.java
@@ -20,6 +20,7 @@
package org.apache.isis.applib.services.wrapper;
import org.apache.isis.applib.services.wrapper.control.ExecutionMode;
+import org.apache.isis.applib.services.wrapper.control.SyncControl;
import org.apache.isis.commons.collections.ImmutableEnumSet;
/**
@@ -64,10 +65,8 @@ public interface WrappingObject {
* {@link SyncControl} with which this wrapper was
* {@link WrapperFactory#wrap(Object, SyncControl) created}.
*
- * <p>
- * NOTE: domain classes may not have a method with this name. The <tt>__isis_</tt> prefix is
+ * @implNote domain classes may not have a method with this name. The <tt>__isis_</tt> prefix is
* intended to reduce the risk of a collision.
- * </p>
*/
ImmutableEnumSet<ExecutionMode> __isis_executionModes();
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/listeners/InteractionListener.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/listeners/InteractionListener.java
index 3c6b235..832cd1b 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/listeners/InteractionListener.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/listeners/InteractionListener.java
@@ -150,7 +150,7 @@ public interface InteractionListener {
* <p>
* Unlike the other methods in this interface, the source of these events will be an instance of a
* Collection (such as <tt>java.util.List</tt>) rather than the domain object. (The domain object is
- * {@link CollectionMethodEvent#getDomainObject() still available, however).
+ * {@link CollectionMethodEvent#getDomainObject()} still available, however).
*
* @param interactionEvent
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/snapshot/SnapshottableWithInclusions.java b/api/applib/src/main/java/org/apache/isis/applib/snapshot/SnapshottableWithInclusions.java
index a9dd1df..4a73a13 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/snapshot/SnapshottableWithInclusions.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/snapshot/SnapshottableWithInclusions.java
@@ -26,7 +26,8 @@ import org.apache.isis.applib.services.xmlsnapshot.XmlSnapshotService;
/**
* Optional interface for domain objects with which an
* snapshot is to be created using the {@link XmlSnapshotService}, indicating
- * paths to be {@link XmlSnapshotService.Snapshot#} automatically include additional paths within the snapshot.
+ * paths to be {@link org.apache.isis.applib.services.xmlsnapshot.XmlSnapshotService.Snapshot}
+ * automatically include additional paths within the snapshot.
*
* @since 1.x {@index}
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/util/TitleBuffer.java b/api/applib/src/main/java/org/apache/isis/applib/util/TitleBuffer.java
index c305ca2..d5d6d78 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/util/TitleBuffer.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/util/TitleBuffer.java
@@ -22,6 +22,7 @@ package org.apache.isis.applib.util;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
+import org.apache.isis.applib.services.title.TitleService;
import org.apache.isis.commons.internal._Constants;
/**
@@ -49,10 +50,11 @@ public class TitleBuffer {
* Determines if the specified object's title is empty (or null).
*
* <p>
- * Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
- * honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
+ * Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>;
+ * it doesn't honour other mechanisms for specifying the title, such as
+ * {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*/
@@ -107,7 +109,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*/
@@ -123,7 +125,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*/
@@ -160,7 +162,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*/
@@ -181,7 +183,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*
@@ -223,7 +225,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*
@@ -250,7 +252,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*
@@ -335,7 +337,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*
@@ -394,7 +396,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
*
@@ -418,7 +420,7 @@ public class TitleBuffer {
* Note: this method only obtains the title using either <tt>title()</tt> or <tt>toString()</tt>; it doesn't
* honour other mechanisms for specifying the title, such as {@link org.apache.isis.applib.annotation.Title}
* annotation. If that functionality is required, first call
- * {@link org.apache.isis.applib.DomainObjectContainer#titleOf(Object)} on the object and pass in the resultant
+ * {@link TitleService#titleOf(Object)} on the object and pass in the resultant
* string.
* </p>
diff --git a/api/applib/src/main/java/org/apache/isis/applib/util/ZipWriter.java b/api/applib/src/main/java/org/apache/isis/applib/util/ZipWriter.java
index d60adc5..8bbd611 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/util/ZipWriter.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/util/ZipWriter.java
@@ -45,7 +45,6 @@ import lombok.val;
*
* return BlobClobFactory.blobZip(fileName, zipWriter.toBytes());
* </pre>
- * @return a new ZipWriter instance
*
* @since 2.0
* @apiNote Implementation is <em>not</em> thread safe.
diff --git a/api/applib/src/main/java/org/apache/isis/applib/util/schema/InteractionDtoUtils.java b/api/applib/src/main/java/org/apache/isis/applib/util/schema/InteractionDtoUtils.java
index 840267a..b715931 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/util/schema/InteractionDtoUtils.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/util/schema/InteractionDtoUtils.java
@@ -115,8 +115,9 @@ public final class InteractionDtoUtils {
// -- newInteractionDto
/**
- * Encapsulates the mechanism for obtaining a {@link MemberExecutionDto} DTO (XML memento) of the provided
- * in-memory {@link Interaction.Execution}.
+ * Encapsulates the mechanism for obtaining a {@link MemberExecutionDto} DTO (XML memento)
+ * of the provided in-memory
+ * {@link org.apache.isis.applib.services.iactn.Interaction.Execution}.
*/
public enum Strategy {
FLAT {
@@ -172,7 +173,8 @@ public final class InteractionDtoUtils {
/**
* Creates a {@link InteractionDto} (serializable to XML) for the provided
- * {@link Interaction.Execution} (the applib object).
+ * {@link org.apache.isis.applib.services.iactn.Interaction.Execution}
+ * (the applib object).
*/
public static InteractionDto newInteractionDto(final Interaction.Execution<?, ?> execution) {
return newInteractionDto(execution, Strategy.FLAT);
@@ -180,7 +182,8 @@ public final class InteractionDtoUtils {
/**
* Creates a {@link InteractionDto} (serializable to XML) for the provided
- * {@link Interaction.Execution} (the applib object).
+ * {@link org.apache.isis.applib.services.iactn.Interaction.Execution}
+ * (the applib object).
*/
public static InteractionDto newInteractionDto(
final Interaction.Execution<?, ?> execution,
diff --git a/commons/src/main/java/org/apache/isis/commons/binding/InvalidationListener.java b/commons/src/main/java/org/apache/isis/commons/binding/InvalidationListener.java
index 57f5732..230261e 100644
--- a/commons/src/main/java/org/apache/isis/commons/binding/InvalidationListener.java
+++ b/commons/src/main/java/org/apache/isis/commons/binding/InvalidationListener.java
@@ -19,7 +19,7 @@
package org.apache.isis.commons.binding;
/**
- * @param <T>
+ *
*/
@FunctionalInterface
public interface InvalidationListener {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Files.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Files.java
index c60ea0c..f3197c5 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Files.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Files.java
@@ -123,7 +123,7 @@ public class _Files {
}
/**
- * Deletes given {@link file}. This operation is ignored if the file is a directory or does not exist.
+ * Deletes given {@link File}. This operation is ignored if the file is a directory or does not exist.
* @param file - the file to be deleted (null-able)
*/
@SneakyThrows
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Objects.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Objects.java
index ca9a337..e8c15a5 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Objects.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Objects.java
@@ -48,7 +48,7 @@ public final class _Objects {
* @param a
* @param b
* @return {@code <0} if {@code a < b}, {@code >0} if {@code a > b} else {@code 0}
- * @see {@link Comparable#compareTo(Object)}
+ * @see Comparable#compareTo(Object)
* @throws UnsupportedOperationException if neither object is comparable
*/
public static <T> int compareNullsFirst(final @Nullable T a, final @Nullable T b) {
@@ -81,7 +81,7 @@ public final class _Objects {
* @param a
* @param b
* @return {@code <0} if {@code a < b}, {@code >0} if {@code a > b} else {@code 0}
- * @see {@link Comparable#compareTo(Object)}
+ * @see Comparable#compareTo(Object)
* @throws UnsupportedOperationException if neither object is comparable
*/
public static <T> int compareNullsLast(final @Nullable T a, final @Nullable T b) {
@@ -115,7 +115,7 @@ public final class _Objects {
* @param a - nun-null
* @param b - nun-null
* @return {@code <0} if {@code a < b}, {@code >0} if {@code a > b} else {@code 0}
- * @see {@link Comparable#compareTo(Object)}
+ * @see Comparable#compareTo(Object)
* @throws UnsupportedOperationException if neither object is comparable or both are {@code null}
*/
public static <T> int compareNonNull(final /*@NonNull*/ T a, final /*@NonNull*/ T b) {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
index 1e4389e..ff7611b 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
@@ -30,12 +30,11 @@ import static org.apache.isis.commons.internal.base._With.requires;
/**
* <h1>- internal use only -</h1>
* <p>
- * Provides a generic (left-fold) reduction class.
- * </p>
- * <p>
- * Most intuitive example of a reduction is finding the
- * minimum value from a list of values. See {@link ReductionTest} for examples.
- * </p>
+ * Provides a generic (left-fold) reduction class.
+ * <p>
+ * Most intuitive example of a reduction is finding the
+ * minimum value from a list of values.
+ * See {@code org.apache.isis.commons.internal.base.ReductionTest} for examples.
* <p>
* <b>WARNING</b>: Do <b>NOT</b> use any of the classes provided by this package! <br/>
* These may be changed or removed without notice!
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Refs.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Refs.java
index d9c4403..ce167d0 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Refs.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Refs.java
@@ -255,8 +255,8 @@ public final class _Refs {
* @return left - cut off - part of held value (non-null) at the index of the first
* occurrence of the specified substring,
* or an empty string if there is no such occurrence.
- * @see {@link #cutAtIndex(int)}
- * @see {@link String#indexOf(String)}
+ * @see #cutAtIndex(int)
+ * @see String#indexOf(String)
*/
public String cutAtIndexOf(String s) {
return cutAtIndex(value.indexOf(s));
@@ -275,8 +275,8 @@ public final class _Refs {
* @return left - cut off - part of held value (non-null) at the index of the last
* occurrence of the specified substring,
* or an empty string if there is no such occurrence.
- * @see {@link #cutAtIndex(int)}
- * @see {@link String#lastIndexOf(String)}
+ * @see #cutAtIndex(int)
+ * @see String#lastIndexOf(String)
*/
public String cutAtLastIndexOf(String s) {
return cutAtIndex(value.lastIndexOf(s));
@@ -296,8 +296,8 @@ public final class _Refs {
* @return left - cut off - part of held value (non-null) at the index of the first
* occurrence of the specified substring,
* or an empty string if there is no such occurrence.
- * @see {@link #cutAtIndex(int)}
- * @see {@link String#indexOf(String)}
+ * @see #cutAtIndex(int)
+ * @see String#indexOf(String)
*/
public String cutAtIndexOfAndDrop(String s) {
if(!value.contains(s)) {
@@ -322,8 +322,8 @@ public final class _Refs {
* @return left - cut off - part of held value (non-null) at the index of the last
* occurrence of the specified substring,
* or an empty string if there is no such occurrence.
- * @see {@link #cutAtIndex(int)}
- * @see {@link String#lastIndexOf(String)}
+ * @see #cutAtIndex(int)
+ * @see String#lastIndexOf(String)
*/
public String cutAtLastIndexOfAndDrop(String s) {
if(!value.contains(s)) {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Text.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Text.java
index 00804e9..1e680c9 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Text.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Text.java
@@ -85,10 +85,12 @@ public final class _Text {
/**
* Reads content from given {@code input} into a {@link Can} of lines,
* removing new line characters {@code \n,\r} in the process.
- * @param text - nullable
+ * @param input - nullable
* @return non-null
*/
- public static Can<String> readLines(final @Nullable InputStream input, final @NonNull Charset charset){
+ public static Can<String> readLines(
+ final @Nullable InputStream input,
+ final @NonNull Charset charset){
if(input==null) {
return Can.empty();
}
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Timing.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Timing.java
index 3ffc34d..397b1da 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Timing.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Timing.java
@@ -49,7 +49,7 @@ public final class _Timing {
/**
*
- * @param startedAtNanos
+ * @param startedAtSystemNanos
* @return a new {@code startedAtSystemNanos} instance of {@link StopWatch}
*/
public static StopWatch atSystemNanos(long startedAtSystemNanos) {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/codec/_DocumentFactories.java b/commons/src/main/java/org/apache/isis/commons/internal/codec/_DocumentFactories.java
index 32cae58..6c96e8e 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/codec/_DocumentFactories.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/codec/_DocumentFactories.java
@@ -37,7 +37,7 @@ import lombok.experimental.UtilityClass;
* <b>WARNING</b>: Do <b>NOT</b> use any of the classes provided by this package! <br/>
* These may be changed or removed without notice!
*
- * @see https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html
+ * @see <a href="https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html">cheatsheetseries.owasp.org</a>
*
* @since 2.0
*/
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
index 61a81ce..390ac89 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
@@ -217,13 +217,14 @@ public final class _Arrays {
/**
* Copies a collection's elements into an array.
*
- * @param iterable the iterable to copy
- * @param type the type of the elements
+ * @param collection - the collection to convert
+ * @param componentType - type of the elements
* @return a newly-allocated array into which all the elements of the iterable
* have been copied (non-null)
*/
- public static <T> T[] toArray(@Nullable final Collection<? extends T> collection, final Class<T> componentType) {
- _With.requires(componentType, "componentType");
+ public static <T> T[] toArray(
+ final @Nullable Collection<? extends T> collection,
+ final @NonNull Class<T> componentType) {
return _NullSafe.stream(collection)
.collect(toArray(componentType, collection!=null ? collection.size() : 0));
}
@@ -231,13 +232,14 @@ public final class _Arrays {
/**
* Copies an iterable's elements into an array.
*
- * @param iterable the iterable to copy
- * @param type the type of the elements
+ * @param iterable - the iterable to copy
+ * @param componentType - type of the elements
* @return a newly-allocated array into which all the elements of the iterable
* have been copied (non-null)
*/
- public static <T> T[] toArray(@Nullable final Iterable<? extends T> iterable, final Class<T> componentType) {
- _With.requires(componentType, "componentType");
+ public static <T> T[] toArray(
+ final @Nullable Iterable<? extends T> iterable,
+ final @NonNull Class<T> componentType) {
// unnecessary optimization
// if(iterable!=null && (iterable instanceof Collection)) {
// return toArray((Collection<? extends T>) iterable, componentType);
@@ -323,10 +325,11 @@ public final class _Arrays {
/**
* Returns the inferred element type of the specified array type
- * @param type of the array for which to infer the element type
+ * @param arrayType - type of the array for which to infer the element type
* @return inferred type or null if inference fails
*/
- public static @Nullable Class<?> inferComponentTypeIfAny(@Nullable final Class<?> arrayType) {
+ public static @Nullable Class<?> inferComponentTypeIfAny(
+ final @Nullable Class<?> arrayType) {
if(!isArrayType(arrayType)) {
return null;
}
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
index eb1194d..4b6d359 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
@@ -101,7 +101,7 @@ public final class _Collections {
/**
* Adapts the {@code list} as unmodifiable collection.
- * Same as {@link Collections#unmodifiableCollection(List)}.
+ * Same as {@link Collections#unmodifiableCollection(Collection)}.
*
* @param list
* @return null if {@code list} is null
@@ -216,7 +216,7 @@ public final class _Collections {
/**
* @return a collector that collects elements of a stream into an unmodifiable
* List, Set, SortedSet or Collection.
- * @throws IllegalArgumentException if the {@link typeOfCollection} is not one of
+ * @throws IllegalArgumentException if {@code typeOfCollection} is not one of
* List, Set, SortedSet or Collection.
*/
public static <T> Collector<T, ?, ? extends Collection<T>> toUnmodifiableOfType(Class<?> typeOfCollection) {
@@ -316,9 +316,8 @@ public final class _Collections {
}
/**
- *
- * @param parameterType
- * @param genericParameterType
+ * @param collectionType
+ * @param genericType
* @return optionally the inferred element type,
* based on whether parameter is a (collection or array) and has an infer-able element type
*/
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java b/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
index 806f5e1..83d48bb 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
@@ -149,11 +149,14 @@ public final class _Plugin {
/**
* Loads a plugin by name and class-path. (Most likely used by JUnit Tests.)
- * @param pluginClass
+ * @param pluginInterfaceClass
* @param classPath
* @param pluginFullyQualifiedClassName
*/
- public static <S> S load(Class<S> pluginInterfaceClass, File classPath, String pluginFullyQualifiedClassName) {
+ public static <S> S load(
+ Class<S> pluginInterfaceClass,
+ File classPath,
+ String pluginFullyQualifiedClassName) {
try {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java b/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
index 773f91a..ed86a5d 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
@@ -56,7 +56,7 @@ public interface _IocContainer {
* @param requiredType
* @return an instance of the bean, or null if not available or not unique
* (i.e. multiple candidates found with none marked as primary)
- * @throws IsisException if instance creation failed
+ * @throws RuntimeException if instance creation failed
*/
<T> Optional<T> get(Class<T> requiredType);
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
index f9cb856..e11b59d 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
@@ -77,7 +77,7 @@ public class _Json {
* Either deserialize JSON content from given JSON content InputStream into an instance of List
* with given {@code elementType}, or any exception that occurred during parsing.
* @param <T>
- * @param elementType
+ * @param clazz
* @param content
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final InputStream content) {
@@ -116,7 +116,7 @@ public class _Json {
* Either deserialize JSON content from given JSON content String into an instance of List
* with given {@code elementType}, or any exception that occurred during parsing.
* @param <T>
- * @param elementType
+ * @param clazz
* @param content
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final String content) {
@@ -155,7 +155,7 @@ public class _Json {
* Either deserialize JSON content from given JSON content File into an instance of List
* with given {@code elementType}, or any exception that occurred during parsing.
* @param <T>
- * @param elementType
+ * @param clazz
* @param content
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final File content) {
@@ -193,7 +193,7 @@ public class _Json {
* Either deserialize JSON content from given JSON content byte[] into an instance of List
* with given {@code elementType}, or any exception that occurred during parsing.
* @param <T>
- * @param elementType
+ * @param clazz
* @param content
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final byte[] content) {
diff --git a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
index 628ede2..14bc911 100644
--- a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
+++ b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
@@ -841,15 +841,15 @@ public class IsisConfiguration {
* {@link org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber} for publishing.
*
* <p>
- * The service's {@link org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber#publish(Interaction.Execution) publish}
- * method is called only once per transaction, with
- * {@link Interaction.Execution} collecting details of
- * the identity of the target object, the property edited, and the new value of the property.
+ * The service's {@link org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber#publish(Interaction.Execution) publish}
+ * method is called only once per transaction, with
+ * {@link Interaction.Execution} collecting details of
+ * the identity of the target object, the property edited, and the new value of the property.
* </p>
*
* <p>
- * This setting can be overridden on a case-by-case basis using {
- * @link org.apache.isis.applib.annotation.Property#publishing()}.
+ * This setting can be overridden on a case-by-case basis using
+ * {@link org.apache.isis.applib.annotation.Property#publishing()}.
* </p>
*/
private PropertyPublishingPolicy executionPublishing = PropertyPublishingPolicy.NONE;
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/adapter/oid/Oid.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/adapter/oid/Oid.java
index 17807df..7738c67 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/adapter/oid/Oid.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/adapter/oid/Oid.java
@@ -27,11 +27,12 @@ import org.apache.isis.core.metamodel.spec.ObjectSpecId;
import org.apache.isis.schema.common.v2.OidDto;
/**
- * An immutable identifier for either a root object (subtype {@link RootOid}) or
- * a parented collection (subtype {@link ParentedOid}).
+ * An immutable identifier for a root object (subtype {@link RootOid}).
*
* <p>
- * Note that value objects (strings, ints, {@link Value}s etc) do not have an {@link Oid}.
+ * @apiNote value objects (strings, ints, {@link Value}s etc) do not have a
+ * semantically meaningful {@link Oid}, but as an implementation detail
+ * might have a placeholder {@link Oid}.
*/
public interface Oid extends Serializable {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/execution/InternalInteraction.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/execution/InternalInteraction.java
index c869806..edd02b5 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/execution/InternalInteraction.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/execution/InternalInteraction.java
@@ -40,9 +40,10 @@ public interface InternalInteraction extends Interaction {
/**
* Use the provided {@link MemberExecutor} to invoke an action, with the provided
- * {@link ActionInvocation} capturing the details of said action.
+ * {@link org.apache.isis.applib.services.iactn.Interaction.ActionInvocation} capturing
+ * the details of said action.
* <p>
- * Because this both pushes an {@link Interaction.Execution} to
+ * Because this both pushes an {@link org.apache.isis.applib.services.iactn.Interaction.Execution} to
* represent the action invocation and then pops it, that completed
* execution is accessible at {@link Interaction#getPriorExecution()}.
*/
@@ -55,9 +56,10 @@ public interface InternalInteraction extends Interaction {
/**
* Use the provided {@link MemberExecutor} to edit a property, with the provided
- * {@link PropertyEdit} capturing the details of said property edit.
+ * {@link org.apache.isis.applib.services.iactn.Interaction.PropertyEdit}
+ * capturing the details of said property edit.
* <p>
- * Because this both pushes an {@link Interaction.Execution} to
+ * Because this both pushes an {@link org.apache.isis.applib.services.iactn.Interaction.Execution} to
* represent the property edit and then pops it, that completed
* execution is accessible at {@link Interaction#getPriorExecution()}.
*/
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/members/publish/execution/ExecutionPublishingFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/members/publish/execution/ExecutionPublishingFacet.java
index f7f08c4..38b8ac1 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/members/publish/execution/ExecutionPublishingFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/members/publish/execution/ExecutionPublishingFacet.java
@@ -19,7 +19,6 @@
package org.apache.isis.core.metamodel.facets.members.publish.execution;
-import org.apache.isis.applib.services.iactn.Interaction;
import org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber;
import org.apache.isis.core.metamodel.facetapi.Facet;
import org.apache.isis.core.metamodel.facetapi.FacetHolder;
@@ -30,7 +29,7 @@ import lombok.val;
/**
* Indicates that details of the action invocation or property edit,
- * captured by an {@link Interaction.Execution},
+ * captured by an {@link org.apache.isis.applib.services.iactn.Interaction.Execution},
* should be dispatched via {@link ExecutionPublisher} to all subscribed
* {@link ExecutionSubscriber}s.
* <p>
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/bookmarkpolicy/BookmarkPolicyFacetAbstract.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/bookmarkpolicy/BookmarkPolicyFacetAbstract.java
index f2a5b26..d55a4a8 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/bookmarkpolicy/BookmarkPolicyFacetAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/bookmarkpolicy/BookmarkPolicyFacetAbstract.java
@@ -18,7 +18,6 @@
*/
package org.apache.isis.core.metamodel.facets.object.bookmarkpolicy;
-
import java.util.Map;
import org.apache.isis.applib.annotation.BookmarkPolicy;
@@ -26,10 +25,9 @@ import org.apache.isis.core.metamodel.facetapi.Facet;
import org.apache.isis.core.metamodel.facetapi.FacetAbstract;
import org.apache.isis.core.metamodel.facetapi.FacetHolder;
-
-public abstract class BookmarkPolicyFacetAbstract extends FacetAbstract implements
-BookmarkPolicyFacet {
-
+public abstract class BookmarkPolicyFacetAbstract
+extends FacetAbstract
+implements BookmarkPolicyFacet {
public static Class<? extends Facet> type() {
return BookmarkPolicyFacet.class;
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/ChoicesFacetFromBoundedAbstract.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/ChoicesFacetFromBoundedAbstract.java
index 3e03768..3590fed 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/ChoicesFacetFromBoundedAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/ChoicesFacetFromBoundedAbstract.java
@@ -48,12 +48,14 @@ import lombok.val;
*
* <p>
* In the standard Apache Isis Programming Model, corresponds to annotating the
- * member with {@link org.apache.isis.applib.annotation.Bounded Bounded} annotation
- * or implementing the {@link Bounded} marker interface.
+ * member with {@link org.apache.isis.applib.annotation.Bounding Bounding} annotation.
*/
public abstract class ChoicesFacetFromBoundedAbstract
extends FacetAbstract
-implements ChoicesFacet, DisablingInteractionAdvisor, ValidatingInteractionAdvisor {
+implements
+ ChoicesFacet,
+ DisablingInteractionAdvisor,
+ ValidatingInteractionAdvisor {
public static Class<? extends Facet> type() {
return ChoicesFacet.class;
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/immutable/EditingEnabledFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/immutable/EditingEnabledFacet.java
index 57b532f..eb21cee 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/immutable/EditingEnabledFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/immutable/EditingEnabledFacet.java
@@ -19,7 +19,6 @@
package org.apache.isis.core.metamodel.facets.object.immutable;
-import org.apache.isis.core.config.IsisConfiguration;
import org.apache.isis.core.metamodel.facetapi.Facet;
import org.apache.isis.core.metamodel.facets.object.value.EqualByContentFacet;
import org.apache.isis.core.metamodel.facets.object.value.ValueFacet;
@@ -29,7 +28,7 @@ import org.apache.isis.core.metamodel.facets.object.value.ValueFacet;
* modified either through the viewer or indeed programmatically.
* <p>
* Overrides at type level the object editing configuration
- * {@link IsisConfiguration.Applib.Annotation.DomainObject#getEditing()}
+ * {@link org.apache.isis.core.config.IsisConfiguration.Applib.Annotation.DomainObject#getEditing()}
*
* @see EqualByContentFacet
* @see ValueFacet
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/recreatable/RecreatableObjectFacetAbstract.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/recreatable/RecreatableObjectFacetAbstract.java
index 587e421..dcff482 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/recreatable/RecreatableObjectFacetAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/recreatable/RecreatableObjectFacetAbstract.java
@@ -99,7 +99,8 @@ implements ViewModelFacet {
/**
* Hook for subclass; must be overridden if {@link #getRecreationMechanism()} is
- * {@link RecreationMechanism#INSTANTIATES} (ignored otherwise).
+ * {@link org.apache.isis.core.metamodel.facets.object.viewmodel.ViewModelFacet.RecreationMechanism#INSTANTIATES}
+ * (ignored otherwise).
*/
protected Object doInstantiate(final Class<?> viewModelClass, final String mementoStr) {
throw new IllegalStateException("doInstantiate() must be overridden if RecreationMechanism is INSTANTIATES");
@@ -117,7 +118,8 @@ implements ViewModelFacet {
/**
* Hook for subclass; must be overridden if {@link #getRecreationMechanism()} is
- * {@link RecreationMechanism#INITIALIZES} (ignored otherwise).
+ * {@link org.apache.isis.core.metamodel.facets.object.viewmodel.ViewModelFacet.RecreationMechanism#INITIALIZES}
+ * (ignored otherwise).
*/
protected void doInitialize(final Object viewModelPojo, final String mementoStr) {
throw new IllegalStateException("doInitialize() must be overridden if RecreationMechanism is INITIALIZE");
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/temporal/TemporalAdjust.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/temporal/TemporalAdjust.java
index f04906c..49b9eeb 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/temporal/TemporalAdjust.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/temporal/TemporalAdjust.java
@@ -34,7 +34,7 @@ import lombok.Value;
/**
*
* @since 2.0
- * @see {@link TemporalAdjuster}
+ * @see TemporalAdjuster
*/
@Value(staticConstructor = "of")
public class TemporalAdjust {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/DeweyOrderSet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/DeweyOrderSet.java
index f993e93..22e3c79 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/DeweyOrderSet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/DeweyOrderSet.java
@@ -43,7 +43,7 @@ import org.apache.isis.core.metamodel.layout.memberorderfacet.MemberOrderCompara
*
* <p>
* At each level the elements are either {@link FacetedMethod}s or they are
- * instances of {@link OrderSet} represent a group of {@link FacetedMethod}s
+ * instances of {@link DeweyOrderSet} represent a group of {@link FacetedMethod}s
* that have a {@link MemberOrderFacet} of the same name.
*
* <p>
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberOrderComparator.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberOrderComparator.java
index 2501099..048c871 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberOrderComparator.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberOrderComparator.java
@@ -32,8 +32,8 @@ import org.apache.isis.core.metamodel.layout.DeweyOrderSet;
* ).
*
* <p>
- * Will also compare {@link OrderSet}s; these are put after any
- * {@link FacetedMethod}s. If there is more than one OrderSet then these are
+ * Will also compare {@link DeweyOrderSet}s; these are put after any
+ * {@link FacetedMethod}s. If there is more than one DeweyOrderSet then these are
* compared by an {@link OrderSetGroupNameComparator}.
*
* <p>
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/OrderSetGroupNameComparator.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/OrderSetGroupNameComparator.java
index ec38bf4..337a7bd 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/OrderSetGroupNameComparator.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/OrderSetGroupNameComparator.java
@@ -25,11 +25,11 @@ import java.util.Comparator;
import org.apache.isis.core.metamodel.layout.DeweyOrderSet;
/**
- * Compares by (simple) group name of each {@link OrderSet}.
+ * Compares by (simple) group name of each {@link DeweyOrderSet}.
*
* <p>
- * Note that it only makes sense to use this comparator for {@link OrderSet}s
- * that are known to have the same parent {@link OrderSet}s.
+ * Note that it only makes sense to use this comparator for {@link DeweyOrderSet}s
+ * that are known to have the same parent {@link DeweyOrderSet}s.
*/
public class OrderSetGroupNameComparator implements Comparator<DeweyOrderSet>, Serializable {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
index a492f44..ca8be8e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
@@ -197,7 +197,7 @@ extends
* Returns the description, if any, of the specification.
*
* <p>
- * Corresponds to the {@link DescribedAsFacet#value()) value} of
+ * Corresponds to the {@link DescribedAsFacet#value() value} of
* {@link DescribedAsFacet}; is not necessarily immutable.
*/
@Override
@@ -207,7 +207,7 @@ extends
* Returns a help string or lookup reference, if any, of the specification.
*
* <p>
- * Corresponds to the {@link HelpFacet#value()) value} of {@link HelpFacet};
+ * Corresponds to the {@link HelpFacet#value() value} of {@link HelpFacet};
* is not necessarily immutable.
*/
String getHelp();
@@ -225,7 +225,7 @@ extends
* Returns the name of an icon to use for the specified object.
*
* <p>
- * Corresponds to the {@link IconFacet#iconName(Instance)) icon name}
+ * Corresponds to the {@link IconFacet#iconName(ManagedObject) icon name}
* returned by the {@link IconFacet}; is not necessarily immutable.
*/
String getIconName(ManagedObject object);
@@ -241,7 +241,7 @@ extends
* Returns the CSS class name to use for the specified object.
*
* <p>
- * Corresponds to the {@link CssClassFacet#cssClass(org.apache.isis.core.metamodel.spec.Instance)} value}
+ * Corresponds to the {@link CssClassFacet#cssClass(ManagedObject)} value}
* returned by the {@link CssClassFacet}.
*
* @param objectAdapter - to evaluate (may be <tt>null</tt> if called by deprecated {@link #getCssClass}).
@@ -311,7 +311,7 @@ extends
* In effect, means that it doesn't have the {@link CollectionFacet}, and
* therefore will return NOT {@link #isParentedOrFreeCollection()}
*
- * @see #isParentedOrFreeCollection().
+ * @see #isParentedOrFreeCollection()
*/
default boolean isNotCollection() {
return !isParentedOrFreeCollection();
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
index c4febfa..a0937a0 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
@@ -137,9 +137,9 @@ public interface ObjectAction extends ObjectMember {
*
* <p>
* Basically just calls (the helper methods also called by) first
- * {@link #isArgumentSetValidForParameters(ManagedObject, List, InteractionInitiatedBy)}
+ * {@link #isArgumentSetValidForParameters(InteractionHead, Can, InteractionInitiatedBy)}
* and then
- * {@link #isArgumentSetValidForAction(ManagedObject, List, InteractionInitiatedBy)}
+ * {@link #isArgumentSetValidForAction(InteractionHead, Can, InteractionInitiatedBy)}
* Those methods are
* separated out so that viewers have more fine-grained control.
* </p>
@@ -151,10 +151,10 @@ public interface ObjectAction extends ObjectMember {
/**
* Normally action validation is all performed by
- * {@link #isArgumentSetValid(ManagedObject, List, InteractionInitiatedBy)}, which calls
- * {@link #isArgumentSetValidForParameters(ManagedObject, List, InteractionInitiatedBy) this method} to
+ * {@link #isArgumentSetValid(InteractionHead, Can, InteractionInitiatedBy)}, which calls
+ * {@link #isArgumentSetValidForParameters(InteractionHead, Can, InteractionInitiatedBy) this method} to
* validate arguments individually, and then
- * {@link #isArgumentSetValidForAction(ManagedObject, List, InteractionInitiatedBy) validate argument set}
+ * {@link #isArgumentSetValidForAction(InteractionHead, Can, InteractionInitiatedBy) validate argument set}
* afterwards.
*
* <p>
@@ -169,10 +169,10 @@ public interface ObjectAction extends ObjectMember {
/**
* Normally action validation is all performed by
- * {@link #isArgumentSetValid(ManagedObject, List, InteractionInitiatedBy)}, which calls
- * {@link #isArgumentSetValidForParameters(ManagedObject, List, InteractionInitiatedBy)} to
+ * {@link #isArgumentSetValid(InteractionHead, Can, InteractionInitiatedBy)}, which calls
+ * {@link #isArgumentSetValidForParameters(InteractionHead, Can, InteractionInitiatedBy)} to
* validate arguments individually, and then
- * {@link #isArgumentSetValidForAction(ManagedObject, List, InteractionInitiatedBy) this method} to
+ * {@link #isArgumentSetValidForAction(InteractionHead, Can, InteractionInitiatedBy) this method} to
* validate the entire argument set afterwards.
*
* <p>
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionContainer.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionContainer.java
index 5f3d0c8..eff0ef5 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionContainer.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionContainer.java
@@ -75,7 +75,8 @@ public interface ObjectActionContainer {
Optional<ObjectAction> getDeclaredAction(String id, @Nullable ActionType type);
/**
- * Shortcut to {@link #getDeclaredAction(String, null)}, meaning where action type is <i>any</i>.
+ * Shortcut to {@link #getDeclaredAction(String, ActionType)} with {@code ActionType = null},
+ * meaning where action type is <i>any</i>.
* @see #getDeclaredAction(String, ActionType)
*/
default Optional<ObjectAction> getDeclaredAction(String id) {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectMember.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectMember.java
index c614c3e..ff08d86 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectMember.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectMember.java
@@ -63,7 +63,7 @@ public interface ObjectMember extends ObjectFeature {
* <p>
* Determined as per the {@link HiddenFacet} being present and
* {@link HiddenFacet#when()} returning {@link When#ALWAYS}, and
- * {@link HiddenFacet#where()} returning {@link When#ANYWHERE}.
+ * {@link HiddenFacet#where()} returning {@link Where#ANYWHERE}.
*/
boolean isAlwaysHidden();
diff --git a/core/transaction/src/main/java/org/apache/isis/core/transaction/events/TransactionAfterCompletionEvent.java b/core/transaction/src/main/java/org/apache/isis/core/transaction/events/TransactionAfterCompletionEvent.java
index b1aebe8..a8e793d 100644
--- a/core/transaction/src/main/java/org/apache/isis/core/transaction/events/TransactionAfterCompletionEvent.java
+++ b/core/transaction/src/main/java/org/apache/isis/core/transaction/events/TransactionAfterCompletionEvent.java
@@ -22,7 +22,7 @@ import org.springframework.transaction.support.TransactionSynchronization;
/**
* @since 2.0 {@index}
- * @see {@link TransactionSynchronization}
+ * @see TransactionSynchronization
*/
public enum TransactionAfterCompletionEvent {
diff --git a/core/webapp/src/main/java/org/apache/isis/core/webapp/modules/WebModuleAbstract.java b/core/webapp/src/main/java/org/apache/isis/core/webapp/modules/WebModuleAbstract.java
index 30a1dd4..ea52d1a 100644
--- a/core/webapp/src/main/java/org/apache/isis/core/webapp/modules/WebModuleAbstract.java
+++ b/core/webapp/src/main/java/org/apache/isis/core/webapp/modules/WebModuleAbstract.java
@@ -74,9 +74,7 @@ public abstract class WebModuleAbstract implements WebModule {
/**
* Instantiates a new {@link ServletContextListener}
- * @param ctx
* @param listenerCls
- * @return
* @throws ServletException
*/
protected ServletContextListener createListener(
diff --git a/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdo.java b/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdo.java
index fca41e9..b194f85 100644
--- a/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdo.java
+++ b/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdo.java
@@ -364,7 +364,7 @@ public class CommandJdo
/**
* Implementation note: persisted as a string rather than a UUID as fails
* to persist if using h2 (perhaps would need to be mapped differently).
- * @see <a href="https://www.datanucleus.org/products/accessplatform/jdo/mapping.html#_other_types">DN documentation</a>.
+ * @see <a href="https://www.datanucleus.org/products/accessplatform/jdo/mapping.html#_other_types">www.datanucleus.org</a>
*/
@javax.jdo.annotations.PrimaryKey
@javax.jdo.annotations.Persistent
diff --git a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/jobcallables/ReplicateAndRunCommands.java b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/jobcallables/ReplicateAndRunCommands.java
index f055957..807e610 100644
--- a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/jobcallables/ReplicateAndRunCommands.java
+++ b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/jobcallables/ReplicateAndRunCommands.java
@@ -126,7 +126,7 @@ public class ReplicateAndRunCommands implements Callable<SecondaryStatus> {
/**
*
* @param commandsToReplay
- * @return - whether there was a command to process (and so continue)
+ * @apiNote could return, whether there was a command to process (and so continue)
*/
private void replay(List<CommandJdo> commandsToReplay) {
diff --git a/extensions/security/secman/api/src/main/java/org/apache/isis/extensions/secman/api/tenancy/HasAtPath.java b/extensions/security/secman/api/src/main/java/org/apache/isis/extensions/secman/api/tenancy/HasAtPath.java
index 552ecf9..07d7ec5 100644
--- a/extensions/security/secman/api/src/main/java/org/apache/isis/extensions/secman/api/tenancy/HasAtPath.java
+++ b/extensions/security/secman/api/src/main/java/org/apache/isis/extensions/secman/api/tenancy/HasAtPath.java
@@ -24,16 +24,16 @@ package org.apache.isis.extensions.secman.api.tenancy;
* can be used to determine its visibility/editability.
*
* <p>
- * Previously the <code>atPath</code> would have corresponded to the unique path of some particular
- * {@link org.apache.isis.extensions.secman.jdo.dom.tenancy.ApplicationTenancy} instance. However, this has now been
- * generalized; the atPath is simply a string whose interpretation is application-specific (in particular by
- * the {@link ApplicationTenancyEvaluator} SPI).
- * </p>
+ * Previously the <code>atPath</code> would have corresponded to the unique path of some particular
+ * {@link ApplicationTenancy} instance.
+ * However, this has now been generalized;
+ * the atPath is simply a string whose interpretation is application-specific (in particular by
+ * the {@link ApplicationTenancyEvaluator} SPI).
*
* <p>
* For applications that still wish to follow the original more specific design (that the <code>atPath</code>
- * corresponds to a single {@link ApplicationTenancy}), then the path can be interpreted according to the following
- * table:
+ * corresponds to a single {@link ApplicationTenancy}), then the path can be interpreted according to the
+ * following table:
* </p>
* <table border="1">
* <tr>
@@ -100,7 +100,9 @@ package org.apache.isis.extensions.secman.api.tenancy;
* <td>/it/car</td><td>null</td><td>not visible</td>
* </tr>
* </table>
- * <p>any object that is not tenanted (that is, its class does not implement {@link HasAtPath the WithApplicationTenancy interface} is accessible by any user (usual permission rules apply).
+ * <p>any object that is not tenanted (that is, its class does not implement
+ * {@link HasAtPath the WithApplicationTenancy interface} is accessible by any user
+ * (usual permission rules apply).
* </p>
*
* @since 2.0 {@index}
diff --git a/extensions/security/secman/shiro-realm/src/main/java/org/apache/isis/extensions/secman/shiro/PrincipalForApplicationUser.java b/extensions/security/secman/shiro-realm/src/main/java/org/apache/isis/extensions/secman/shiro/PrincipalForApplicationUser.java
index 0cdec88..2cd62a9 100644
--- a/extensions/security/secman/shiro-realm/src/main/java/org/apache/isis/extensions/secman/shiro/PrincipalForApplicationUser.java
+++ b/extensions/security/secman/shiro-realm/src/main/java/org/apache/isis/extensions/secman/shiro/PrincipalForApplicationUser.java
@@ -55,7 +55,8 @@ import lombok.val;
* </p>
*
* TODO: this should probably implement java.security.Principal so that it doesn't get wrapped in a
- * ShiroHttpServletRequest.ObjectPrincipal. Such a change would need some testing to avoid regressions, though.
+ * ShiroHttpServletRequest.ObjectPrincipal.
+ * Such a change would need some testing to avoid regressions, though.
*/
@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
class PrincipalForApplicationUser implements AuthorizationInfo {
diff --git a/incubator/viewers/javafx/model/src/main/java/org/apache/isis/incubator/viewer/javafx/model/util/_fx.java b/incubator/viewers/javafx/model/src/main/java/org/apache/isis/incubator/viewer/javafx/model/util/_fx.java
index 31ac904..692909e 100644
--- a/incubator/viewers/javafx/model/src/main/java/org/apache/isis/incubator/viewer/javafx/model/util/_fx.java
+++ b/incubator/viewers/javafx/model/src/main/java/org/apache/isis/incubator/viewer/javafx/model/util/_fx.java
@@ -220,7 +220,6 @@ public final class _fx {
/**
* Do not consider node for layout calculations, when not visible
* @param node
- * @return
*/
public static Node visibilityLayoutFix(Node node) {
node.managedProperty().bind(node.visibleProperty());
diff --git a/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/binding/BindingsVaa.java b/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/binding/BindingsVaa.java
index b67bad9..e3adc0c 100644
--- a/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/binding/BindingsVaa.java
+++ b/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/binding/BindingsVaa.java
@@ -176,7 +176,6 @@ public final class BindingsVaa {
* @param value
* @param valueSpec
* @param converter - converts between model and presentation
- * @param nullRepresentation - the model value to use instead of null
* @param customizer - to customize the binding builder (ignored if null)
*/
public static <P, M> void bindValueBidirectional(
diff --git a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/DomainObjectContainer.java b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/DomainObjectContainer.java
index abf2072..df89aa4 100644
--- a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/DomainObjectContainer.java
+++ b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/DomainObjectContainer.java
@@ -230,7 +230,7 @@ public class DomainObjectContainer {
*
* @deprecated - in almost all cases the workflow is to {@link #newTransientInstance(Class)}, populate the object
* (eg with the arguments to an action) and then to
- * {@link #persist(Object) persist) the object. It is exceptionally rare for
+ * {@link #persist(Object) persist} the object. It is exceptionally rare for
* an object to be created, and with no further data required - be in a state
* to be persisted immediately.
*/
diff --git a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/ActionDomainEvent.java b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/ActionDomainEvent.java
index 47ff80c..aa72e3f 100644
--- a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/ActionDomainEvent.java
+++ b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/ActionDomainEvent.java
@@ -145,8 +145,10 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
// -- arguments
private List<Object> arguments;
/**
- * The arguments being used to invoke the action; populated at {@link Phase#VALIDATE} and subsequent phases
- * (but null for {@link Phase#HIDE hidden} and {@link Phase#DISABLE disable} phases).
+ * The arguments being used to invoke the action;
+ * populated at {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE} and subsequent phases
+ * (but null for {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#HIDE hidden}
+ * and {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#DISABLE disable} phases).
*/
public List<Object> getArguments() {
return arguments;
@@ -170,7 +172,8 @@ public abstract class ActionDomainEvent<S> extends AbstractDomainEvent<S> {
* The value returned by the action.
*
* <p>
- * Only available for the {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#EXECUTED}
+ * Only available for the
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#EXECUTED}
* {@link #getEventPhase() phase}.
* </p>
*/
diff --git a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/CollectionDomainEvent.java b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/CollectionDomainEvent.java
index 07d5799..ee4a655 100644
--- a/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/CollectionDomainEvent.java
+++ b/legacy/extensions/core/applib/src/main/java/org/apache/isis/legacy/applib/services/eventbus/CollectionDomainEvent.java
@@ -93,20 +93,20 @@ public abstract class CollectionDomainEvent<S, T> extends AbstractDomainEvent<S>
public static enum Of {
/**
* The collection is being accessed
- * ({@link Phase#HIDE hide} and
- * {@link Phase#DISABLE disable}) checks.
+ * ({@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#HIDE hide} and
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#DISABLE disable}) checks.
*/
ACCESS,
/**
* The collection is being added to
- * ({@link Phase#VALIDATE validity} check and
- * {@link Phase#EXECUTED execution}).
+ * ({@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE validity} check and
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#EXECUTED execution}).
*/
ADD_TO,
/**
* The collection is being removed from
- * ({@link Phase#VALIDATE validity} check and
- * {@link Phase#EXECUTED execution}).
+ * ({@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#VALIDATE validity} check and
+ * {@link org.apache.isis.applib.events.domain.AbstractDomainEvent.Phase#EXECUTED execution}).
*/
REMOVE_FROM
}
diff --git a/persistence/jdo/datanucleus/src/main/java/org/apache/isis/persistence/jdo/datanucleus/IsisModuleJdoDatanucleus.java b/persistence/jdo/datanucleus/src/main/java/org/apache/isis/persistence/jdo/datanucleus/IsisModuleJdoDatanucleus.java
index aed2213..cab7ccd 100644
--- a/persistence/jdo/datanucleus/src/main/java/org/apache/isis/persistence/jdo/datanucleus/IsisModuleJdoDatanucleus.java
+++ b/persistence/jdo/datanucleus/src/main/java/org/apache/isis/persistence/jdo/datanucleus/IsisModuleJdoDatanucleus.java
@@ -88,8 +88,8 @@ public class IsisModuleJdoDatanucleus {
/**
* {@link TransactionAwarePersistenceManagerFactoryProxy} was retired by the Spring Framework, recommended usage is still online [1].
* Sources have been recovered from [2].
- * @see [1] https://docs.spring.io/spring-framework/docs/3.0.0.RC2/reference/html/ch13s04.html
- * @see [2] https://github.com/spring-projects/spring-framework/tree/2b3445df8134e2b0c4e4a4c4136cbaf9d58b7fc4/spring-orm/src/main/java/org/springframework/orm/jdo
+ * @see <a href="https://docs.spring.io/spring-framework/docs/3.0.0.RC2/reference/html/ch13s04.html">[1] docs.spring.io</a>
+ * @see <a href="https://github.com/spring-projects/spring-framework/tree/2b3445df8134e2b0c4e4a4c4136cbaf9d58b7fc4/spring-orm/src/main/java/org/springframework/orm/jdo">[2] github.com/spring-projects</a>
*/
@Bean @Primary @Named("transaction-aware-pmf-proxy")
public TransactionAwarePersistenceManagerFactoryProxy getTransactionAwarePersistenceManagerFactoryProxy(
diff --git a/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/metamodel/facets/object/query/JdoNamedQuery.java b/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/metamodel/facets/object/query/JdoNamedQuery.java
index f435745..a2eb89d 100644
--- a/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/metamodel/facets/object/query/JdoNamedQuery.java
+++ b/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/metamodel/facets/object/query/JdoNamedQuery.java
@@ -35,7 +35,7 @@ import lombok.ToString;
* Value object that represents the information of a
* {@link javax.jdo.annotations.Query}.
*
- * @see {@link JdoQueryFacet}.
+ * @see org.apache.isis.persistence.jdo.provider.metamodel.facets.object.query.JdoQueryFacet
*/
@Getter
@AllArgsConstructor(access = AccessLevel.PRIVATE)
diff --git a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
index c9d61f9..231a437 100644
--- a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
+++ b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
@@ -207,7 +207,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
/**
* Mandatory hook
* @param overlap
- * @return
*/
protected abstract T newInterval(Interval overlap);
diff --git a/subdomains/excel/applib/src/main/java/org/apache/isis/subdomains/excel/applib/dom/WorksheetSpec.java b/subdomains/excel/applib/src/main/java/org/apache/isis/subdomains/excel/applib/dom/WorksheetSpec.java
index 18aa7bf..2b89470 100644
--- a/subdomains/excel/applib/src/main/java/org/apache/isis/subdomains/excel/applib/dom/WorksheetSpec.java
+++ b/subdomains/excel/applib/src/main/java/org/apache/isis/subdomains/excel/applib/dom/WorksheetSpec.java
@@ -35,7 +35,7 @@ public class WorksheetSpec {
/**
* Maximum supported by Microsoft Excel UI.
*
- * @see <a href="http://stackoverflow.com/questions/3681868/is-there-a-limit-on-an-excel-worksheets-name-length">this SO answer</a>, for example.
+ * @see <a href="http://stackoverflow.com/questions/3681868/is-there-a-limit-on-an-excel-worksheets-name-length">stackoverflow.com</a>
*/
private static final int SHEET_NAME_MAX_LEN = 31;
private static final String ROW_HANDLER_SUFFIX = "RowHandler";
diff --git a/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture.java b/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture.java
index 68c9fb8..d7d34b0 100644
--- a/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture.java
+++ b/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture.java
@@ -50,8 +50,9 @@ import lombok.Setter;
import lombok.val;
/**
- * This class should be executed using {@link FixtureScripts.MultipleExecutionStrategy#EXECUTE_ONCE_BY_VALUE} (it
- * has value semantics).
+ * This class should be executed using
+ * {@link org.apache.isis.testing.fixtures.applib.fixturescripts.FixtureScripts.MultipleExecutionStrategy#EXECUTE_ONCE_BY_VALUE}
+ * (it has value semantics).
*
* @since 2.0 {@index}
*/
diff --git a/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture2.java b/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture2.java
index a8359e5..3ce5882 100644
--- a/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture2.java
+++ b/subdomains/excel/testing/src/main/java/org/apache/isis/subdomains/excel/testing/ExcelFixture2.java
@@ -39,8 +39,9 @@ import lombok.Setter;
import lombok.val;
/**
- * This class should be executed using {@link FixtureScripts.MultipleExecutionStrategy#EXECUTE_ONCE_BY_VALUE} (it
- * has value semantics).
+ * This class should be executed using
+ * {@link org.apache.isis.testing.fixtures.applib.fixturescripts.FixtureScripts.MultipleExecutionStrategy#EXECUTE_ONCE_BY_VALUE}
+ * (it has value semantics).
*
* @since 2.0 {@index}
*/
diff --git a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/api/FixtureScriptWithExecutionStrategy.java b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/api/FixtureScriptWithExecutionStrategy.java
index 2b1ffb5..56ebf3c 100644
--- a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/api/FixtureScriptWithExecutionStrategy.java
+++ b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/api/FixtureScriptWithExecutionStrategy.java
@@ -24,7 +24,8 @@ import org.apache.isis.testing.fixtures.applib.fixturespec.FixtureScriptsSpecifi
/**
* Overrides the {@link FixtureScriptsSpecification#getMultipleExecutionStrategy() globally-defined}
- * {@link FixtureScripts.MultipleExecutionStrategy} strategy, allowing individual fixtures to indicate that they have their own execution strategy.
+ * {@link org.apache.isis.testing.fixtures.applib.fixturescripts.FixtureScripts.MultipleExecutionStrategy}
+ * strategy, allowing individual fixtures to indicate that they have their own execution strategy.
*/
public interface FixtureScriptWithExecutionStrategy {
diff --git a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/BuilderScriptWithoutResult.java b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/BuilderScriptWithoutResult.java
index 0a8f4b1..9276522 100644
--- a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/BuilderScriptWithoutResult.java
+++ b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/BuilderScriptWithoutResult.java
@@ -21,8 +21,6 @@ package org.apache.isis.testing.fixtures.applib.fixturescripts;
/**
*
* @since 2.0
- *
- * @param <T>
*/
public abstract class BuilderScriptWithoutResult extends BuilderScriptAbstract<Object> {
diff --git a/valuetypes/asciidoc/ui/wicket/src/main/java/org/apache/isis/valuetypes/asciidoc/ui/wkt/components/AsciiDocForXmlComponentWkt.java b/valuetypes/asciidoc/ui/wicket/src/main/java/org/apache/isis/valuetypes/asciidoc/ui/wkt/components/AsciiDocForXmlComponentWkt.java
index 1119309..4a753c1 100644
--- a/valuetypes/asciidoc/ui/wicket/src/main/java/org/apache/isis/valuetypes/asciidoc/ui/wkt/components/AsciiDocForXmlComponentWkt.java
+++ b/valuetypes/asciidoc/ui/wicket/src/main/java/org/apache/isis/valuetypes/asciidoc/ui/wkt/components/AsciiDocForXmlComponentWkt.java
@@ -20,8 +20,6 @@ package org.apache.isis.valuetypes.asciidoc.ui.wkt.components;
import org.apache.wicket.model.IModel;
-import org.apache.isis.applib.util.schema.CommandDtoUtils;
-import org.apache.isis.schema.cmd.v2.CommandDto;
import org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc;
import lombok.val;
@@ -38,7 +36,6 @@ public class AsciiDocForXmlComponentWkt extends AsciiDocComponentWkt {
/**
* for convenience of subtypes.
* @param xml
- * @return
*/
protected final String asHtml(String xml) {
val adoc = "[source,xml]\n----\n" + xml + "\n----";
diff --git a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/annotations/SseSource.java b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/annotations/SseSource.java
index 0274a81..f8b8dab 100644
--- a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/annotations/SseSource.java
+++ b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/annotations/SseSource.java
@@ -24,7 +24,7 @@ import org.apache.isis.valuetypes.sse.applib.service.SseChannel;
/**
* Server-sent events.
*
- * @see https://www.w3schools.com/html/html5_serversentevents.asp
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
*
* @since 2.0 {@index}
*/
diff --git a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseChannel.java b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseChannel.java
index 2fde4b0..efe2bfb 100644
--- a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseChannel.java
+++ b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseChannel.java
@@ -27,7 +27,7 @@ import org.apache.isis.valuetypes.sse.applib.annotations.SseSource;
/**
* Server-sent events.
*
- * @see https://www.w3schools.com/html/html5_serversentevents.asp
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
*
* @since 2.0 {@index}
*/
diff --git a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseService.java b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseService.java
index 917e78c..12a8c50 100644
--- a/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseService.java
+++ b/valuetypes/sse/applib/src/main/java/org/apache/isis/valuetypes/sse/applib/service/SseService.java
@@ -25,7 +25,7 @@ import org.apache.isis.valuetypes.sse.applib.annotations.SseSource;
/**
* Server-sent events.
*
- * @see https://www.w3schools.com/html/html5_serversentevents.asp
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
*
* @since 2.0 {@index}
*/
diff --git a/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/services/SseServiceDefault.java b/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/services/SseServiceDefault.java
index 1c2abed..785aa07 100644
--- a/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/services/SseServiceDefault.java
+++ b/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/services/SseServiceDefault.java
@@ -56,7 +56,7 @@ import lombok.extern.log4j.Log4j2;
/**
* Server-sent events.
*
- * @see https://www.w3schools.com/html/html5_serversentevents.asp
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
*
* @since 2.0 {@index}
*/
diff --git a/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/webmodule/ServerSentEventsServlet.java b/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/webmodule/ServerSentEventsServlet.java
index fad5b73..2b8f641 100644
--- a/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/webmodule/ServerSentEventsServlet.java
+++ b/valuetypes/sse/ui/wicket/src/main/java/org/apache/isis/valuetypes/sse/ui/wkt/webmodule/ServerSentEventsServlet.java
@@ -44,7 +44,7 @@ import lombok.extern.log4j.Log4j2;
/**
* Server-sent events.
*
- * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">Server Sent Events (@ w3schools)</a>
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
*
* @since 2.0
*
diff --git a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/decorator/ActionUiDecorator.java b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/decorator/ActionUiDecorator.java
index 2544dcd..fc3b42a 100644
--- a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/decorator/ActionUiDecorator.java
+++ b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/decorator/ActionUiDecorator.java
@@ -28,9 +28,7 @@ import lombok.Getter;
import lombok.RequiredArgsConstructor;
/**
- * Decorates a click-able UI component of type {@code <T>} based on an {@link ActionLinkUiModel}.
- *
- * @see ActionLinkUiModel
+ * Decorates a click-able UI component of type {@code <T>} based various UiModels.
*
* @since 2.0.0
* @param <T> - link component type, native to the viewer
diff --git a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/RestfulMediaType.java b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/RestfulMediaType.java
index de26e3f..24a83b5 100644
--- a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/RestfulMediaType.java
+++ b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/RestfulMediaType.java
@@ -26,7 +26,7 @@ package org.apache.isis.viewer.restfulobjects.applib;
* Because these values are used in the <tt>@Produces</tt> annotation on the jax-rs
* resources, they must be constants and must be strings.
*
- * @see http://buzzword.org.uk/2009/draft-inkster-profile-parameter-00.html
+ * @see <a href="http://buzzword.org.uk/2009/draft-inkster-profile-parameter-00.html">buzzword.org.uk</a>
*
* @since 1.x {@index}
*/
diff --git a/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/webmodule/auth/AuthenticationStrategy.java b/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/webmodule/auth/AuthenticationStrategy.java
index 172280d..188445a 100644
--- a/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/webmodule/auth/AuthenticationStrategy.java
+++ b/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/webmodule/auth/AuthenticationStrategy.java
@@ -33,7 +33,7 @@ public interface AuthenticationStrategy {
/**
* Returns a still-valid {@link Authentication} or {@code null}
- * @see {@link AuthenticationManager#isSessionValid(Authentication)
+ * @see AuthenticationManager#isSessionValid(Authentication)
*/
Authentication lookupValid(
HttpServletRequest httpServletRequest,
diff --git a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
index 97f6284..6b29d79 100644
--- a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
+++ b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
@@ -22,62 +22,61 @@ package org.apache.isis.viewer.wicket.model.isis;
import java.io.Serializable;
import org.apache.isis.applib.annotation.PromptStyle;
-import org.apache.isis.core.config.IsisConfiguration;
public interface WicketViewerSettings extends Serializable {
/**
- * as per {@link IsisConfiguration.Viewer.Wicket#setMaxTitleLengthInStandaloneTables(int)}
+ * as per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setMaxTitleLengthInStandaloneTables(int)}
*/
int getMaxTitleLengthInStandaloneTables();
/**
- * as per {@link IsisConfiguration.Viewer.Wicket#setMaxTitleLengthInParentedTables(int)}
+ * as per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setMaxTitleLengthInParentedTables(int)}
*/
int getMaxTitleLengthInParentedTables();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setDatePattern(String)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setDatePattern(String)}
*/
String getDatePattern();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setDateTimePattern(String)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setDateTimePattern(String)}
*/
String getDateTimePattern();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setReplaceDisabledTagWithReadonlyTag(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setReplaceDisabledTagWithReadonlyTag(boolean)}
*/
boolean isReplaceDisabledTagWithReadonlyTag();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setPreventDoubleClickForFormSubmit(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setPreventDoubleClickForFormSubmit(boolean)}
*/
boolean isPreventDoubleClickForFormSubmit();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setPreventDoubleClickForNoArgAction(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setPreventDoubleClickForNoArgAction(boolean)}
*/
boolean isPreventDoubleClickForNoArgAction();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setUseIndicatorForFormSubmit(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setUseIndicatorForFormSubmit(boolean)}
*/
boolean isUseIndicatorForFormSubmit();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setUseIndicatorForNoArgAction(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setUseIndicatorForNoArgAction(boolean)}
*/
boolean isUseIndicatorForNoArgAction();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setPromptStyle(PromptStyle)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setPromptStyle(PromptStyle)}
*/
PromptStyle getPromptStyle();
/**
- * As per {@link IsisConfiguration.Viewer.Wicket#setRedirectEvenIfSameObject(boolean)}
+ * As per {@link org.apache.isis.core.config.IsisConfiguration.Viewer.Wicket#setRedirectEvenIfSameObject(boolean)}
*/
boolean isRedirectEvenIfSameObject();
diff --git a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ActionModel.java b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ActionModel.java
index bede80a..7f5c1ed 100644
--- a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ActionModel.java
+++ b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ActionModel.java
@@ -226,7 +226,7 @@ implements FormUiModel, FormExecutorContext, BookmarkableModel {
/** Resets arguments to their fixed point default values
- * @see {@link PendingParameterModelHead#defaults()}
+ * @see PendingParameterModelHead#defaults()
*/
public void clearArguments() {
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersPanel.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersPanel.java
index 3f47d0b..b0c7ffb 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersPanel.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersPanel.java
@@ -34,11 +34,8 @@ import lombok.Setter;
/**
* {@link PanelAbstract Panel} representing an action invocation, backed by an
* {@link ActionModel}.
- *
* <p>
- * Based on the {@link ActionModel.Mode mode}, will render either parameter
- * dialog or the results.
- *
+ * Will render either parameter dialog or the results.
* <p>
* Corresponding component to edit properties is {@link PropertyEditPanel}.
*/
@@ -91,16 +88,14 @@ public class ActionParametersPanel extends PanelAbstract<ActionModel> {
addOrReplace(header);
- {
+ getComponentFactoryRegistry().addOrReplaceComponent(this, ComponentType.PARAMETERS, getActionModel());
+ getComponentFactoryRegistry().addOrReplaceComponent(header, ComponentType.ENTITY_ICON_AND_TITLE, actionModel
+ .getParentUiModel());
- getComponentFactoryRegistry().addOrReplaceComponent(this, ComponentType.PARAMETERS, getActionModel());
- getComponentFactoryRegistry().addOrReplaceComponent(header, ComponentType.ENTITY_ICON_AND_TITLE, actionModel
- .getParentUiModel());
+ final String actionName = getActionModel().getMetaModel().getName();
+ header.add(new Label(ID_ACTION_NAME, Model.of(actionName)));
- final String actionName = getActionModel().getMetaModel().getName();
- header.add(new Label(ID_ACTION_NAME, Model.of(actionName)));
- }
}
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
index 066f62a..746c20e 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
@@ -848,7 +848,6 @@ implements ScalarModelSubscriber {
/**
* Mandatory hook, used to determine which component to attach feedback to.
- * @return
*/
protected abstract Component getScalarValueComponent();
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
index 57cf4f9..4f24866 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
@@ -61,8 +61,11 @@ import lombok.val;
* their backing model.
*
* <p>
- * Supports the concept of being {@link Rendering#COMPACT} (eg within a table) or
- * {@link Rendering#REGULAR regular} (eg within a form).
+ * Supports the concept of being
+ * {@link org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract.Rendering#COMPACT}
+ * (eg within a table) or
+ * {@link org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract.Rendering#REGULAR regular}
+ * (eg within a form).
* </p>
*
* <p>
@@ -272,8 +275,8 @@ implements TextFieldValueModel.ScalarModelProvider {
/**
* Mandatory hook method to build the component to render the model when in
- * {@link Rendering#COMPACT compact} format.
- *
+ * {@link org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract.Rendering#COMPACT compact}
+ * format.
* <p>
* This default implementation uses a {@link Label}, however it may be overridden if required.
*/
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/primitive/BooleanPanel.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/primitive/BooleanPanel.java
index f3db645..0569c45 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/primitive/BooleanPanel.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/primitive/BooleanPanel.java
@@ -93,7 +93,7 @@ public class BooleanPanel extends ScalarPanelAbstract {
/**
* Mandatory hook method to build the component to render the model when in
- * {@link Rendering#COMPACT compact} format.
+ * {@link org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract.Rendering#COMPACT compact} format.
*/
@Override
protected Component createComponentForCompact() {
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/formcomponent/FormComponentPanelAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/formcomponent/FormComponentPanelAbstract.java
index 08ee78a..ae523d4 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/formcomponent/FormComponentPanelAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/formcomponent/FormComponentPanelAbstract.java
@@ -53,8 +53,6 @@ public abstract class FormComponentPanelAbstract<T> extends FormComponentPanel<T
/**
* For subclasses
- *
- * @return
*/
protected Component addOrReplace(final ComponentType componentType, final IModel<?> model) {
return getComponentFactoryRegistry().addOrReplaceComponent(this, componentType, model);
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/navbar/BrandLogo.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/navbar/BrandLogo.java
index 5611057..1c2b617 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/navbar/BrandLogo.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/navbar/BrandLogo.java
@@ -35,8 +35,8 @@ public class BrandLogo extends WebComponentBase {
/**
* Constructor.
*
- * @param id The component id
- * @param placement
+ * @param id - The component id
+ * @param branding
*/
public BrandLogo(final String id, final BrandingUiModel branding) {
super(id);
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
index 05642e4..f708425 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
@@ -75,8 +75,6 @@ extends PanelBase/*<IModel<X>>*/ {
/**
* For subclasses
- *
- * @return
*/
protected Component addOrReplace(final ComponentType componentType, final IModel<?> model) {
return getComponentFactoryRegistry().addOrReplaceComponent(this, componentType, model);
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/util/SSESupport.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/util/SSESupport.java
index 42039ff..be0666a 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/util/SSESupport.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/util/SSESupport.java
@@ -24,7 +24,8 @@ import org.apache.wicket.request.resource.JavaScriptResourceReference;
/**
* Server-sent events.
*
- * @see https://www.w3schools.com/html/html5_serversentevents.asp
+ * @see <a href="https://www.w3schools.com/html/html5_serversentevents.asp">www.w3schools.com</a>
+ *
*
* @since 2.0
*/
diff --git a/viewers/wicket/viewer/src/main/java/org/apache/isis/viewer/wicket/viewer/integration/AuthenticatedWebSessionForIsis.java b/viewers/wicket/viewer/src/main/java/org/apache/isis/viewer/wicket/viewer/integration/AuthenticatedWebSessionForIsis.java
index b8bf6f3..85bbf59 100644
--- a/viewers/wicket/viewer/src/main/java/org/apache/isis/viewer/wicket/viewer/integration/AuthenticatedWebSessionForIsis.java
+++ b/viewers/wicket/viewer/src/main/java/org/apache/isis/viewer/wicket/viewer/integration/AuthenticatedWebSessionForIsis.java
@@ -180,8 +180,9 @@ implements BreadcrumbModelProvider, BookmarkedPagesModelProvider, HasCommonConte
/**
* This is a no-op if the {@link #getAuthentication() authentication session}'s
- * {@link Authentication#getType() type} is {@link Authentication.Type#EXTERNAL external} (eg as
- * managed by keycloak).
+ * {@link Authentication#getType() type} is
+ * {@link org.apache.isis.core.security.authentication.Authentication.Type#EXTERNAL external}
+ * (eg as managed by keycloak).
*/
public void invalidate() {
if(this.authentication.getType() == Authentication.Type.EXTERNAL) {