You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/27 23:24:00 UTC

[GitHub] [tinkerpop] L0Lmaker opened a new pull request, #1739: Improved pathing changes made for Windows Build Support

L0Lmaker opened a new pull request, #1739:
URL: https://github.com/apache/tinkerpop/pull/1739

   Pathing changes introduced to support the windows build of `gremlin-javascript`, `gremlin-dotnet`, and `gremlint` would make it so that building Tinkerpop or its modules from anywhere other than the Tinkerpop root would not work. 
   
   The changes in this PR would make it so that maven commands such as `install`, `verify`, `compile` and so on would work as expected from outside the root.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] L0Lmaker commented on pull request #1739: Improved pathing changes made for Windows Build Support

Posted by GitBox <gi...@apache.org>.
L0Lmaker commented on PR #1739:
URL: https://github.com/apache/tinkerpop/pull/1739#issuecomment-1170417681

   > Could you however please squash your commits? Would be better to have only one commit here instead of six.
   
   Squashed in commit 6aa0d21a3b9b9ed33825d838e38e182ce15d15f8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] L0Lmaker commented on pull request #1739: Improved pathing changes made for Windows Build Support

Posted by GitBox <gi...@apache.org>.
L0Lmaker commented on PR #1739:
URL: https://github.com/apache/tinkerpop/pull/1739#issuecomment-1170396886

   > I think this is definitely already a good improvement and most of the tests seem to pass this way, but I still run into problems with the Gherkin tests in `gremlin-dotnet` when executed from that directory:
   > 
   > ```shell
   > mvn verify -pl :gremlin-dotnet,:gremlin-dotnet-tests -P gremlin-dotnet -DincludeNeo4j
   > ```
   > 
   > leads to errors such as:
   > 
   > ```
   > java.lang.IllegalStateException: data/tinkerpop-modern.xml does not exist
   > ```
   > 
   > so it looks like more paths need to be changed to get full support for building and testing from other paths than the project's root.
   
   I am able to reproduce the same error. I checked with an older version of the code without the windows build support changes in commit 38a3bd7 on `3.5` and the same error exists there as well. 
   
   Should I document this in [TINKERPOP-2760](https://issues.apache.org/jira/browse/TINKERPOP-2760), which I made for pending windows tasks or create a new ticket for it?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] FlorianHockmann merged pull request #1739: Improved pathing changes made for Windows Build Support

Posted by GitBox <gi...@apache.org>.
FlorianHockmann merged PR #1739:
URL: https://github.com/apache/tinkerpop/pull/1739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] lyndonbauto commented on pull request #1739: Improved pathing changes made for Windows Build Support

Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1739:
URL: https://github.com/apache/tinkerpop/pull/1739#issuecomment-1168208697

   LGTM
   VOTE+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] L0Lmaker commented on pull request #1739: Improved pathing changes made for Windows Build Support

Posted by GitBox <gi...@apache.org>.
L0Lmaker commented on PR #1739:
URL: https://github.com/apache/tinkerpop/pull/1739#issuecomment-1176777419

   > If it's not specific to Windows, then I think that a separate ticket makes more sense.
   
   No, it is not specific to Windows, I will create a new ticket for it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org