[GitHub] wido commented on a change in pull request #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #2226: CLOUDSTACK-10012: Towards CloudStack fat jar
URL: https://github.com/apache/cloudstack/pull/2226#discussion_r148774036
 
 

 ##########
 File path: client/conf/server.properties.in
 ##########
 @@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# The binding interface used by the management server
+bind.interface=0.0.0.0
 
 Review comment:
   Can we change *0.0.0.0* to *::* so that it listens on IPv6 by default?
   
   I tested this on Ubuntu 16.04 and works fine:
   
   <pre>
   root@cloudstack-man-test:~# curl -I http://127.0.0.1:8080/client/
   HTTP/1.1 200 OK
   Content-Type: text/html
   ETag: W/"114557-1499056602000
   Content-Length: 114557
   Server: Jetty(9.2.z-SNAPSHOT)
   
   root@cloudstack-man-test:~# curl -I http://[::1]:8080/client/
   HTTP/1.1 200 OK
   Content-Type: text/html
   ETag: W/"114557-1499056602000
   Content-Length: 114557
   Server: Jetty(9.2.z-SNAPSHOT)
   
   root@cloudstack-man-test:~#
   </pre>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services