Re: cvs commit:cocoon-2.0/src/java/org/apache/cocoon/transformation SQLTransformer.java

[Pier Fumagalli <pi...@betaversion.org>]

"Carsten Ziegeler" <cz...@s-und-n.de> wrote:

> 
> 
>>> Hmmm... If you need it, somewhere I have a "collapseWhitespace"
>>> implementation that we use... It's equivalent to trim plus replaces n
>>> occurrences of Char.isWhitespace(x) with a single space char...
>>> 
>> Great! I guess that's exactly what we need.
>> Ehm, just one thought: Is it ok to collapse all whitespaces of the
>> sql query? Or should we only collapse whitespaces outside of " or ',
>> so for example a statement like   text = "ggg  hhh  yyy", should
>> not be collapsed to text = "ggg hhh yyy". This is really more
>> complicated than it should.

Nope, I don't escape quotes! :-)

> Luca just suggested to simply use a
> String query = StringUtils.replace(sb.toString(), "\r", " ", -1);
> 
> which could solve the problems as well.

Shouldn't it raise the same problem of when stuff is in "" strings???

    Pier

Re: cvscommit:cocoon-2.0/src/java/org/apache/cocoon/transformationSQLTransforme r.java

[Pier Fumagalli <pi...@betaversion.org>]

"Carsten Ziegeler" <cz...@s-und-n.de> wrote:

> Pier Fumagalli wrote:
>>> Luca just suggested to simply use a
>>> String query = StringUtils.replace(sb.toString(), "\r", " ", -1);
>>> 
>>> which could solve the problems as well.
>> 
>> Shouldn't it raise the same problem of when stuff is in "" strings???
>> 
> Yes, it should, but I assume that \r is never alone; it always comes
> with a \n and therefore only removing \r should be ok, I guess.

That if you don't own a Macintosh, of course...

    Pier (who owns a Macintosh)

RE: cvscommit:cocoon-2.0/src/java/org/apache/cocoon/transformationSQLTransformer.java

[Carsten Ziegeler <cz...@s-und-n.de>]

Pier Fumagalli wrote:
> > Luca just suggested to simply use a
> > String query = StringUtils.replace(sb.toString(), "\r", " ", -1);
> > 
> > which could solve the problems as well.
> 
> Shouldn't it raise the same problem of when stuff is in "" strings???
> 
Yes, it should, but I assume that \r is never alone; it always comes
with a \n and therefore only removing \r should be ok, I guess.

Carsten