You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Kasun Indrasiri <ka...@gmail.com> on 2011/12/13 12:26:30 UTC

Can we remove HTTPCORE-193 patch on synapse patches?

Hi all,

At the moment we have patches synapse with
httpcore-nio-4.0-patch-httpcore-193.jar in modules/patches[1].
Synapse trunk uses http core nio version 4.1 and if this issue is fixed on
4.1, then we can simple remove this patch from synapse and go on with 4.1
only.


[1] https://issues.apache.org/jira/browse/HTTPCORE-193

-- 
Kasun Indrasiri
Associate Technical Lead,
WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
Blog : http://kasunpanorama.blogspot.com/

Re: Can we remove HTTPCORE-193 patch on synapse patches?

Posted by Sadeep Jayasumana <ga...@gmail.com>.
Hi,

IMO Synapse should use the latest HttpCore release version (4.1.3, AFAIK)
for the next release because otherwise it will miss many important bug
fixes in HttpCore. In particular, Synapse certainly need bug fixes reported
by [1] and [2] which are not included in HttpCore 4.1

[1] https://issues.apache.org/jira/browse/HTTPCORE-260
[1] https://issues.apache.org/jira/browse/HTTPCORE-266

Thanks,
Sadeep

On Tue, Dec 13, 2011 at 4:56 PM, Kasun Indrasiri <ka...@gmail.com> wrote:

> Hi all,
>
> At the moment we have patches synapse with
> httpcore-nio-4.0-patch-httpcore-193.jar in modules/patches[1].
> Synapse trunk uses http core nio version 4.1 and if this issue is fixed on
> 4.1, then we can simple remove this patch from synapse and go on with 4.1
> only.
>
>
> [1] https://issues.apache.org/jira/browse/HTTPCORE-193
>
> --
> Kasun Indrasiri
> Associate Technical Lead,
> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> Blog : http://kasunpanorama.blogspot.com/
>
>


-- 

Sadeep Jayasumana****

Email: gayansadeep@gmail.com****

Phone: +94-77-2266507

Re: Can we remove HTTPCORE-193 patch on synapse patches?

Posted by Hiranya Jayathilaka <hi...@gmail.com>.
+1

Thanks,
Hiranya

On Tue, Dec 13, 2011 at 6:17 PM, Ruwan Linton <ru...@gmail.com>wrote:

> +1, this patch shouldn't be needed anymore, actually it could be risky to
> have this patch with 4.1 as this patch overrides possible fixes in the 4.1.
> :-(
>
> Thanks,
> Ruwan
>
> On Tue, Dec 13, 2011 at 4:56 PM, Kasun Indrasiri <ka...@gmail.com>wrote:
>
>> Hi all,
>>
>> At the moment we have patches synapse with
>> httpcore-nio-4.0-patch-httpcore-193.jar in modules/patches[1].
>> Synapse trunk uses http core nio version 4.1 and if this issue is fixed
>> on 4.1, then we can simple remove this patch from synapse and go on with
>> 4.1 only.
>>
>>
>> [1] https://issues.apache.org/jira/browse/HTTPCORE-193
>>
>> --
>> Kasun Indrasiri
>> Associate Technical Lead,
>> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>> Blog : http://kasunpanorama.blogspot.com/
>>
>>
>
>
> --
> Ruwan Linton
> Member, Apache Software Foundation; http://www.apache.org
> Director of Engineering; http://adroitlogic.org
>
> phone: +94 11 282 7532
> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
> blog: http://blog.ruwan.org
> linkedin: http://www.linkedin.com/in/ruwanlinton
> google: http://www.google.com/profiles/ruwan.linton
> tweet: http://twitter.com/ruwanlinton
>
>


-- 
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.;  http://wso2.org
E-mail: hiranya@wso2.com;  Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com

Re: Can we remove HTTPCORE-193 patch on synapse patches?

Posted by Ruwan Linton <ru...@gmail.com>.
+1, this patch shouldn't be needed anymore, actually it could be risky to
have this patch with 4.1 as this patch overrides possible fixes in the 4.1.
:-(

Thanks,
Ruwan

On Tue, Dec 13, 2011 at 4:56 PM, Kasun Indrasiri <ka...@gmail.com> wrote:

> Hi all,
>
> At the moment we have patches synapse with
> httpcore-nio-4.0-patch-httpcore-193.jar in modules/patches[1].
> Synapse trunk uses http core nio version 4.1 and if this issue is fixed on
> 4.1, then we can simple remove this patch from synapse and go on with 4.1
> only.
>
>
> [1] https://issues.apache.org/jira/browse/HTTPCORE-193
>
> --
> Kasun Indrasiri
> Associate Technical Lead,
> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> Blog : http://kasunpanorama.blogspot.com/
>
>


-- 
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org

phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton