You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 04:26:05 UTC

[GitHub] [spark] xuanyuanking opened a new pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

xuanyuanking opened a new pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464
 
 
   ### What changes were proposed in this pull request?
   Follow up work for SPARK-29864, reference the config  `spark.sql.legacy.fromDayTimeString.enabled` in error message.
   
   ### Why are the changes needed?
   For better usability.
   
   ### Does this PR introduce any user-facing change?
   No.
   
   ### How was this patch tested?
   Existing tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582509269
 
 
   **[Test build #117930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117930/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582543914
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117934/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#discussion_r375078074
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
 ##########
 @@ -195,7 +198,8 @@ object IntervalUtils {
     require(input != null, "Interval day-time string must be not null")
     assert(input.length == input.trim.length)
     val m = dayTimePatternLegacy.pattern.matcher(input)
-    require(m.matches, s"Interval string must match day-time format of 'd h:m:s.n': $input")
+    require(m.matches, s"Interval string must match day-time format of 'd h:m:s.n': $input" +
 
 Review comment:
   nit: `$input$fallbackNotice"` or remove space in `fallbackNotice` and write `$input $fallbackNotice"`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235344
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235059
 
 
   **[Test build #117889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117889/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582373482
 
 
   **[Test build #117930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117930/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235349
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22651/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582543914
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117934/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582371479
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22693/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582510366
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582510384
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117930/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582371466
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582398297
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22697/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582371466
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xuanyuanking commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#discussion_r375241952
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
 ##########
 @@ -195,7 +198,8 @@ object IntervalUtils {
     require(input != null, "Interval day-time string must be not null")
     assert(input.length == input.trim.length)
     val m = dayTimePatternLegacy.pattern.matcher(input)
-    require(m.matches, s"Interval string must match day-time format of 'd h:m:s.n': $input")
+    require(m.matches, s"Interval string must match day-time format of 'd h:m:s.n': $input" +
 
 Review comment:
   Thanks, done in 7140a71

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582397821
 
 
   **[Test build #117934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117934/testReport)** for PR 27464 at commit [`7140a71`](https://github.com/apache/spark/commit/7140a7149dc2516a683b982a1c6a04327c6c1207).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582287888
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582287888
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582510384
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117930/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582371017
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#discussion_r375077658
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
 ##########
 @@ -176,6 +176,9 @@ object IntervalUtils {
   private val dayTimePatternLegacy =
     "^([+|-])?((\\d+) )?((\\d+):)?(\\d+):(\\d+)(\\.(\\d+))?$".r
 
+  private val fallbackNotice = ", set spark.sql.legacy.fromDayTimeString.enabled to true " +
 
 Review comment:
   Please, use `${SQLConf.LEGACY_FROM_DAYTIME_STRING.key}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235059
 
 
   **[Test build #117889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117889/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582371479
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22693/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582543901
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582397821
 
 
   **[Test build #117934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117934/testReport)** for PR 27464 at commit [`7140a71`](https://github.com/apache/spark/commit/7140a7149dc2516a683b982a1c6a04327c6c1207).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582398285
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xuanyuanking commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#discussion_r375241884
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
 ##########
 @@ -176,6 +176,9 @@ object IntervalUtils {
   private val dayTimePatternLegacy =
     "^([+|-])?((\\d+) )?((\\d+):)?(\\d+):(\\d+)(\\.(\\d+))?$".r
 
+  private val fallbackNotice = ", set spark.sql.legacy.fromDayTimeString.enabled to true " +
 
 Review comment:
   Thanks, done in 7140a71

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582287898
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117889/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582542962
 
 
   **[Test build #117934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117934/testReport)** for PR 27464 at commit [`7140a71`](https://github.com/apache/spark/commit/7140a7149dc2516a683b982a1c6a04327c6c1207).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582398297
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22697/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582398285
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582287898
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117889/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582373482
 
 
   **[Test build #117930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117930/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235344
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582287641
 
 
   **[Test build #117889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117889/testReport)** for PR 27464 at commit [`f934451`](https://github.com/apache/spark/commit/f934451276ebc0b6dbf694cdd43cee21d1bd0626).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582543901
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582510366
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582235349
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22651/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xuanyuanking commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message

Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on issue #27464: [SPARK-29864][SQL][FOLLOWUP] Reference the config for the old behavior in error message
URL: https://github.com/apache/spark/pull/27464#issuecomment-582751406
 
 
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org