You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 08:33:49 UTC
[GitHub] [flink] PatrickRen opened a new pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
PatrickRen opened a new pull request #14789:
URL: https://github.com/apache/flink/pull/14789
## What is the purpose of the change
This pull request fixes bug in ```KafkaSourceEnumerator``` that only sending ```NoMoreSplitsEvent``` to readers assigned with splits, which will lead to job hanging forever even if the source is bounded.
## Brief change log
*(for example:)*
- Signal ```NoMoreSplitsEvent``` to reader in ```addReader``` and ```addSplitsBack``` instead of during split assigning
- Add IT case for testing cases that a reader is not assigned with any splits
- Fix a typo in JavaDoc of SplitEnumeratorContext#callAsync
## Verifying this change
This change added tests and can be verified as follows:
- *Add IT case for testing cases that a reader is not assigned with any splits*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c0d898a9708aca8db47af405a8b8afb05dbf8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c0d898a9708aca8db47af405a8b8afb05dbf8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592)
* 0ba04e69639fdc9ec208421163413b9a711c8d31 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768890886
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87 (Fri May 28 08:58:25 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #14789:
URL: https://github.com/apache/flink/pull/14789#discussion_r572647867
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumerator.java
##########
@@ -276,16 +284,21 @@ private void assignPendingPartitionSplits() {
.addAll(newPartitionSplits);
// Clear the pending splits for the reader owner.
pendingPartitionSplitAssignment.remove(readerOwner);
- // Sends NoMoreSplitsEvent to the readers if there is no more partition splits
- // to be assigned.
- if (noMoreNewPartitionSplits) {
- LOG.debug(
- "No more KafkaPartitionSplits to assign. Sending NoMoreSplitsEvent to the readers "
- + "in consumer group {}.",
- consumerGroupId);
- context.signalNoMoreSplits(readerOwner);
- }
});
+ if (noMoreNewPartitionSplits) {
+ signalNoMoreSplitsToNotNotifiedReaders();
+ }
+ }
+
+ private void signalNoMoreSplitsToNotNotifiedReaders() {
+ context.registeredReaders()
+ .forEach(
+ (readerId, ignore) -> {
+ if (!finishedReaders.contains(readerId)) {
+ context.signalNoMoreSplits(readerId);
+ finishedReaders.add(readerId);
Review comment:
What happens if the readers failover? Do we assume that the source readers remember the reception of `NoMoreSplitsEvent`?
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumerator.java
##########
@@ -64,6 +64,8 @@
private final Properties properties;
private final long partitionDiscoveryIntervalMs;
private final SplitEnumeratorContext<KafkaPartitionSplit> context;
+ private volatile boolean partitionDiscoveryFinished = false;
Review comment:
It seems that we can just reuse the `noMoreNewPartitionSplits` flag.
- If the periodic partition discovery is disabled, then after the first partition discovery is done, set the `noMoreNewPartitionSplits` flag to true. The subsequent `assignPendingPartitionSplits` will just send the `NoMoreSplitsEvent` to all the readers. As long as the flag is set in the main thread, the readers who registered before the first partition discovery is done will not receive duplicate `NoMoreSplitsEvent` in this case.
- Otherwise, the `noMoreNewPartitionSplits` will always be set to false, and no `NoMoreSplitsEvent` will be sent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
}, {
"hash" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734)
* a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-813769577
Already fixed by dc3d0702087c8681435761eed7f2aa9161b09540.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768890886
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 75c0d898a9708aca8db47af405a8b8afb05dbf8b (Thu Jan 28 08:36:22 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21159).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen closed pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
PatrickRen closed pull request #14789:
URL: https://github.com/apache/flink/pull/14789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c0d898a9708aca8db47af405a8b8afb05dbf8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c0d898a9708aca8db47af405a8b8afb05dbf8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-770181843
I noticed a race condition in my modification: the variable ```noMoreNewPartitionSplits``` may not be set when ```addReader``` is invoked because they are in different threads, which will cause not sending NoMoreSplitsEvent to some readers. I'll make another commit later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-782547796
@becketqin Thank you~ I changed my implementation and made another commit.
Now ```NoMoreSplitsEvent``` will be sent in ```addReader()``` so all readers will be notified and we don't need to "remember" readers that have been signaled.
There is possibility that ```addReader()``` could be invoked before the first partition discovery and split assignment, so I add a set called ```finishingReaders``` for tracking these early-added readers, and signal ```MoMoreSplitsEvent``` to them later after the first discovery and assignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
}, {
"hash" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13515",
"triggerID" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734)
* a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c0d898a9708aca8db47af405a8b8afb05dbf8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592)
* 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12592",
"triggerID" : "75c0d898a9708aca8db47af405a8b8afb05dbf8b",
"triggerType" : "PUSH"
}, {
"hash" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12734",
"triggerID" : "0ba04e69639fdc9ec208421163413b9a711c8d31",
"triggerType" : "PUSH"
}, {
"hash" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13515",
"triggerID" : "a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org