You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/11/05 14:31:30 UTC
[PR] Improve selectiveness of selective checks for "always/tests" case [airflow]
potiuk opened a new pull request, #35458:
URL: https://github.com/apache/airflow/pull/35458
When we decide which tests should be run we err on a safe side and when we see that some files were modified that we cannot classify to specific providers, API, CLI, WWW area, we err on a safe side and assume that we should run all tests (This is called a "core/other modified" case. The assumption here is that modificiation of any of the core code or some of the auxiliary utils might affect everyone else.
However - we can safely assume that if only "tests/always" files have been modified, then we can remove them from the list - because those tests will anyhow will be executed and changing those tests should have no impact on other tests. Those tests are ALWAYS executed. iThis will - in some cases - avoid running full test suite when we really only run a small subset of those.
This was the case for #35457 where it run full test suite, but really only "Always Providers[common.io]" were needed.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve selectiveness of selective checks for "always/tests" case [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35458:
URL: https://github.com/apache/airflow/pull/35458#discussion_r1382587390
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -676,7 +700,7 @@ def test_expected_output_full_tests_needed(
),
],
)
-def test_expected_output_pull_request_v2_3(
+def test_expected_output_pull_request_v2_7(
Review Comment:
It's unrelated, but I noticed that we have not updated the branch to latest - it does not matter, but might be misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve selectiveness of selective checks for "always/tests" case [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #35458:
URL: https://github.com/apache/airflow/pull/35458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org