[GitHub] [couchdb-smoosh] iilyak commented on a change in pull request #4: Switch to UTC

[GitBox <gi...@apache.org>]

iilyak commented on a change in pull request #4: Switch to UTC
URL: https://github.com/apache/couchdb-smoosh/pull/4#discussion_r357626823
 
 

 ##########
 File path: src/smoosh_utils.erl
 ##########
 @@ -60,20 +60,15 @@ ignore_db(DbName) when is_list(DbName) ->
 ignore_db(Db) ->
     ignore_db(couch_db:name(Db)).
 
-in_allowed_window(Channel) ->
+in_allowed_window(Time, Channel) ->
     From = parse_time(get(Channel, "from"), {00, 00}),
     To = parse_time(get(Channel, "to"), {24, 00}),
-    in_allowed_window(From, To).
-
-in_allowed_window(From, To) ->
-    {HH, MM, _} = erlang:time(),
 
 Review comment:
   Alternative solution 1: Just update this line to `{_, {HH, MM, _}} = calendar:universal_time(),`. We could mock calendar:universal_time to test both conditions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services