[jira] [Commented] (KAFKA-3190) KafkaProducer should not invoke callback in send()

["Ewen Cheslack-Postava (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823415#comment-15823415 ] 

Ewen Cheslack-Postava commented on KAFKA-3190:
----------------------------------------------

[~becket_qin] Do you want to revisit this? It's been marked critical for ages -- looks like it got bumped out of 0.10.0.0 and has just been passed along to each subsequent version since then.

> KafkaProducer should not invoke callback in send()
> --------------------------------------------------
>
>                 Key: KAFKA-3190
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3190
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients, producer 
>    Affects Versions: 0.9.0.0
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>            Priority: Critical
>             Fix For: 0.10.2.0
>
>
> Currently KafkaProducer will invoke callback.onComplete() if it receives an ApiException during send(). This breaks the guarantee that callback will be invoked in order. It seems ApiException in send() only comes from metadata refresh. If so, we can probably simply throw it instead of invoking callback().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)