[cordova-plugin-inappbrowser] branch master updated: (iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git


The following commit(s) were added to refs/heads/master by this push:
     new 388e3f6  (iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)
388e3f6 is described below

commit 388e3f6ae74b7c59fee43e360427ab73325f9a77
Author: Dave Alden <dp...@gmail.com>
AuthorDate: Mon Feb 11 23:14:18 2019 +0000

    (iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)
---
 src/ios/CDVWKInAppBrowser.m | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/ios/CDVWKInAppBrowser.m b/src/ios/CDVWKInAppBrowser.m
index 7deb6d0..6364f4f 100644
--- a/src/ios/CDVWKInAppBrowser.m
+++ b/src/ios/CDVWKInAppBrowser.m
@@ -573,9 +573,9 @@ static CDVWKInAppBrowser* instance = nil;
     }
     
     if(shouldStart){
-        // Fix GH-417: Handle non-default target attribute
-        // Based on https://stackoverflow.com/a/25853806/777265
-        if (!navigationAction.targetFrame.isMainFrame){
+        // Fix GH-417 & GH-424: Handle non-default target attribute
+        // Based on https://stackoverflow.com/a/25713070/777265
+        if (!navigationAction.targetFrame){
             [theWebView loadRequest:navigationAction.request];
             decisionHandler(WKNavigationActionPolicyCancel);
         }else{


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org