You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "ArnavBalyan (via GitHub)" <gi...@apache.org> on 2025/09/29 05:48:56 UTC

[PR] update [parquet-java]

ArnavBalyan opened a new pull request, #3339:
URL: https://github.com/apache/parquet-java/pull/3339

   ### Rationale for this change
    - Currently show bloom filter does not support encrypted parquet files.
    - Support reading and showing bloom filter metadata for encrypted files
   
   ### Are these changes tested?
    - Yes
   
   ### Are there any user-facing changes?
    - Yes
   
   Closes: #3338


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for Parquet CLI commands [parquet-java]

Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky merged PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for show bloom filter command [parquet-java]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#issuecomment-3345084327

   cc @gszadovszky @shangxinli could you pls take a look thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for bloom filter command [parquet-java]

Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on code in PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#discussion_r2386854650


##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
       required = true)
   List<String> testValues;
 
+  @Parameter(
+      names = {"--footer-key"},
+      description = "Footer key for encrypted files (hex string, 16/24/32 bytes)")
+  String footerKeyHex;
+
+  @Parameter(
+      names = {"--column-key"},
+      description = "Column key for encrypted files (hex string, 16/24/32 bytes)")
+  String columnKeyHex;

Review Comment:
   Cannot the column key be different for each column?



##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
       required = true)
   List<String> testValues;
 
+  @Parameter(
+      names = {"--footer-key"},
+      description = "Footer key for encrypted files (hex string, 16/24/32 bytes)")
+  String footerKeyHex;
+
+  @Parameter(
+      names = {"--column-key"},
+      description = "Column key for encrypted files (hex string, 16/24/32 bytes)")
+  String columnKeyHex;
+

Review Comment:
   @ArnavBalyan, is it only bloom filters? Shouldn't we add this at a more common level, so other commands would also benefit from it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for Parquet CLI commands [parquet-java]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on code in PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#discussion_r2388207791


##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
       required = true)
   List<String> testValues;
 
+  @Parameter(
+      names = {"--footer-key"},
+      description = "Footer key for encrypted files (hex string, 16/24/32 bytes)")
+  String footerKeyHex;
+
+  @Parameter(
+      names = {"--column-key"},
+      description = "Column key for encrypted files (hex string, 16/24/32 bytes)")
+  String columnKeyHex;
+

Review Comment:
   Moved this to base, any CLI command can leverage this. I tested and supported 3 commands for now. 
   Will add UTs and support for the remaining CLI commands shortly. Each command should now be able to read without duplication



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for Parquet CLI commands [parquet-java]

Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#issuecomment-3379370463

   > cc @gszadovszky could you please merge if all looks good thanks!
   
   Thanks for pinging, sorry for the delay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for Parquet CLI commands [parquet-java]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on code in PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#discussion_r2388211157


##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
       required = true)
   List<String> testValues;
 
+  @Parameter(
+      names = {"--footer-key"},
+      description = "Footer key for encrypted files (hex string, 16/24/32 bytes)")
+  String footerKeyHex;
+
+  @Parameter(
+      names = {"--column-key"},
+      description = "Column key for encrypted files (hex string, 16/24/32 bytes)")
+  String columnKeyHex;

Review Comment:
   Ah good point, updated to follow the existing key format within PropertiesDrivenCryptoFactory



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3338: Support encrypted files for Parquet CLI commands [parquet-java]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#issuecomment-3378063470

   cc @gszadovszky could you please merge if all looks good thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org