You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 04:23:14 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
jorgecarleitao opened a new pull request #9312:
URL: https://github.com/apache/arrow/pull/9312
This PR aims at splitting the large `expressions.rs` module in parts, thereby making it easier to navigate and work with.
No backward incompatible changes are expected from this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (84bce69) into [master](https://codecov.io/gh/apache/arrow/commit/10f4ada2bbad0770e422e5d70071e991ab3f5f57?el=desc) (10f4ada) will **increase** coverage by `0.00%`.
> The diff coverage is `79.18%`.
[](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9312 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 215 219 +4
Lines 52949 52949
=======================================
+ Hits 43335 43336 +1
+ Misses 9614 9613 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...datafusion/src/physical\_plan/expressions/column.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvbHVtbi5ycw==) | `70.00% <70.00%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/not.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25vdC5ycw==) | `70.83% <70.83%> (ø)` | |
| [...tafusion/src/physical\_plan/expressions/coercion.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvZXJjaW9uLnJz) | `78.65% <78.65%> (ø)` | |
| [...t/datafusion/src/physical\_plan/expressions/cast.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2Nhc3QucnM=) | `88.13% <88.13%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/mod.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL21vZC5ycw==) | `81.43% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=footer). Last update [10f4ada...84bce69](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766530454
https://issues.apache.org/jira/browse/ARROW-11369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9312:
URL: https://github.com/apache/arrow/pull/9312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766578945
The clippy error is unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (84bce69) into [master](https://codecov.io/gh/apache/arrow/commit/10f4ada2bbad0770e422e5d70071e991ab3f5f57?el=desc) (10f4ada) will **increase** coverage by `0.00%`.
> The diff coverage is `79.18%`.
[](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9312 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 215 219 +4
Lines 52949 52949
=======================================
+ Hits 43335 43336 +1
+ Misses 9614 9613 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...datafusion/src/physical\_plan/expressions/column.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvbHVtbi5ycw==) | `70.00% <70.00%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/not.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25vdC5ycw==) | `70.83% <70.83%> (ø)` | |
| [...tafusion/src/physical\_plan/expressions/coercion.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvZXJjaW9uLnJz) | `78.65% <78.65%> (ø)` | |
| [...t/datafusion/src/physical\_plan/expressions/cast.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2Nhc3QucnM=) | `88.13% <88.13%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/mod.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL21vZC5ycw==) | `81.43% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=footer). Last update [10f4ada...84bce69](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766530454
https://issues.apache.org/jira/browse/ARROW-11369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-770197594
🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766765773
Clippy error is addressed here: https://github.com/apache/arrow/pull/9314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766578945
The clippy error is unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (446d5ad) into [master](https://codecov.io/gh/apache/arrow/commit/437c8c944acb3479b76804f041f5f8cbce309fa7?el=desc) (437c8c9) will **increase** coverage by `0.00%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9312 +/- ##
=======================================
Coverage 81.88% 81.89%
=======================================
Files 215 230 +15
Lines 52988 53004 +16
=======================================
+ Hits 43391 43407 +16
Misses 9597 9597
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tafusion/src/physical\_plan/expressions/negative.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25lZ2F0aXZlLnJz) | `42.85% <42.85%> (ø)` | |
| [...datafusion/src/physical\_plan/expressions/column.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvbHVtbi5ycw==) | `70.00% <70.00%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/not.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25vdC5ycw==) | `70.83% <70.83%> (ø)` | |
| [...usion/src/physical\_plan/expressions/is\_not\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX25vdF9udWxsLnJz) | `72.41% <72.41%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/is\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX251bGwucnM=) | `72.41% <72.41%> (ø)` | |
| [...t/datafusion/src/physical\_plan/expressions/case.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2Nhc2UucnM=) | `73.29% <73.29%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/in\_list.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2luX2xpc3QucnM=) | `75.37% <75.37%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/sum.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL3N1bS5ycw==) | `78.28% <78.28%> (ø)` | |
| [...tafusion/src/physical\_plan/expressions/coercion.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvZXJjaW9uLnJz) | `78.65% <78.65%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/average.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2F2ZXJhZ2UucnM=) | `83.78% <83.78%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=footer). Last update [437c8c9...a2d5b8e](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (94905f8) into [master](https://codecov.io/gh/apache/arrow/commit/3e47777441795c1970a22f6bad103da3e867dc98?el=desc) (3e47777) will **increase** coverage by `0.00%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9312 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 215 230 +15
Lines 52988 53004 +16
=======================================
+ Hits 43392 43408 +16
Misses 9596 9596
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tafusion/src/physical\_plan/expressions/negative.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25lZ2F0aXZlLnJz) | `42.85% <42.85%> (ø)` | |
| [...datafusion/src/physical\_plan/expressions/column.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvbHVtbi5ycw==) | `70.00% <70.00%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/not.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25vdC5ycw==) | `70.83% <70.83%> (ø)` | |
| [...usion/src/physical\_plan/expressions/is\_not\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX25vdF9udWxsLnJz) | `72.41% <72.41%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/is\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX251bGwucnM=) | `72.41% <72.41%> (ø)` | |
| [...t/datafusion/src/physical\_plan/expressions/case.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2Nhc2UucnM=) | `73.29% <73.29%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/in\_list.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2luX2xpc3QucnM=) | `75.37% <75.37%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/sum.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL3N1bS5ycw==) | `78.28% <78.28%> (ø)` | |
| [...tafusion/src/physical\_plan/expressions/coercion.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvZXJjaW9uLnJz) | `78.65% <78.65%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/average.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2F2ZXJhZ2UucnM=) | `83.78% <83.78%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=footer). Last update [d238279...94905f8](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-767183483
Thanks @alamb and @jorgecarleitao . Good idea. I'll rebase and apply these changes. I think the next work will be to address the signatures so I'll be starting work again tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (e1cf992) into [master](https://codecov.io/gh/apache/arrow/commit/10f4ada2bbad0770e422e5d70071e991ab3f5f57?el=desc) (10f4ada) will **increase** coverage by `0.00%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9312 +/- ##
=======================================
Coverage 81.84% 81.85%
=======================================
Files 215 230 +15
Lines 52949 52965 +16
=======================================
+ Hits 43335 43352 +17
+ Misses 9614 9613 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tafusion/src/physical\_plan/expressions/negative.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25lZ2F0aXZlLnJz) | `42.85% <42.85%> (ø)` | |
| [...datafusion/src/physical\_plan/expressions/column.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvbHVtbi5ycw==) | `70.00% <70.00%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/not.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL25vdC5ycw==) | `70.83% <70.83%> (ø)` | |
| [...usion/src/physical\_plan/expressions/is\_not\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX25vdF9udWxsLnJz) | `72.41% <72.41%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/is\_null.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2lzX251bGwucnM=) | `72.41% <72.41%> (ø)` | |
| [...t/datafusion/src/physical\_plan/expressions/case.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2Nhc2UucnM=) | `73.29% <73.29%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/in\_list.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2luX2xpc3QucnM=) | `75.37% <75.37%> (ø)` | |
| [...st/datafusion/src/physical\_plan/expressions/sum.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL3N1bS5ycw==) | `78.28% <78.28%> (ø)` | |
| [...tafusion/src/physical\_plan/expressions/coercion.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvZXJjaW9uLnJz) | `78.65% <78.65%> (ø)` | |
| [...atafusion/src/physical\_plan/expressions/average.rs](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2F2ZXJhZ2UucnM=) | `83.78% <83.78%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/arrow/pull/9312/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=footer). Last update [10f4ada...e1cf992](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-767183483
Thanks @alamb and @jorgecarleitao . Good idea. I'll rebase and apply these changes. I think the next work will be to address the signatures so I'll be starting work again tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766765773
Clippy error is addressed here: https://github.com/apache/arrow/pull/9314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org