You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/31 18:00:51 UTC
Re: Review Request 55727: Checkpoint and track docker image layer
sizes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------
(Updated May 31, 2017, 6 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Rebase and merge layers metrics.
Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893
Repository: mesos
Description (updated)
-------
This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers.
5. a counter for number of layers pulled
6. a gauge for total number of layers
7. a timer for pull latency distribution in the last hour
Tests to be added later. Sending out review for earlier feedback.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542
Diff: https://reviews.apache.org/r/55727/diff/3/
Changes: https://reviews.apache.org/r/55727/diff/2-3/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 55727: Checkpoint and track docker image layer
sizes.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------
(Updated Nov. 16, 2017, 5:43 p.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893
Repository: mesos
Description
-------
This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers
asynchronously without blocking `recover()`;
5. a counter for number of layers pulled;
6. a gauge for total number of layers;
7. a timer for pull latency distribution in the last hour.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542
Diff: https://reviews.apache.org/r/55727/diff/4/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 55727: Checkpoint and track docker image layer
sizes.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------
(Updated June 1, 2017, 8:38 a.m.)
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Changes
-------
Fix recover case for upgrade.
Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893
Repository: mesos
Description (updated)
-------
This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers
asynchronously without blocking `recover()`;
5. a counter for number of layers pulled;
6. a gauge for total number of layers;
7. a timer for pull latency distribution in the last hour.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542
Diff: https://reviews.apache.org/r/55727/diff/4/
Changes: https://reviews.apache.org/r/55727/diff/3-4/
Testing
-------
Thanks,
Zhitao Li