You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/24 09:11:58 UTC
[GitHub] [incubator-livy] codecov-io commented on issue #231:
[LIVY-356][SERVER]Add LDAP authentication for livy-server.
codecov-io commented on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-534468593
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=h1) Report
> Merging [#231](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/4de6258aed7cbaff4a5909fe0d9db79fe869c46f?src=pr&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `50.39%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-livy/pull/231/graphs/tree.svg?width=650&token=0MkVbiUFwE&height=150&src=pr)](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 68.32% 67.99% -0.33%
- Complexity 919 935 +16
============================================
Files 100 101 +1
Lines 5717 5856 +139
Branches 867 889 +22
============================================
+ Hits 3906 3982 +76
- Misses 1247 1297 +50
- Partials 564 577 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.87% <0%> (-2.6%)` | `11 <0> (ø)` | |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `95.97% <100%> (+0.1%)` | `21 <0> (ø)` | :arrow_down: |
| [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.66% <55.66%> (ø)` | `13 <13> (?)` | |
| [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `73.49% <0%> (-0.42%)` | `20% <0%> (ø)` | |
| [rsc/src/main/java/org/apache/livy/rsc/RSCConf.java](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDb25mLmphdmE=) | `85.98% <0%> (+0.13%)` | `7% <0%> (ø)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `69.36% <0%> (+0.25%)` | `46% <0%> (+2%)` | :arrow_up: |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.81% <0%> (+0.84%)` | `42% <0%> (+1%)` | :arrow_up: |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=footer). Last update [4de6258...244a56a](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services