You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/04 13:27:25 UTC
[GitHub] [nifi] ophers opened a new pull request #4182: NIFI-7318 Allow
'docker stop' to gracefully shutdown
ophers opened a new pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182
#### Description of PR
_Enables docker graceful shutdown functionality; fixes bug NIFI-7318._
As it is, issuing 'docker stop' will immediatly exit the container.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-609689761
@ekovacs - you may want to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ekovacs commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ekovacs commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-615277993
thanks! looks good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ophers commented on a change in pull request #4182:
NIFI-7318 Allow 'docker stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ophers commented on a change in pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#discussion_r404741402
##########
File path: nifi-docker/dockerhub/sh/start.sh
##########
@@ -79,11 +79,12 @@ case ${AUTH} in
esac
# Continuously provide logs so that 'docker logs' can produce them
-tail -F "${NIFI_HOME}/logs/nifi-app.log" &
"${NIFI_HOME}/bin/nifi.sh" run &
nifi_pid="$!"
+tail -F --pid=${nifi_pid} "${NIFI_HOME}/logs/nifi-app.log" &
-trap "echo Received trapped signal, beginning shutdown...;" KILL TERM HUP INT EXIT;
+trap 'echo Received trapped signal, beginning shutdown...;./bin/nifi.sh stop;exit 0;' KILL TERM HUP INT;
Review comment:
Sorry for the late response... we're on the eve of a COVID-19 curfew here...
Yes, I agree with you KILL is superfluous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ophers commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ophers commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-615882424
Thanks. I actually had a excellent experience with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-615880234
Merged to master, thanks for the contribution @ophers, thanks for the review @ekovacs !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ekovacs commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ekovacs commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-615278320
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ekovacs commented on a change in pull request #4182:
NIFI-7318 Allow 'docker stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ekovacs commented on a change in pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#discussion_r404322732
##########
File path: nifi-docker/dockerhub/sh/start.sh
##########
@@ -79,11 +79,12 @@ case ${AUTH} in
esac
# Continuously provide logs so that 'docker logs' can produce them
-tail -F "${NIFI_HOME}/logs/nifi-app.log" &
"${NIFI_HOME}/bin/nifi.sh" run &
nifi_pid="$!"
+tail -F --pid=${nifi_pid} "${NIFI_HOME}/logs/nifi-app.log" &
-trap "echo Received trapped signal, beginning shutdown...;" KILL TERM HUP INT EXIT;
+trap 'echo Received trapped signal, beginning shutdown...;./bin/nifi.sh stop;exit 0;' KILL TERM HUP INT;
Review comment:
I know it is not added in this change, but let's remove `KILL` SIGNAL_SPEC, as trap cannot / nothing can catch sigkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ophers commented on issue #4182: NIFI-7318 Allow 'docker
stop' to gracefully shutdown
Posted by GitBox <gi...@apache.org>.
ophers commented on issue #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#issuecomment-609686082
Hi, I was asked to:
> Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
But I'm not sure how I can assist to resolve the issue with MacOS from the ci-workflow.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services